GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add `Deleted` as a graphic feature by kushalkolar · Pull Request #404 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Feb 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This makes it possible to create callbacks to do things when a Graphic is deleted from a PlotArea.

garbage collection is actinng wonky again so I need to fix that too... nevermind, I think was accessing stuff users wouldn't normally access in jupyter so ipython was clinging onto it, as usual 😄

This also changes all feature_events class attributes to be a set.

Useage:
image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
add 'Deleted' as a graphic feature
5b95ba5
@kushalkolar
kushalkolar requested a review from clewis7 February 19, 2024 10:32
@kushalkolar
kushalkolar marked this pull request as ready for review February 19, 2024 10:36
@kushalkolar kushalkolar mentioned this pull request Feb 19, 2024
legends, part 1 #406
Merged
@kushalkolar

kushalkolar commented Feb 19, 2024

Copy link
Copy Markdown
Member Author

@clewis7 notebook tests are failing due to a new change in pygfx which we haven't caught up to yet, but I want to merge this anyways and deal with the pygfx changes later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 reviewed Feb 19, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple of clarifying questions? Has been too long since I have looked at this. Otherwise, LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/graphics/_features/_deleted.py
def __init__(self, parent, value: bool):
super(Deleted, self).__init__(parent, value)

def _set(self, value: bool):

@clewis7 clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this will get triggered when __del__ is called and self.deleted = True is set?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clewis7 clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we preventing users from if a graphic has been deleted to still having reference to the graphic and trying to say something silly like graphic.deleted=False? Will this throw an error if the graphic has already been deleted? I would assume so because there will be no reference.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kushalkolar kushalkolar Feb 20, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this will get triggered when __del__ is called and self.deleted = True is set?

Yes, Graphic.__del__ sets self.deleted = True https://github.com/fastplotlib/fastplotlib/pull/404/files#diff-a57994ecff1cde4e05c8175265219f0b5200da144ce8733b9eb560c09bcea7ddR179

How are we preventing users from if a graphic has been deleted to still having reference to the graphic and trying to say something silly like graphic.deleted=False? Will this throw an error if the graphic has already been deleted? I would assume so because there will be no reference.

Since users are only given acccess to weakreferences, it will throw a reference error if they try to do anything with a deleted Graphic.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/graphics/_features/_deleted.py

pick_info = {
"index": None,
"collection-index": self._collection_index,

@clewis7 clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference here between index vs collection-index? Also, collection-index could be None if the graphic is not a CollectionGraphic, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clewis7 clewis7 Feb 19, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like index will always be None?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kushalkolar kushalkolar Feb 20, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index is buffer index, used for things like data and colors features. Not used here since it's not relevant

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
kushalkolar merged commit 78f1d2a into main Feb 20, 2024
kushalkolar added a commit that referenced this pull request Feb 20, 2024
@kushalkolar
add 'Deleted' as a graphic feature (#404)
d537a4e
@kushalkolar
kushalkolar deleted the deleted-feature branch February 26, 2024 06:58
kushalkolar added a commit that referenced this pull request Feb 29, 2024
@kushalkolar
legends, part 1 (#406)
8919d7c 
* start legends, not functional yet

* add faq (#400)

* fix bug when remove_graphic() is used (#405)

* add 'Deleted' as a graphic feature (#404)

* very basic adding line legends works

* use OrderedDict for legend items

* allow accessing legend items via Graphic, updating colors works

* legend mesh resizes properly

* remove legend items and reorder works

* enforce all legend labels to be unique

* add legends property to PlotArea

* checks for Graphic name

* highlight linegraphic when legend item is clicked

* legend is moveable

* remove weird characters that were committed for some reason

* progress on legend grid placement, not yet working

* max_rows works for legend

* just allow max_rows kwarg for legends, no cols

* line that snuck in from another branch

* small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.