GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix bug when remove_graphic() is used by kushalkolar · Pull Request #405 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Feb 19, 2024

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
fix bug when remove_graphic() is used
f79796a
@kushalkolar

kushalkolar commented Feb 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Notebook tests are failing due to new changes in pygfx we haven't caught up with yet, merging this since it's working locally. Will catchup with pygfx@main soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit cf4a04b into main Feb 19, 2024
kushalkolar added a commit that referenced this pull request Feb 20, 2024
@kushalkolar
fix bug when remove_graphic() is used (#405)
0967ea0
@kushalkolar
kushalkolar deleted the fix-add-remove-graphic branch February 26, 2024 06:58
kushalkolar added a commit that referenced this pull request Feb 29, 2024
@kushalkolar
legends, part 1 (#406)
8919d7c 
* start legends, not functional yet

* add faq (#400)

* fix bug when remove_graphic() is used (#405)

* add 'Deleted' as a graphic feature (#404)

* very basic adding line legends works

* use OrderedDict for legend items

* allow accessing legend items via Graphic, updating colors works

* legend mesh resizes properly

* remove legend items and reorder works

* enforce all legend labels to be unique

* add legends property to PlotArea

* checks for Graphic name

* highlight linegraphic when legend item is clicked

* legend is moveable

* remove weird characters that were committed for some reason

* progress on legend grid placement, not yet working

* max_rows works for legend

* just allow max_rows kwarg for legends, no cols

* line that snuck in from another branch

* small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.