GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||
GeezerVison is showing github.com — Refactor imwidget by apasarkar · Pull Request #459 · fastplotlib/fastplotlib Conversation
|
|
I think we can use the Currently fastplotlib/fastplotlib/widgets/image.py Lines 540 to 546 in 5ec3fb2
and then in fastplotlib/fastplotlib/widgets/image.py Lines 218 to 221 in 5ec3fb2
when iterating through each individual data array, we do something like this to prevent out of bounds indices for the data arrays which have fewer "t" or "z" items (ex. corr images) than the other data arrays (ex. movies). current_index = dict() for k in self._current_index: dim_ix = dict(reversed(ALLOWED_SLIDER_DIMS))[k] current_index[k] = min(self._current_index[k], data.shape[dim_ix]) It'll be generally useful anytime the shapes are very different. Might want to raise a warning in the constructor and |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…num_scrollable_dims
… a list of indices which are to be displayed as rgba
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…num to n for readability, makes rgb init parameter a list of boolean values
…length as number of arrays being displayed
…array so it can be applied in a modular fashion to each individual array
…ing the max length logic to reflect the mixed types and also adding explicit property for histogram_widget
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@kushalkolar It seems the tests for pre-existing cells in image_widget_test.ipynb are failing. The rgba_to_rgb function seems to complain that the input has 2 indices but 3 indices are indexed etc. Let me know what you think, maybe we need to update the rgba_to_rgb function? Once we have that fixed, I can re-run to generate + update new screenshots. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've made this a full PR from the draft so the CI will run on GitHub actions, we can check the result tomorrow. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
* fefactor imwidget, restrict to tzxy, txy, xy, added RGB(A) support (#459) * add new iw test screenshots * update api docs --------- Co-authored-by: Amol Pasarkar <[email protected]>
* figure refactor seems to work * update nbs w.r.t. new figure * update test util * black * remove lingering uses of gridplot * update API doc generation * update contributing * typo Co-authored-by: Caitlin Lewis <[email protected]> * Iw refactor (#482) * fefactor imwidget, restrict to tzxy, txy, xy, added RGB(A) support (#459) * add new iw test screenshots * update api docs --------- Co-authored-by: Amol Pasarkar <[email protected]> * figure refactor seems to work * update nbs w.r.t. new figure * update test util * black * remove lingering uses of gridplot * update API doc generation * update contributing * typos * update iw with FIgure * update api docs * black * update quickstart * update iw examples * update iw type annotations * default cmap iw * remove gp docs * update readme * forgot to delete more api docs * I need to run nbs before committing them * more docs --------- Co-authored-by: Caitlin Lewis <[email protected]> Co-authored-by: Amol Pasarkar <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Refactor ImageWidget
There was an error while loading. Please reload this page.