GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `Gridplot` -> `Figure` by kushalkolar · Pull Request #479 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Apr 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #457

This PR breaks everything 😄

  • Gridplot renamed to Figure
  • Plot is removed in favor of just doing Figure() since the default shape=(1, 1), i.e. "gridplot" with a single subplot
  • Frame merged into Figure
  • RecordMixin -> FigureRecorder
    • record is now an instance of Figure, use composition instead of inheritance, I haven't tested that this works yet, right now it's still a very experimental feature
  • _frame module renamed to output, some reorganization of what is public/private within that module to make it more logical
  • updated all the examples and tests
  • update ImageWidget

Still need to do this for ImageWidget, waiting for #459 , rest of it is good to go and tests are passing on my end 🥳

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein reacted with rocket emoji
All reactions
  • 🚀 1 reaction
kushalkolar added 5 commits April 7, 2024 10:28
@kushalkolar
figure refactor seems to work
dae0105
@kushalkolar
update nbs w.r.t. new figure
97d2101
@kushalkolar
update test util
1e7c17c
@kushalkolar
black
01fe334
@kushalkolar
remove lingering uses of gridplot
5e730c1
@kushalkolar
kushalkolar requested review from almarklein and clewis7 April 7, 2024 15:34
kushalkolar added 2 commits April 7, 2024 11:36
@kushalkolar
update API doc generation
594eaaa
@kushalkolar
update contributing
e767a50
@kushalkolar

kushalkolar commented Apr 7, 2024

Copy link
Copy Markdown
Member Author

when reviewing don't be scared by the size of the diff, it's mostly stuff being moved around, and the changes to the examples are mostly renaming stuff from plot -> figure, gridplot -> figure 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 previously approved these changes Apr 9, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly just a big refactor but I think this cleans up a lot of the soup and better organizes the repo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/layouts/_figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Apr 9, 2024
gridplot controllers kwarg is back, other improvements to gp #477
Merged
3 tasks done
@kushalkolar
kushalkolar dismissed clewis7’s stale review via 1686307 April 12, 2024 04:39
kushalkolar and others added 13 commits April 12, 2024 00:39
@kushalkolar @clewis7
typo
1686307 
Co-authored-by: Caitlin Lewis <[email protected]>
@kushalkolar @apasarkar
Iw refactor (#482)
e7d940d 
* fefactor imwidget, restrict to tzxy, txy, xy, added RGB(A) support (#459)

* add new iw test screenshots

* update api docs

---------

Co-authored-by: Amol Pasarkar <[email protected]>
@kushalkolar
figure refactor seems to work
c3f35c5
@kushalkolar
update nbs w.r.t. new figure
fab08bf
@kushalkolar
update test util
deda9ab
@kushalkolar
black
0a0e6fa
@kushalkolar
remove lingering uses of gridplot
40b7533
@kushalkolar
update API doc generation
04740bb
@kushalkolar
update contributing
b28480f
@kushalkolar
typos
1cdf4f8
@kushalkolar
update iw with FIgure
f8cd545
@kushalkolar
update api docs
712fa54
@kushalkolar
fix merge conflict
ca0aba6
@kushalkolar
kushalkolar marked this pull request as ready for review April 12, 2024 05:15
@kushalkolar
black
158b3f9
@kushalkolar

kushalkolar commented Apr 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Idea: if figure.shape == (1, 1), should be make figure.__getitem__ just pass to subplot.__getitem__ so the user doesn't have to do figure[0, 0] 🤔

edit: No, keep things consistent
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
update quickstart
4829fe7
kushalkolar added 8 commits April 12, 2024 01:38
@kushalkolar
update iw examples
a69ebca
@kushalkolar
update iw type annotations
e3e5e83
@kushalkolar
default cmap iw
39de5bc
@kushalkolar
remove gp docs
ee12e5b
@kushalkolar
update readme
cf52694
@kushalkolar
forgot to delete more api docs
25864fb
@kushalkolar
I need to run nbs before committing them
2da5f1d
@kushalkolar
more docs
76bc98f
@kushalkolar
kushalkolar merged commit 25aa9e3 into main Apr 12, 2024
@kushalkolar
kushalkolar deleted the figure branch April 12, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments
@almarklein almarklein Awaiting requested review from almarklein

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GridPlot -> Figure as the only user-facing layout

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.