GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Return 422 on bad push source name by robhowley · Pull Request #3214 · feast-dev/feast

Conversation

@robhowley

@robhowley robhowley commented Sep 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Signed-off-by: Rob Howley [email protected]

What this PR does / why we need it:

  • added a new exception for push source not found
  • in the feature store, raise the PushSourceNotFoundException when a push source name is provided that doesn't exist
  • in feature server /push endpoint, return 422 in the case of a push source not found

Which issue(s) this PR fixes:

Fixes #3210

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Rob Howley
return 422 on bad push source name
a0a7316
Signed-off-by: Rob Howley <[email protected]>
@feast-ci-bot feast-ci-bot added do-not-merge/work-in-progress size/S labels Sep 15, 2022
@robhowley robhowley changed the title return 422 on bad push source name fix: Return 422 on bad push source name Sep 15, 2022
@codecov-commenter

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.84%. Comparing base (59b4853) to head (5ef4216).
⚠️ Report is 1601 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
+ Coverage   67.31%   76.84%   +9.52%     
==========================================
  Files         179      216      +37     
  Lines       16276    18559    +2283     
==========================================
+ Hits        10956    14261    +3305     
+ Misses       5320     4298    -1022     
Flag Coverage Δ
integrationtests 67.76% <100.00%> (+0.44%) ⬆️
unittests 58.16% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@robhowley
robhowley marked this pull request as ready for review September 15, 2022 01:14
@feast-ci-bot feast-ci-bot removed the do-not-merge/work-in-progress label Sep 15, 2022
adchia
adchia approved these changes Sep 15, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot assigned adchia Sep 15, 2022
@feast-ci-bot feast-ci-bot added lgtm approved labels Sep 15, 2022
Rob Howley
fix: cant send empty df
c084b1b
Signed-off-by: Rob Howley <[email protected]>
@feast-ci-bot feast-ci-bot added size/M and removed lgtm size/S labels Sep 15, 2022
@robhowley

robhowley commented Sep 15, 2022

Copy link
Copy Markdown
Contributor Author

im a little confused. i signed the commits and DCO check agreed. not sure what block is referring to when it says, "Merging is blocked. The base branch requires all commits to be signed."

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Rob Howley added 2 commits September 15, 2022 16:11
Rob Howley @adchia
return 422 on bad push source name
570f674
Signed-off-by: Rob Howley <[email protected]>
Rob Howley @adchia
fix: cant send empty df
a4ff8c1
Signed-off-by: Rob Howley <[email protected]>
@adchia
adchia force-pushed the rh-push-api-error-msg branch from c084b1b to a4ff8c1 Compare September 15, 2022 20:12
@adchia

adchia commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

Yeah that's just a red herring. Your pushed changes removed the "lgtm" tag so it couldn't merge

robhowley reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia
adchia approved these changes Sep 15, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot added the lgtm label Sep 15, 2022
@robhowley
robhowley marked this pull request as draft September 15, 2022 20:49
@feast-ci-bot feast-ci-bot added the do-not-merge/work-in-progress label Sep 15, 2022
@robhowley

robhowley commented Sep 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

converted to draft while i fix the integration test

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Rob Howley added 2 commits September 27, 2022 21:29
Rob Howley
fix: json.dumps the body in the post 🤦
2397095
Signed-off-by: Rob Howley <[email protected]>
Rob Howley
chore: merge conflicts
5ef4216
Signed-off-by: Rob Howley <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Sep 28, 2022
@robhowley
robhowley marked this pull request as ready for review September 28, 2022 01:56
@feast-ci-bot feast-ci-bot removed the do-not-merge/work-in-progress label Sep 28, 2022
@robhowley

robhowley commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

hey @adchia, i finally got around to fixing the integration test. looks like everything passed. thanks for your patience.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia
adchia approved these changes Sep 29, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@feast-ci-bot feast-ci-bot added the lgtm label Sep 29, 2022
@feast-ci-bot

feast-ci-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, robhowley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot
feast-ci-bot merged commit b851e01 into feast-dev:master Sep 29, 2022
@robhowley
robhowley deleted the rh-push-api-error-msg branch September 29, 2022 13:15
adchia pushed a commit that referenced this pull request Sep 30, 2022
@robhowley Rob Howley @adchia
fix: Return 422 on bad push source name (#3214)
8abbcd9
* return 422 on bad push source name

Signed-off-by: Rob Howley <[email protected]>

* fix: cant send empty df

Signed-off-by: Rob Howley <[email protected]>

* return 422 on bad push source name

Signed-off-by: Rob Howley <[email protected]>

* fix: cant send empty df

Signed-off-by: Rob Howley <[email protected]>

* fix: json.dumps the body in the post 🤦

Signed-off-by: Rob Howley <[email protected]>

Signed-off-by: Rob Howley <[email protected]>
Co-authored-by: Rob Howley <[email protected]>
adchia pushed a commit that referenced this pull request Sep 30, 2022
@feast-ci-bot
chore(release): release 0.25.1
3102b44
## [0.25.1](v0.25.0...v0.25.1) (2022-09-30)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995))
* Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58))
* Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9))
* Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))
hao-affirm pushed a commit to Affirm/feast that referenced this pull request Oct 2, 2022
@feast-ci-bot @hao-affirm
chore(release): release 0.25.1
284ea97
## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))
kevjumba pushed a commit that referenced this pull request Oct 6, 2022
@feast-ci-bot
chore(release): release 0.26.0
7417dd3
# [0.26.0](v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7))
* Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb))
* Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([#3267](#3267)) ([a9d48d0](a9d48d0))
* Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01))
* Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f))
* Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda))
* Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1))

### Features

* Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19))
* Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757))
* Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f))
* BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Oct 18, 2022
@feast-ci-bot @franciscojavierarceo
chore(release): release 0.26.0
e2fba60
# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb))
* Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01))
* Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda))
* Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1))

### Features

* Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19))
* Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757))
* Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f))
* BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push api call to a push source that doesn't exist returns 200

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@robhowley @codecov-commenter @adchia @feast-ci-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.