GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Fix docker image for feature-server by kevjumba · Pull Request #3272 · feast-dev/feast

Conversation

kevjumba commented Oct 5, 2022

Copy link

Copy Markdown

Collaborator

Signed-off-by: Kevin Zhang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3265

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fix

de3e077

Signed-off-by: Kevin Zhang <[email protected]>

feast-ci-bot added approved size/XS labels

Oct 5, 2022

kevjumba requested a review from adchia

October 5, 2022 23:18

kevjumba added the ok-to-test label

Oct 5, 2022

adchia reviewed

Oct 5, 2022

View reviewed changes

Comment thread

sdk/python/feast/infra/feature_servers/multicloud/Dockerfile Outdated

		@@ -9,7 +9,8 @@ RUN apt update && \

		RUN pip install pip --upgrade
		COPY . .

adchia Oct 5, 2022

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kevjumba Oct 5, 2022

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/workflows/publish.yml Outdated

		build-publish-docker-images:
		runs-on: ubuntu-latest
		needs: get-version
		needs: [get-version, build_wheels]

adchia Oct 5, 2022

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be after the publish sdk step not build wheels

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kevjumba Oct 5, 2022

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kevjumba Oct 5, 2022

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fix

4af06c3

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba requested a review from adchia

October 5, 2022 23:24

adchia approved these changes

Oct 5, 2022

View reviewed changes

adchia left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned adchia

Oct 5, 2022

feast-ci-bot added the lgtm label

Oct 5, 2022

feast-ci-bot commented Oct 5, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov-commenter commented Oct 5, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Base: 67.71% // Head: 76.77% // Increases project coverage by +9.05% 🎉

Coverage data is based on head (4af06c3) compared to base (6bc91c2).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   67.71%   76.77%   +9.05%     
==========================================
  Files         181      218      +37     
  Lines       16615    18443    +1828     
==========================================
+ Hits        11251    14159    +2908     
+ Misses       5364     4284    -1080

Flag	Coverage Δ
integrationtests	`67.53% <ø> (-0.18%)`	⬇️
unittests	`57.93% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/ui_server.py	`22.64% <0.00%> (-1.28%)`	⬇️
...on/feast/infra/materialization/snowflake_engine.py	`93.18% <0.00%> (-0.41%)`	⬇️
...tion/contrib/spark/spark_materialization_engine.py	`71.84% <0.00%> (-0.28%)`	⬇️
..._stores/contrib/postgres_offline_store/postgres.py	`34.14% <0.00%> (ø)`
...ib/trino_offline_store/test_config/manual_tests.py	`33.33% <0.00%> (ø)`
...thon/feast/infra/online_stores/contrib/postgres.py	`32.07% <0.00%> (ø)`
sdk/python/feast/transformation_server.py	`40.47% <0.00%> (ø)`
...tores/contrib/trino_offline_store/trino_queries.py	`14.58% <0.00%> (ø)`
...ine_stores/contrib/cassandra_repo_configuration.py	`100.00% <0.00%> (ø)`
...ores/contrib/trino_offline_store/tests/__init__.py	`100.00% <0.00%> (ø)`
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot merged commit eff01d1 into feast-dev:master

Oct 6, 2022

kevjumba added a commit that referenced this pull request

Oct 6, 2022


          fix: Fix docker image for feature-server (#3272)

4ce366a

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>

kevjumba pushed a commit that referenced this pull request

Oct 6, 2022


          chore(release): release 0.25.2

de8334f

## [0.25.2](v0.25.1...v0.25.2) (2022-10-06)

### Bug Fixes

* Fix docker image for feature-server ([#3272](#3272)) ([4ce366a](4ce366a))
* Fix Feast UI release process to update the feast-ui package  ([#3267](#3267)) ([d118fe4](d118fe4))
* Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([efbd4b0](efbd4b0))
* Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([f4a83a7](f4a83a7))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([7fa4bbf](7fa4bbf))

kevjumba pushed a commit that referenced this pull request

Oct 6, 2022


          chore(release): release 0.26.0

7417dd3

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7))
* Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb))
* Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([#3267](#3267)) ([a9d48d0](a9d48d0))
* Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01))
* Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f))
* Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda))
* Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1))

### Features

* Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19))
* Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757))
* Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f))
* BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request

Oct 18, 2022


          fix: Fix docker image for feature-server (feast-dev#3272)

1a7716a

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>

franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request

Oct 18, 2022


          chore(release): release 0.26.0

e2fba60

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb))
* Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01))
* Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda))
* Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1))

### Features

* Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19))
* Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757))
* Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f))
* BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

Reviewers

adchia

adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

adchia

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feast-feature-server ModuleNotFoundError: No module named 'feast.embedded_go'

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kevjumba commented Oct 5, 2022

Uh oh!

adchia Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

kevjumba Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

adchia Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

kevjumba Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

kevjumba Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

adchia left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Oct 5, 2022

Uh oh!

codecov-commenter commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Oct 5, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.