GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Ensure that Snowflake accounts for number columns that overspecify precision by adchia · Pull Request #3306 · feast-dev/feast

Conversation

@adchia

@adchia adchia commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

This is because the default numeric type in Snowflake has up to 38 digits (surpassing the limits of INT64)

Signed-off-by: Danny Chiao [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adchia
fix: Ensure that Snowflake properly accounts for INT32/INT64 columns …
1935294 
…with default precision 38 type

Signed-off-by: Danny Chiao <[email protected]>
@adchia
adchia requested a review from sfc-gh-madkins as a code owner October 19, 2022 19:14
@feast-ci-bot feast-ci-bot added approved size/XS labels Oct 19, 2022
@codecov-commenter

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 67.69% // Head: 76.74% // Increases project coverage by +9.04% 🎉

Coverage data is based on head (3b3fbac) compared to base (b5e734b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
+ Coverage   67.69%   76.74%   +9.04%     
==========================================
  Files         181      218      +37     
  Lines       16637    18466    +1829     
==========================================
+ Hits        11262    14171    +2909     
+ Misses       5375     4295    -1080
Flag Coverage Δ
integrationtests 67.48% <0.00%> (-0.22%) ⬇️
unittests 57.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/feast/infra/offline_stores/snowflake_source.py 85.03% <0.00%> (-4.18%) ⬇️
...on/feast/infra/materialization/snowflake_engine.py 93.18% <0.00%> (-0.41%) ⬇️
...tion/contrib/spark/spark_materialization_engine.py 71.84% <0.00%> (-0.28%) ⬇️
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
.../contrib/athena_offline_store/tests/data_source.py 46.66% <0.00%> (ø)
...stores/contrib/trino_offline_store/trino_source.py 5.37% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 100.00% <0.00%> (ø)
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...hon/feast/infra/utils/postgres/connection_utils.py 48.00% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sfc-gh-madkins
sfc-gh-madkins reviewed Oct 20, 2022
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/snowflake_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sfc-gh-madkins
fix: Snowflake infer snowflake OBJECT return type for number inference
3b3fbac 
Signed-off-by: miles.adkins <[email protected]>
@sfc-gh-madkins
sfc-gh-madkins force-pushed the fixSnowflake branch from 44d239b to 3b3fbac Compare October 26, 2022 18:16
@feast-ci-bot feast-ci-bot added size/S and removed size/XS labels Oct 26, 2022
@sfc-gh-madkins

sfc-gh-madkins commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned sfc-gh-madkins Oct 26, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Oct 26, 2022
@sfc-gh-madkins
sfc-gh-madkins enabled auto-merge (squash) October 26, 2022 18:22
@sfc-gh-madkins
sfc-gh-madkins requested review from achals and kevjumba October 26, 2022 18:47
achals
achals approved these changes Oct 26, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sfc-gh-madkins
sfc-gh-madkins merged commit 0ad0ace into feast-dev:master Oct 26, 2022
@feast-ci-bot feast-ci-bot assigned achals Oct 26, 2022
@feast-ci-bot

feast-ci-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kevjumba pushed a commit that referenced this pull request Dec 5, 2022
@feast-ci-bot
chore(release): release 0.27.0
1d3c111 
# [0.27.0](v0.26.0...v0.27.0) (2022-12-05)

### Bug Fixes

* Changing Snowflake template code to avoid query not implemented … ([#3319](#3319)) ([1590d6b](1590d6b))
* Dask zero division error if parquet dataset has only one partition ([#3236](#3236)) ([69e4a7d](69e4a7d))
* Enable Spark materialization on Yarn ([#3370](#3370)) ([0c20a4e](0c20a4e))
* Ensure that Snowflake accounts for number columns that overspecify precision ([#3306](#3306)) ([0ad0ace](0ad0ace))
* Fix memory leak from usage.py not properly cleaning up call stack ([#3371](#3371)) ([a0c6fde](a0c6fde))
* Fix workflow to contain env vars ([#3379](#3379)) ([548bed9](548bed9))
* Update bytewax materialization ([#3368](#3368)) ([4ebe00f](4ebe00f))
* Update the version counts ([#3378](#3378)) ([8112db5](8112db5))
* Updated AWS Athena template ([#3322](#3322)) ([5956981](5956981))
* Wrong UI data source type display ([#3276](#3276)) ([8f28062](8f28062))

### Features

* Cassandra online store, concurrency in bulk write operations ([#3367](#3367)) ([eaf354c](eaf354c))
* Cassandra online store, concurrent fetching for multiple entities ([#3356](#3356)) ([00fa21f](00fa21f))
* Get Snowflake Query Output As Pyspark Dataframe ([#2504](#2504)) ([#3358](#3358)) ([2f18957](2f18957))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-madkins sfc-gh-madkins sfc-gh-madkins left review comments
@achals achals achals approved these changes
@kevjumba kevjumba Awaiting requested review from kevjumba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@achals achals

@sfc-gh-madkins sfc-gh-madkins

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adchia @codecov-commenter @sfc-gh-madkins @feast-ci-bot @achals
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.