GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Changing Snowflake template code to avoid query not implemented … by sfc-gh-madkins · Pull Request #3319 · feast-dev/feast

Conversation

@sfc-gh-madkins

@sfc-gh-madkins sfc-gh-madkins commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

…error

Signed-off-by: miles.adkins [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sfc-gh-madkins
fix: Changing Snowflake template code to avoid query not implemented …
82a96db 
…error

Signed-off-by: miles.adkins <[email protected]>
@feast-ci-bot feast-ci-bot added approved size/XS labels Oct 27, 2022
@sfc-gh-madkins sfc-gh-madkins added ok-to-test and removed size/XS labels Oct 27, 2022
@sfc-gh-madkins sfc-gh-madkins mentioned this pull request Oct 27, 2022
fix: Changing Snowflake template code to avoid query not implemented error… #3315
Closed
@codecov-commenter

codecov-commenter commented Oct 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 67.65% // Head: 76.74% // Increases project coverage by +9.08% 🎉

Coverage data is based on head (82a96db) compared to base (0ad0ace).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3319      +/-   ##
==========================================
+ Coverage   67.65%   76.74%   +9.08%     
==========================================
  Files         181      218      +37     
  Lines       16645    18466    +1821     
==========================================
+ Hits        11262    14171    +2909     
+ Misses       5383     4295    -1088
Flag Coverage Δ
integrationtests 67.48% <ø> (-0.18%) ⬇️
unittests 57.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py 93.18% <0.00%> (-0.41%) ⬇️
...tion/contrib/spark/spark_materialization_engine.py 71.84% <0.00%> (-0.28%) ⬇️
...thon/feast/infra/online_stores/contrib/postgres.py 32.07% <0.00%> (ø)
..._stores/contrib/postgres_offline_store/postgres.py 34.14% <0.00%> (ø)
...ores/contrib/mssql_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...ib/trino_offline_store/test_config/manual_tests.py 33.33% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
amithadiraju1694
amithadiraju1694 approved these changes Oct 28, 2022
View reviewed changes
adchia
adchia approved these changes Oct 28, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned adchia Oct 28, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Oct 28, 2022
@feast-ci-bot

feast-ci-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, amithadiraju1694, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,sfc-gh-madkins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot
feast-ci-bot merged commit 1590d6b into feast-dev:master Oct 28, 2022
kevjumba pushed a commit that referenced this pull request Dec 5, 2022
@feast-ci-bot
chore(release): release 0.27.0
1d3c111 
# [0.27.0](v0.26.0...v0.27.0) (2022-12-05)

### Bug Fixes

* Changing Snowflake template code to avoid query not implemented … ([#3319](#3319)) ([1590d6b](1590d6b))
* Dask zero division error if parquet dataset has only one partition ([#3236](#3236)) ([69e4a7d](69e4a7d))
* Enable Spark materialization on Yarn ([#3370](#3370)) ([0c20a4e](0c20a4e))
* Ensure that Snowflake accounts for number columns that overspecify precision ([#3306](#3306)) ([0ad0ace](0ad0ace))
* Fix memory leak from usage.py not properly cleaning up call stack ([#3371](#3371)) ([a0c6fde](a0c6fde))
* Fix workflow to contain env vars ([#3379](#3379)) ([548bed9](548bed9))
* Update bytewax materialization ([#3368](#3368)) ([4ebe00f](4ebe00f))
* Update the version counts ([#3378](#3378)) ([8112db5](8112db5))
* Updated AWS Athena template ([#3322](#3322)) ([5956981](5956981))
* Wrong UI data source type display ([#3276](#3276)) ([8f28062](8f28062))

### Features

* Cassandra online store, concurrency in bulk write operations ([#3367](#3367)) ([eaf354c](eaf354c))
* Cassandra online store, concurrent fetching for multiple entities ([#3356](#3356)) ([00fa21f](00fa21f))
* Get Snowflake Query Output As Pyspark Dataframe ([#2504](#2504)) ([#3358](#3358)) ([2f18957](2f18957))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes
+1 more reviewer
@amithadiraju1694 amithadiraju1694 amithadiraju1694 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feast[snowflake] demo workflow fails to get historical features through sql. get_table_query_string not implemented

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sfc-gh-madkins @codecov-commenter @feast-ci-bot @adchia @amithadiraju1694
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.