GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Snowflake skip materialization if no table change by sfc-gh-khaynie · Pull Request #3404 · feast-dev/feast

Conversation

@sfc-gh-khaynie

@sfc-gh-khaynie sfc-gh-khaynie commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Katy Haynie [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3369

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sfc-gh-khaynie
feat: Snowflake skip materialization if no table change
44bb32a
Signed-off-by: Katy Haynie <[email protected]>
@sfc-gh-khaynie
sfc-gh-khaynie requested a review from sfc-gh-madkins as a code owner December 19, 2022 21:59
@feast-ci-bot feast-ci-bot added the size/S label Dec 19, 2022
@sfc-gh-madkins

sfc-gh-madkins commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

/ok-to-test

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot feast-ci-bot added the ok-to-test label Dec 19, 2022
@sfc-gh-khaynie
removing print statement from offline snowflake.py
365382f
Signed-off-by: Katy Haynie <[email protected]>
@sfc-gh-madkins
sfc-gh-madkins enabled auto-merge (squash) December 19, 2022 22:21
@sfc-gh-madkins

sfc-gh-madkins commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

/approve

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot feast-ci-bot added the approved label Dec 19, 2022
@sfc-gh-madkins

sfc-gh-madkins commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

/lgtm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot feast-ci-bot assigned sfc-gh-madkins Dec 19, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Dec 19, 2022
sfc-gh-madkins
sfc-gh-madkins approved these changes Dec 19, 2022
View reviewed changes
@feast-ci-bot

feast-ci-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katyhaynie-snowflake, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [sfc-gh-madkins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@feast-ci-bot
feast-ci-bot merged commit 0ab3942 into feast-dev:master Dec 20, 2022
felixwang9817 pushed a commit that referenced this pull request Jan 3, 2023
@feast-ci-bot
chore(release): release 0.28.0
81c3483
# [0.28.0](v0.27.0...v0.28.0) (2023-01-03)

### Bug Fixes

* Apply billing project when infer schema ([#3417](#3417)) ([4f9ad7e](4f9ad7e))
* Assertion condition when value is 0 ([#3401](#3401)) ([98a24a3](98a24a3))
* Enable registry caching in SQL Registry ([#3395](#3395)) ([2e57376](2e57376))
* Fix bug where SQL registry was incorrectly writing infra config around online stores ([#3394](#3394)) ([6bcf77c](6bcf77c))
* Get all columns with describe table method from RedshiftData-api ([#3377](#3377)) ([fd97254](fd97254))
* ODFV able to handle boolean pandas type ([#3384](#3384)) ([8f242e6](8f242e6))
* Remove PySpark dependency from Snowflake Offline Store ([#3388](#3388)) ([7b160c7](7b160c7))
* Specifies timeout in exception polling ([#3398](#3398)) ([c0ca7e4](c0ca7e4))
* Update import logic to remove `pyspark` dependency from Snowflake Offline Store ([#3397](#3397)) ([cf073e6](cf073e6))

### Features

* Add template for Github Codespaces ([#3421](#3421)) ([41c0537](41c0537))
* Adds description attribute for features/fields ([#3425](#3425)) ([26f4881](26f4881))
* Snowflake skip materialization if no table change ([#3404](#3404)) ([0ab3942](0ab3942))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-madkins sfc-gh-madkins sfc-gh-madkins approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sfc-gh-madkins sfc-gh-madkins

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add way to skip snowflake materialization query if no table changes occurred in materialization window

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sfc-gh-khaynie @sfc-gh-madkins @feast-ci-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.