GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Apply billing project when infer schema by sudohainguyen · Pull Request #3417 · feast-dev/feast

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Dec 27, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: Avoid making extra cost on a non-billing project id when applying feature views

Which issue(s) this PR fixes:

Fixes #3416

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sudohainguyen sudohainguyen changed the title Fix: apply billing project when inference Fix: Apply billing project when inference Dec 27, 2022
@feast-ci-bot feast-ci-bot added the size/S label Dec 27, 2022
@sudohainguyen sudohainguyen changed the title Fix: Apply billing project when inference Fix: Apply billing project when infer schema Dec 27, 2022
@sudohainguyen
fix: make inference jobs run on billing project id
5e47e89 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
sudohainguyen force-pushed the fix/apply_billing_project_when_inference branch from 284fab5 to 5e47e89 Compare December 27, 2022 16:01
@sudohainguyen sudohainguyen changed the title Fix: Apply billing project when infer schema fix: Apply billing project when infer schema Dec 27, 2022
achals
achals approved these changes Dec 27, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned achals Dec 27, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Dec 27, 2022
@feast-ci-bot

feast-ci-bot commented Dec 27, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sudohainguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added ok-to-test approved labels Dec 27, 2022
@sudohainguyen

sudohainguyen commented Dec 28, 2022

Copy link
Copy Markdown
Collaborator Author

hi @achals would you mind checking the failed test case? It said
google.api_core.exceptions.ResourceExhausted: 429 Quota exceeded for quota metric 'Table metadata write requests' and limit 'Table metadata write requests per minute per user' of service 'bigtableadmin.googleapis.com' for consumer 'project_number:883187091528'. [reason: "RATE_LIMIT_EXCEEDED"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot
feast-ci-bot merged commit 4f9ad7e into feast-dev:master Dec 28, 2022
@sudohainguyen
sudohainguyen deleted the fix/apply_billing_project_when_inference branch December 28, 2022 03:47
felixwang9817 pushed a commit that referenced this pull request Jan 3, 2023
@feast-ci-bot
chore(release): release 0.28.0
81c3483 
# [0.28.0](v0.27.0...v0.28.0) (2023-01-03)

### Bug Fixes

* Apply billing project when infer schema ([#3417](#3417)) ([4f9ad7e](4f9ad7e))
* Assertion condition when value is 0 ([#3401](#3401)) ([98a24a3](98a24a3))
* Enable registry caching in SQL Registry ([#3395](#3395)) ([2e57376](2e57376))
* Fix bug where SQL registry was incorrectly writing infra config around online stores ([#3394](#3394)) ([6bcf77c](6bcf77c))
* Get all columns with describe table method from RedshiftData-api ([#3377](#3377)) ([fd97254](fd97254))
* ODFV able to handle boolean pandas type ([#3384](#3384)) ([8f242e6](8f242e6))
* Remove PySpark dependency from Snowflake Offline Store ([#3388](#3388)) ([7b160c7](7b160c7))
* Specifies timeout in exception polling ([#3398](#3398)) ([c0ca7e4](c0ca7e4))
* Update import logic to remove `pyspark` dependency from Snowflake Offline Store ([#3397](#3397)) ([cf073e6](cf073e6))

### Features

* Add template for Github Codespaces ([#3421](#3421)) ([41c0537](41c0537))
* Adds description attribute for features/fields ([#3425](#3425)) ([26f4881](26f4881))
* Snowflake skip materialization if no table change ([#3404](#3404)) ([0ab3942](0ab3942))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Job to infer schema from BigQuerySource with query not running on billing project id

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sudohainguyen @feast-ci-bot @achals
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.