GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Bytewax engine create configmap from object by sudohainguyen · Pull Request #3821 · feast-dev/feast

Conversation

sudohainguyen commented Oct 26, 2023

Copy link

Copy Markdown

Collaborator

What this PR does / why we need it: Instead of reading the content of config yaml file to create configmap for bytewax job, we parse directly from repo_config object

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sudohainguyen requested a review from whoahbot as a code owner

October 26, 2023 03:49

sudohainguyen force-pushed the fix/bytewax branch from f6feff7 to 52edcd0 Compare

October 26, 2023 03:53

sudohainguyen changed the title ~~fix: bytewax engine create configmap from object~~ fix: Bytewax engine create configmap from object

Oct 26, 2023

sudohainguyen added the area/infra label

Oct 26, 2023

achals approved these changes

Oct 31, 2023

View reviewed changes

achals added approved ok-to-test lgtm labels

Oct 31, 2023

whoahbot approved these changes

Oct 31, 2023

View reviewed changes


          fix: bytewax engine create configmap from object

497a6b4

Signed-off-by: Hai Nguyen <[email protected]>

sudohainguyen force-pushed the fix/bytewax branch from 52edcd0 to 497a6b4 Compare

November 4, 2023 08:38

sudohainguyen self-assigned this

Nov 5, 2023

sudohainguyen commented Nov 7, 2023

Copy link

Copy Markdown

Collaborator Author

@whoahbot hey this needs some actions as well

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

whoahbot commented Nov 7, 2023

Copy link

Copy Markdown

Collaborator

@whoahbot hey this needs some actions as well

I'm not authorized to merge. We might need some help from @achals on that front.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals merged commit 25e9775 into feast-dev:master

Nov 8, 2023

sudohainguyen deleted the fix/bytewax branch

November 8, 2023 02:33

tqtensor pushed a commit to tqtensor/feast that referenced this pull request

Nov 13, 2023


          fix: Bytewax engine create configmap from object (feast-dev#3821)

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

tqtensor pushed a commit to tqtensor/feast that referenced this pull request

Nov 13, 2023


          fix: Bytewax engine create configmap from object (feast-dev#3821)

c6eac2d

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

woop pushed a commit that referenced this pull request

Jan 13, 2024


          chore(release): release 0.35.0

# [0.35.0](v0.34.0...v0.35.0) (2024-01-13)

### Bug Fixes

* Add async refresh to prevent synchronous refresh in main thread ([#3812](#3812)) ([9583ed6](9583ed6))
* Adopt connection pooling for HBase ([#3793](#3793)) ([b3852bf](b3852bf))
* Bytewax engine create configmap from object ([#3821](#3821)) ([25e9775](25e9775))
* Fix warnings from deprecated paths and update default log level ([#3757](#3757)) ([68a8737](68a8737))
* improve parsing bytewax job status ([5983f40](5983f40))
* make bytewax settings unexposed ([ae1bb8b](ae1bb8b))
* Make generated temp table name escaped ([#3797](#3797)) ([175d796](175d796))
* Pin numpy version to avoid spammy deprecation messages ([774ed33](774ed33))
* Redundant feature materialization and premature incremental materialization timestamp updates ([#3789](#3789)) ([417b16b](417b16b)), closes [#6](#6) [#7](#7)
* Resolve hbase hotspot issue when materializing ([#3790](#3790)) ([7376db8](7376db8))
* Set keepalives_idle None by default ([#3756](#3756)) ([8717e9b](8717e9b))
* Set upper bound for bigquery client due to its breaking changes ([2151c39](2151c39))
* UI project cannot handle fallback routes ([#3766](#3766)) ([96ece0f](96ece0f))
* update dependencies versions due to conflicts ([5dc0b24](5dc0b24))
* Update jackson and remove unnecessary logging ([#3809](#3809)) ([018d0ea](018d0ea))
* upgrade the pyarrow to latest v14.0.1 for CVE-2023-47248. ([052182b](052182b))

### Features

* Add get online feature rpc to gprc server ([#3815](#3815)) ([01db8cc](01db8cc))
* Add materialize and materialize-incremental rest endpoints ([#3761](#3761)) ([fa600fe](fa600fe)), closes [#3760](#3760)
* add redis sentinel support ([3387a15](3387a15))
* add redis sentinel support ([4337c89](4337c89))
* add redis sentinel support format lint ([aad8718](aad8718))
* Add support for `table_create_disposition` in bigquery job for offline store ([#3762](#3762)) ([6a728fe](6a728fe))
* Add support for in_cluster config and additional labels for bytewax materialization ([#3754](#3754)) ([2192e65](2192e65))
* Apply cache to load proto registry for performance ([#3702](#3702)) ([709c709](709c709))
* Make bytewax job write as mini-batches ([#3777](#3777)) ([9b0e5ce](9b0e5ce))
* Optimize bytewax pod resource with zero-copy ([9cf9d96](9cf9d96))
* Support GCS filesystem for bytewax engine ([#3774](#3774)) ([fb6b807](fb6b807))

tqtensor pushed a commit to tqtensor/feast that referenced this pull request

Jan 25, 2024


          fix: Bytewax engine create configmap from object (feast-dev#3821)

9ac1230

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

tokoko pushed a commit to tokoko/feast that referenced this pull request

Feb 6, 2024


          chore(release): release 0.35.0

85b5b55

# [0.35.0](feast-dev/feast@v0.34.0...v0.35.0) (2024-01-13)

### Bug Fixes

* Add async refresh to prevent synchronous refresh in main thread ([feast-dev#3812](feast-dev#3812)) ([9583ed6](feast-dev@9583ed6))
* Adopt connection pooling for HBase ([feast-dev#3793](feast-dev#3793)) ([b3852bf](feast-dev@b3852bf))
* Bytewax engine create configmap from object ([feast-dev#3821](feast-dev#3821)) ([25e9775](feast-dev@25e9775))
* Fix warnings from deprecated paths and update default log level ([feast-dev#3757](feast-dev#3757)) ([68a8737](feast-dev@68a8737))
* improve parsing bytewax job status ([5983f40](feast-dev@5983f40))
* make bytewax settings unexposed ([ae1bb8b](feast-dev@ae1bb8b))
* Make generated temp table name escaped ([feast-dev#3797](feast-dev#3797)) ([175d796](feast-dev@175d796))
* Pin numpy version to avoid spammy deprecation messages ([774ed33](feast-dev@774ed33))
* Redundant feature materialization and premature incremental materialization timestamp updates ([feast-dev#3789](feast-dev#3789)) ([417b16b](feast-dev@417b16b)), closes [feast-dev#6](feast-dev#6) [feast-dev#7](feast-dev#7)
* Resolve hbase hotspot issue when materializing ([feast-dev#3790](feast-dev#3790)) ([7376db8](feast-dev@7376db8))
* Set keepalives_idle None by default ([feast-dev#3756](feast-dev#3756)) ([8717e9b](feast-dev@8717e9b))
* Set upper bound for bigquery client due to its breaking changes ([2151c39](feast-dev@2151c39))
* UI project cannot handle fallback routes ([feast-dev#3766](feast-dev#3766)) ([96ece0f](feast-dev@96ece0f))
* update dependencies versions due to conflicts ([5dc0b24](feast-dev@5dc0b24))
* Update jackson and remove unnecessary logging ([feast-dev#3809](feast-dev#3809)) ([018d0ea](feast-dev@018d0ea))
* upgrade the pyarrow to latest v14.0.1 for CVE-2023-47248. ([052182b](feast-dev@052182b))

### Features

* Add get online feature rpc to gprc server ([feast-dev#3815](feast-dev#3815)) ([01db8cc](feast-dev@01db8cc))
* Add materialize and materialize-incremental rest endpoints ([feast-dev#3761](feast-dev#3761)) ([fa600fe](feast-dev@fa600fe)), closes [feast-dev#3760](feast-dev#3760)
* add redis sentinel support ([3387a15](feast-dev@3387a15))
* add redis sentinel support ([4337c89](feast-dev@4337c89))
* add redis sentinel support format lint ([aad8718](feast-dev@aad8718))
* Add support for `table_create_disposition` in bigquery job for offline store ([feast-dev#3762](feast-dev#3762)) ([6a728fe](feast-dev@6a728fe))
* Add support for in_cluster config and additional labels for bytewax materialization ([feast-dev#3754](feast-dev#3754)) ([2192e65](feast-dev@2192e65))
* Apply cache to load proto registry for performance ([feast-dev#3702](feast-dev#3702)) ([709c709](feast-dev@709c709))
* Make bytewax job write as mini-batches ([feast-dev#3777](feast-dev#3777)) ([9b0e5ce](feast-dev@9b0e5ce))
* Optimize bytewax pod resource with zero-copy ([9cf9d96](feast-dev@9cf9d96))
* Support GCS filesystem for bytewax engine ([feast-dev#3774](feast-dev#3774)) ([fb6b807](feast-dev@fb6b807))

Signed-off-by: tokoko <[email protected]>

zseta pushed a commit to zseta/feast that referenced this pull request

Feb 7, 2024


          fix: Bytewax engine create configmap from object (feast-dev#3821)

7611aa8

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Attila Toth <[email protected]>

zseta pushed a commit to zseta/feast that referenced this pull request

Feb 7, 2024


          chore(release): release 0.35.0

ef5ff9e

# [0.35.0](feast-dev/feast@v0.34.0...v0.35.0) (2024-01-13)

### Bug Fixes

* Add async refresh to prevent synchronous refresh in main thread ([feast-dev#3812](feast-dev#3812)) ([9583ed6](feast-dev@9583ed6))
* Adopt connection pooling for HBase ([feast-dev#3793](feast-dev#3793)) ([b3852bf](feast-dev@b3852bf))
* Bytewax engine create configmap from object ([feast-dev#3821](feast-dev#3821)) ([25e9775](feast-dev@25e9775))
* Fix warnings from deprecated paths and update default log level ([feast-dev#3757](feast-dev#3757)) ([68a8737](feast-dev@68a8737))
* improve parsing bytewax job status ([5983f40](feast-dev@5983f40))
* make bytewax settings unexposed ([ae1bb8b](feast-dev@ae1bb8b))
* Make generated temp table name escaped ([feast-dev#3797](feast-dev#3797)) ([175d796](feast-dev@175d796))
* Pin numpy version to avoid spammy deprecation messages ([774ed33](feast-dev@774ed33))
* Redundant feature materialization and premature incremental materialization timestamp updates ([feast-dev#3789](feast-dev#3789)) ([417b16b](feast-dev@417b16b)), closes [feast-dev#6](feast-dev#6) [feast-dev#7](feast-dev#7)
* Resolve hbase hotspot issue when materializing ([feast-dev#3790](feast-dev#3790)) ([7376db8](feast-dev@7376db8))
* Set keepalives_idle None by default ([feast-dev#3756](feast-dev#3756)) ([8717e9b](feast-dev@8717e9b))
* Set upper bound for bigquery client due to its breaking changes ([2151c39](feast-dev@2151c39))
* UI project cannot handle fallback routes ([feast-dev#3766](feast-dev#3766)) ([96ece0f](feast-dev@96ece0f))
* update dependencies versions due to conflicts ([5dc0b24](feast-dev@5dc0b24))
* Update jackson and remove unnecessary logging ([feast-dev#3809](feast-dev#3809)) ([018d0ea](feast-dev@018d0ea))
* upgrade the pyarrow to latest v14.0.1 for CVE-2023-47248. ([052182b](feast-dev@052182b))

### Features

* Add get online feature rpc to gprc server ([feast-dev#3815](feast-dev#3815)) ([01db8cc](feast-dev@01db8cc))
* Add materialize and materialize-incremental rest endpoints ([feast-dev#3761](feast-dev#3761)) ([fa600fe](feast-dev@fa600fe)), closes [feast-dev#3760](feast-dev#3760)
* add redis sentinel support ([3387a15](feast-dev@3387a15))
* add redis sentinel support ([4337c89](feast-dev@4337c89))
* add redis sentinel support format lint ([aad8718](feast-dev@aad8718))
* Add support for `table_create_disposition` in bigquery job for offline store ([feast-dev#3762](feast-dev#3762)) ([6a728fe](feast-dev@6a728fe))
* Add support for in_cluster config and additional labels for bytewax materialization ([feast-dev#3754](feast-dev#3754)) ([2192e65](feast-dev@2192e65))
* Apply cache to load proto registry for performance ([feast-dev#3702](feast-dev#3702)) ([709c709](feast-dev@709c709))
* Make bytewax job write as mini-batches ([feast-dev#3777](feast-dev#3777)) ([9b0e5ce](feast-dev@9b0e5ce))
* Optimize bytewax pod resource with zero-copy ([9cf9d96](feast-dev@9cf9d96))
* Support GCS filesystem for bytewax engine ([feast-dev#3774](feast-dev#3774)) ([fb6b807](feast-dev@fb6b807))

Signed-off-by: Attila Toth <[email protected]>

tqtensor pushed a commit to tqtensor/feast that referenced this pull request

Mar 11, 2024


          fix: Bytewax engine create configmap from object (feast-dev#3821)

d2a6c27

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request

Jun 10, 2024


          fix: Bytewax engine create configmap from object (feast-dev#3821)

c8f7887

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

EXPEbdodla pushed a commit to ExpediaGroup/feast that referenced this pull request

Jun 11, 2024


          fix: Bytewax engine create configmap from object (feast-dev#3821)

1c571a4

fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>

EXPEbdodla added a commit to ExpediaGroup/feast that referenced this pull request

Jun 11, 2024


          Merge pull request #109 from ExpediaGroup/merge_from_feast_test

8825afc

fix: Bytewax engine create configmap from object (feast-dev#3821)

acevedosharp added a commit to ExpediaGroup/feast that referenced this pull request

Jul 10, 2024


          Add DD Tracing to gRPC Go Feature Server (#116)

850e97d

* fix: Bytewax engine create configmap from object (feast-dev#3821)

* Add tracing to Go gRPC server

---------

Signed-off-by: Hai Nguyen <[email protected]>
Co-authored-by: Harry <[email protected]>
Co-authored-by: jacevedo34 <[email protected]>
Co-authored-by: Jose Acevedo <[email protected]>

Reviewers

whoahbot

whoahbot approved these changes

achals

achals approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

sudohainguyen

Labels

approved area/infra lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.