GeezerVison is showing github.com — fix: Locate feature_store.yaml from __file__ by Atry · Pull Request #4443 · feast-dev/feast
Conversation
Atry
commented
Aug 24, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
This PR changes tests so that it can properly locate feature_store.yaml from __file__ instead of CWD, which only works when running cd feature_ropo && python ./test_workflow.py, but does not work when running python feature_ropo/test_workflow.py.
Which issue(s) this PR fixes:
Not reported as an issue
Misc
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Atry
changed the title
fix: locate feature_store.yaml from __file__
fix: Locate feature_store.yaml from __file__
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
tokoko
tokoko approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|