GeezerVison is showing github.com — fix: Update react-router-dom to 6.3.0 and restrict its version in Feast UI by peruukki · Pull Request #4556 · feast-dev/feast
Conversation
peruukki
commented
Sep 22, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
As noted in #3794, Feast UI is not compatible with the latest react-router-dom versions, more precisely from 6.4.0 onwards. Limit react-router-dom version to a compatible range to avoid the runtime errors mentioned in the issue when installing app dependencies without specifying exact versions.
After setting the restricted versions in package.json, running yarn install updated react-router-dom to the latest compatible version 6.3.0. It should be a minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630), and I didn't notice anything not working in the UI after it.
Which issue(s) this PR fixes:
#3794 has already been closed since there was another way to resolve it, but otherwise this should have fixed it too.
Misc
I've noticed that regardless of which versions you define in peerDependencies, at least Yarn 1 (Classic) installs the latest versions of those packages in the app project with yarn add. But the peer dependency versions still have an impact:
- If I keep the react-router-dom version as
6 in peerDependencies, Yarn installs the latest version in the root node_modules and uses only that, and I get the error in EuiCustomLink causing error on feast-ui NPM package #3794
- If I restrict react-router-dom version to
<6.4.0 in peerDependencies, Yarn installs the latest version in the root node_modules and version 6.3.0 in @feast-dev/feast-ui/node_modules, so Feast UI uses 6.3.0 and the rest of the app the latest version, and I don't get errors (using different versions of react-router-dom might introduce some other problems, but limiting the version in peerDependencies is the best we can do to influence the app dependency version)
There are differences in how different package managers (and their different versions) handle peer dependency versions, and you can sometime influence that with command line arguments. But the main point here was to verify that we indeed should update the version in peerDependencies too. 😄
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…st UI
As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom
versions, more precisely from 6.4.0 onwards. Limit react-router-dom version
to a compatible range to avoid the runtime errors mentioned in the issue
when installing peer dependencies without specifying exact versions.
After setting the restricted versions, `yarn install` updated
`react-router-dom` to the latest compatible version 6.3.0. It should be a
minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630),
and I didn't notice anything not working in the UI after it.
Signed-off-by: Harri Lehtola <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
Sep 23, 2024
…st UI (feast-dev#4556)
As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom
versions, more precisely from 6.4.0 onwards. Limit react-router-dom version
to a compatible range to avoid the runtime errors mentioned in the issue
when installing peer dependencies without specifying exact versions.
After setting the restricted versions, `yarn install` updated
`react-router-dom` to the latest compatible version 6.3.0. It should be a
minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630),
and I didn't notice anything not working in the UI after it.
Signed-off-by: Harri Lehtola <[email protected]>
Reviewers
shuchu
shuchu approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|