GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — feat: Updated feast Go operator db stores by tmihalac · Pull Request #4802 · feast-dev/feast Conversation
Contributor
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSigned-off-by: Theodor Mihalache <[email protected]> - Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]>
dmartinol
reviewed
Uh oh!
There was an error while loading. Please reload this page.
dmartinol
enabled auto-merge (squash)
dmartinol
approved these changes
…the CRD Signed-off-by: Theodor Mihalache <[email protected]>
auto-merge was automatically disabled
Head branch was pushed to by a user without write access Signed-off-by: Theodor Mihalache <[email protected]> - Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> …the CRD Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> …PR-4771 # Conflicts: # infra/feast-operator/internal/controller/featurestore_controller_db_store_test.go * chore: Updated testcontainers to support MilvusContainer Signed-off-by: Francisco Javier Arceo <[email protected]> * downgraded Signed-off-by: Francisco Javier Arceo <[email protected]> * updating libraries to downgrade singlestore to 1.7.2 Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing lint issues post package upgrades Signed-off-by: Francisco Javier Arceo <[email protected]> * downgraded pyarrow Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * Add support for db stores in feast go operator Signed-off-by: Theodor Mihalache <[email protected]> * Added CR example for store persistence Signed-off-by: Theodor Mihalache <[email protected]> * Fixed incorrect yaml tag in RegistryConfig struct Signed-off-by: Theodor Mihalache <[email protected]> * Removed leftovers comments from hasAttrib function Signed-off-by: Theodor Mihalache <[email protected]> * Added another check that object parameter type is the same as value type in hasAttrib Signed-off-by: Theodor Mihalache <[email protected]> * Reverted latest commit Signed-off-by: Theodor Mihalache <[email protected]> --------- Signed-off-by: Theodor Mihalache <[email protected]> …ing (feast-dev#4794) Signed-off-by: Francisco Javier Arceo <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> fix dbstore types Signed-off-by: Tommy Hughes <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * fix: sqlite adapter deprecation warning Signed-off-by: Matt Green <[email protected]> * fix: remove duplicate folder definition in ruff config Signed-off-by: Matt Green <[email protected]> * update minimum ruff version and format files Signed-off-by: Matt Green <[email protected]> --------- Signed-off-by: Matt Green <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> ) Lock the TypeScript minor version by using `~` instead of `^` in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment). After upgrading, the TypeScript compiler complained that the `long` package has no default export. Related fixes: - Add the latest `long` version as a direct dependency since our code uses it directly; no compilation errors with the latest version - The `long` package exports a `Long` class, so use a capital first letter in the import name to match that Signed-off-by: Harri Lehtola <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * Initial commit Signed-off-by: Daniele Martinoli <[email protected]> * refactoring types with FeastHandler Signed-off-by: Daniele Martinoli <[email protected]> * no private image Signed-off-by: Daniele Martinoli <[email protected]> * removed log-level Signed-off-by: Daniele Martinoli <[email protected]> * no empty list for default Role Signed-off-by: Daniele Martinoli <[email protected]> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <[email protected]> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <[email protected]> * fixing generated code Signed-off-by: Daniele Martinoli <[email protected]> * renamed auth condition and types Signed-off-by: Daniele Martinoli <[email protected]> * post rebase fixes Signed-off-by: Daniele Martinoli <[email protected]> * more renamings Signed-off-by: Daniele Martinoli <[email protected]> --------- Signed-off-by: Daniele Martinoli <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * add tls support to the operator Signed-off-by: Tommy Hughes <[email protected]> * operator tls review fix: if statement Signed-off-by: Tommy Hughes <[email protected]> * rebase fixes Signed-off-by: Tommy Hughes <[email protected]> * authz rbac fixes Signed-off-by: Tommy Hughes <[email protected]> --------- Signed-off-by: Tommy Hughes <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * clean up dependency installation makefile tasks Signed-off-by: Matt Green <[email protected]> * rewrite lock-python-dependencies-all to be more DRY Signed-off-by: Matt Green <[email protected]> * update environment setup docs Signed-off-by: Matt Green <[email protected]> * update smoke test Signed-off-by: Matt Green <[email protected]> * small change Signed-off-by: Matt Green <[email protected]> --------- Signed-off-by: Matt Green <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> - Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> …the CRD Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]>
tchughesiv
requested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tmihalac seems you might need to rebase on an updated master? something got messed up with your last push
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
tchughesiv
requested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rebase needs to be fixed
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
tchughesiv
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lgtm
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
franciscojavierarceo
approved these changes
* Initial commit Signed-off-by: Daniele Martinoli <[email protected]> * no private image Signed-off-by: Daniele Martinoli <[email protected]> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <[email protected]> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <[email protected]> * fixing generated code Signed-off-by: Daniele Martinoli <[email protected]> * renamed auth condition and types Signed-off-by: Daniele Martinoli <[email protected]> * more renamings Signed-off-by: Daniele Martinoli <[email protected]> * initial commit Signed-off-by: Daniele Martinoli <[email protected]> * oidc IT Signed-off-by: Daniele Martinoli <[email protected]> * with sample Signed-off-by: Daniele Martinoli <[email protected]> * no private image Signed-off-by: Daniele Martinoli <[email protected]> --------- Signed-off-by: Daniele Martinoli <[email protected]> * fix envVar positioning Signed-off-by: Tommy Hughes <[email protected]> * tls.SecretRef.Name Signed-off-by: Tommy Hughes <[email protected]> --------- Signed-off-by: Tommy Hughes <[email protected]> * Add support for db stores in feast go operator Signed-off-by: Theodor Mihalache <[email protected]> * Added CR example for store persistence Signed-off-by: Theodor Mihalache <[email protected]> * Fixed incorrect yaml tag in RegistryConfig struct Signed-off-by: Theodor Mihalache <[email protected]> * Removed leftovers comments from hasAttrib function Signed-off-by: Theodor Mihalache <[email protected]> * Added another check that object parameter type is the same as value type in hasAttrib Signed-off-by: Theodor Mihalache <[email protected]> * Reverted latest commit Signed-off-by: Theodor Mihalache <[email protected]> --------- Signed-off-by: Theodor Mihalache <[email protected]> * Initial commit Signed-off-by: Daniele Martinoli <[email protected]> * refactoring types with FeastHandler Signed-off-by: Daniele Martinoli <[email protected]> * no private image Signed-off-by: Daniele Martinoli <[email protected]> * removed log-level Signed-off-by: Daniele Martinoli <[email protected]> * no empty list for default Role Signed-off-by: Daniele Martinoli <[email protected]> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <[email protected]> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <[email protected]> * fixing generated code Signed-off-by: Daniele Martinoli <[email protected]> * renamed auth condition and types Signed-off-by: Daniele Martinoli <[email protected]> * post rebase fixes Signed-off-by: Daniele Martinoli <[email protected]> * more renamings Signed-off-by: Daniele Martinoli <[email protected]> --------- Signed-off-by: Daniele Martinoli <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> * add tls support to the operator Signed-off-by: Tommy Hughes <[email protected]> * operator tls review fix: if statement Signed-off-by: Tommy Hughes <[email protected]> * rebase fixes Signed-off-by: Tommy Hughes <[email protected]> * authz rbac fixes Signed-off-by: Tommy Hughes <[email protected]> --------- Signed-off-by: Tommy Hughes <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> - Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> …the CRD Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]> …PR-4771 # Conflicts: # infra/feast-operator/test/api/featurestore_types_test.go Signed-off-by: Theodor Mihalache <[email protected]>
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Leftovers of PR #4771 Add to Go operator support for db storesUh oh!
There was an error while loading. Please reload this page. 6 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |