GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Added feast Go operator db stores support by tmihalac · Pull Request #4771 · feast-dev/feast

Conversation

@tmihalac

@tmihalac tmihalac commented Nov 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR adds db stores persistence configuration options to the FeatureStore CRD.
DB store para

  • Support is provided to the Online service, Offline service and Registry service.
  • Follows definitions in RFC #42
  • Configuration examples are provided in config/samples
kind: FeatureStore
metadata:
  name: sample-s3-registry
spec:
  feastProject: my_project
  services:
    onlineStore:
      persistence:
        store:
          type: postgres
          secretRef: 
            name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified
          secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
    offlineStore:
      persistence:
        store:
          type: postgres
          secretRef: 
            name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified
          secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
    registry:
      local:
        persistence:
          store:
            type: sql
            secretRef: 
              name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g sql) key or under the secretKeyName if specified
            secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
kind: Secret
apiVersion: v1
metadata:
  name: my-secret
  namespace: test
  uid: b410b5e5-857b-4611-acc3-1302b8c6c68c
  resourceVersion: '62030'
  creationTimestamp: '2024-11-19T20:25:15Z'
  managedFields:
    - manager: kubectl-create
      operation: Update
      apiVersion: v1
      time: '2024-11-19T20:25:15Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:data':
          .: {}
          'f:mykey': {}
        'f:type': {}
data:
  postgres: |
    host: DB_HOST
    port: DB_PORT
    database: DB_NAME
    db_schema: DB_SCHEMA
    user: DB_USERNAME
    password: DB_PASSWORD
    sslmode: verify-ca
    sslkey_path: /path/to/client-key.pem
    sslcert_path: /path/to/client-cert.pem
    sslrootcert_path: /path/to/server-ca.pem
  sql: |
    path: postgresql://postgres:[email protected]:55001/feast
    cache_ttl_seconds: 60
    sqlalchemy_config_kwargs:
        echo: false
        pool_pre_ping: true
type: Opaque

Which issue(s) this PR fixes:

Relates to #4783

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tmihalac
tmihalac requested a review from a team as a code owner November 19, 2024 21:12
tchughesiv
tchughesiv requested changes Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/repo_config.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv requested changes Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/repo_config.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/internal/controller/services/repo_config.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/internal/controller/services/repo_config.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv requested changes Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/util.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@dmartinol

dmartinol commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

@tmihalac the issue you are referring to is already closed. @tchughesiv should we create a new one or reopen it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@dmartinol

dmartinol commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

In the description, the postgres type is not supported by registry, pls change it to sql (and also add a sql key to the secret name)

    registry:
      local:
        persistence:
          store:
          type: postgres
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/config/samples/v1alpha1_featurestore_db_persistence.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/featurestore_controller_db_store_test.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/services_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/test/api/featurestore_types_test.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv

tchughesiv commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

@tmihalac @dmartinol we should be opening new issues for operator PRs

dmartinol reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv reviewed Nov 20, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/repo_config.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv requested changes Nov 20, 2024
View reviewed changes

@tchughesiv tchughesiv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmihalac please rebase on master branch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tmihalac
tmihalac force-pushed the go-operator-db-stores branch 2 times, most recently from 59a08d7 to 8a4fd21 Compare November 21, 2024 18:27
@tmihalac
Add support for db stores in feast go operator
ee0a943
Signed-off-by: Theodor Mihalache <[email protected]>
@tmihalac
tmihalac force-pushed the go-operator-db-stores branch from 8a4fd21 to ee0a943 Compare November 21, 2024 18:27
@lokeshrangineni lokeshrangineni added the ok-to-test label Nov 21, 2024
@tchughesiv

tchughesiv commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

@tmihalac please open a new gh issue for this PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv requested changes Nov 21, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/services_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/internal/controller/services/util.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/internal/controller/services/util.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv

tchughesiv commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

@tmihalac should your descrip example be fixed? i'd imagine it will look like this? with the secretKeyName pulled back to under store?

kind: FeatureStore
metadata:
  name: sample-s3-registry
spec:
  feastProject: my_project
  services:
    onlineStore:
      persistence:
        store:
          type: postgres
          secretRef: 
            name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified
          secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tmihalac

tmihalac commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

@tmihalac should your descrip example be fixed? i'd imagine it will look like this? with the secretKeyName pulled back to under store?

kind: FeatureStore
metadata:
  name: sample-s3-registry
spec:
  feastProject: my_project
  services:
    onlineStore:
      persistence:
        store:
          type: postgres
          secretRef: 
            name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified
          secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)

You are right fixing it now

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tmihalac

tmihalac commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

Done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv requested changes Nov 21, 2024
View reviewed changes
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv reviewed Nov 21, 2024
View reviewed changes
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tmihalac added 2 commits November 21, 2024 16:11
@tmihalac
Added CR example for store persistence
42d0801
Signed-off-by: Theodor Mihalache <[email protected]>
@tmihalac
Fixed incorrect yaml tag in RegistryConfig struct
d6b6f17
Signed-off-by: Theodor Mihalache <[email protected]>
@tmihalac
Removed leftovers comments from hasAttrib function
aea02e6
Signed-off-by: Theodor Mihalache <[email protected]>
@shuchu

shuchu commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Hi team, I see a lot of contributions here! but please beware that there is a PR which will have lots of Golang code change: #4665

tchughesiv reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv
tchughesiv reviewed Nov 25, 2024
View reviewed changes
Comment thread infra/feast-operator/internal/controller/services/repo_config_test.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tmihalac added 2 commits November 25, 2024 10:49
@tmihalac
Added another check that object parameter type is the same as value t…
1891c08
…ype in hasAttrib

Signed-off-by: Theodor Mihalache <[email protected]>
@tmihalac
Reverted latest commit
0b1a570
Signed-off-by: Theodor Mihalache <[email protected]>
@dmartinol

dmartinol commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Hi team, I see a lot of contributions here! but please beware that there is a PR which will have lots of Golang code change: #4665

@shuchu I hope the operator lives in a separate folder of the repo, so we're not expecting any "interference" from the other PR. These components seem to be independent of each other, but please advise if you think there is something we should look at instead. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dmartinol

dmartinol commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

In the description, the postgres type is not supported by registry, pls change it to sql (and also add a sql key to the secret name)
@tmihalac be aware that the example in the description refers to a secretKeyName: my-postgres that does not exist in the given Secret. Also, for the registry you should use the default key name, e.g. sql instead of either postgres or my-postgres.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dmartinol dmartinol mentioned this pull request Nov 26, 2024
Leftovers of PR #4771 #4793
Closed
@dmartinol

dmartinol commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Leftovers are tracked in #4793

tchughesiv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol approved these changes Nov 26, 2024
View reviewed changes
@dmartinol
dmartinol merged commit 3302363 into feast-dev:master Nov 26, 2024
@shuchu

shuchu commented Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Hi team, I see a lot of contributions here! but please beware that there is a PR which will have lots of Golang code change: #4665

@shuchu I hope the operator lives in a separate folder of the repo, so we're not expecting any "interference" from the other PR. These components seem to be independent of each other, but please advise if you think there is something we should look at instead. Thanks!

sorry, my bad. I didn't pay attention to the folder structure. No advisee from my side. Actually I'm learning form the code write by you all as I'm starting to write Golang codes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tmihalac tmihalac mentioned this pull request Dec 2, 2024
feat: Updated feast Go operator db stores #4802
Closed
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request Dec 2, 2024
@tmihalac @lokeshrangineni
feat: Added feast Go operator db stores support (feast-dev#4771)
7441ab1
* Add support for db stores in feast go operator

Signed-off-by: Theodor Mihalache <[email protected]>

* Added CR example for store persistence

Signed-off-by: Theodor Mihalache <[email protected]>

* Fixed incorrect yaml tag in RegistryConfig struct

Signed-off-by: Theodor Mihalache <[email protected]>

* Removed leftovers comments from hasAttrib function

Signed-off-by: Theodor Mihalache <[email protected]>

* Added another check that object parameter type is the same as value type in hasAttrib

Signed-off-by: Theodor Mihalache <[email protected]>

* Reverted latest commit

Signed-off-by: Theodor Mihalache <[email protected]>

---------

Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac added a commit to tmihalac/feast that referenced this pull request Dec 3, 2024
@tmihalac
feat: Added feast Go operator db stores support (feast-dev#4771)
b9ffc1f
* Add support for db stores in feast go operator

Signed-off-by: Theodor Mihalache <[email protected]>

* Added CR example for store persistence

Signed-off-by: Theodor Mihalache <[email protected]>

* Fixed incorrect yaml tag in RegistryConfig struct

Signed-off-by: Theodor Mihalache <[email protected]>

* Removed leftovers comments from hasAttrib function

Signed-off-by: Theodor Mihalache <[email protected]>

* Added another check that object parameter type is the same as value type in hasAttrib

Signed-off-by: Theodor Mihalache <[email protected]>

* Reverted latest commit

Signed-off-by: Theodor Mihalache <[email protected]>

---------

Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac added a commit to tmihalac/feast that referenced this pull request Dec 4, 2024
@tmihalac
feat: Added feast Go operator db stores support (feast-dev#4771)
6c1fa7b
* Add support for db stores in feast go operator

Signed-off-by: Theodor Mihalache <[email protected]>

* Added CR example for store persistence

Signed-off-by: Theodor Mihalache <[email protected]>

* Fixed incorrect yaml tag in RegistryConfig struct

Signed-off-by: Theodor Mihalache <[email protected]>

* Removed leftovers comments from hasAttrib function

Signed-off-by: Theodor Mihalache <[email protected]>

* Added another check that object parameter type is the same as value type in hasAttrib

Signed-off-by: Theodor Mihalache <[email protected]>

* Reverted latest commit

Signed-off-by: Theodor Mihalache <[email protected]>

---------

Signed-off-by: Theodor Mihalache <[email protected]>
This was referenced Dec 4, 2024
feat: Updated feast Go operator db stores #4809
Merged
feat: Updated sample secret following review #4811
Merged
franciscojavierarceo pushed a commit that referenced this pull request Dec 5, 2024
@feast-ci-bot
chore(release): release 0.42.0
aac334a
# [0.42.0](v0.41.0...v0.42.0) (2024-12-05)

### Bug Fixes

* Add adapters for sqlite datetime conversion ([#4797](#4797)) ([e198b17](e198b17))
* Added grpcio extras to default feature-server image ([#4737](#4737)) ([e9cd373](e9cd373))
* Changing node version in release ([7089918](7089918))
* Feast create empty online table when FeatureView attribute online=False ([#4666](#4666)) ([237c453](237c453))
* Fix db store types in Operator CRD ([#4798](#4798)) ([f09339e](f09339e))
* Fix the config issue for postgres ([#4776](#4776)) ([a36f7e5](a36f7e5))
* Fixed example materialize-incremental and improved explanation ([#4734](#4734)) ([ca8a7ab](ca8a7ab))
* Fixed SparkSource docstrings so it wouldn't used inhereted class docstrings ([#4722](#4722)) ([32e6aa1](32e6aa1))
* Fixing PGVector integration tests ([#4778](#4778)) ([88a0320](88a0320))
* Incorrect type passed to assert_permissions in materialize endpoints ([#4727](#4727)) ([b72c2da](b72c2da))
* Issue of DataSource subclasses using parent abstract class docstrings ([#4730](#4730)) ([b24acd5](b24acd5))
* Operator envVar positioning & tls.SecretRef.Name ([#4806](#4806)) ([1115d96](1115d96))
* Populates project created_time correctly according to created ti… ([#4686](#4686)) ([a61b93c](a61b93c))
* Reduce feast-server container image size & fix dev image build ([#4781](#4781)) ([ccc9aea](ccc9aea))
* Removed version func from feature_store.py ([#4748](#4748)) ([f902bb9](f902bb9))
* Support registry instantiation for read-only users ([#4719](#4719)) ([ca3d3c8](ca3d3c8))
* Syntax Error in BigQuery While Retrieving Columns that Start wit… ([#4713](#4713)) ([60fbc62](60fbc62))
* Update release version in a pertinent Operator file ([#4708](#4708)) ([764a8a6](764a8a6))

### Features

* Add api contract to fastapi docs ([#4721](#4721)) ([1a165c7](1a165c7))
* Add Couchbase as an online store ([#4637](#4637)) ([824859b](824859b))
* Add Operator support for spec.feastProject & status.applied fields ([#4656](#4656)) ([430ac53](430ac53))
* Add services functionality to Operator ([#4723](#4723)) ([d1d80c0](d1d80c0))
* Add TLS support to the Operator ([#4796](#4796)) ([a617a6c](a617a6c))
* Added feast Go operator db stores support ([#4771](#4771)) ([3302363](3302363))
* Added support for setting env vars in feast services in feast controller  ([#4739](#4739)) ([84b24b5](84b24b5))
* Adding docs outlining native Python transformations on singletons ([#4741](#4741)) ([0150278](0150278))
* Adding first feast operator e2e test. ([#4791](#4791)) ([8339f8d](8339f8d))
* Adding github action to run the operator end-to-end tests. ([#4762](#4762)) ([d8ccb00](d8ccb00))
* Adding ssl support for registry server. ([#4718](#4718)) ([ccf7a55](ccf7a55))
* Adding SSL support for the React UI server and feast UI command. ([#4736](#4736)) ([4a89252](4a89252))
* Adding support for native Python transformations on a single dictionary  ([#4724](#4724)) ([9bbc1c6](9bbc1c6))
* Adding TLS support for offline server. ([#4744](#4744)) ([5d8d03f](5d8d03f))
* Building the feast image ([#4775](#4775)) ([6635dde](6635dde))
* File persistence definition and implementation ([#4742](#4742)) ([3bad4a1](3bad4a1))
* Object store persistence in operator ([#4758](#4758)) ([0ae86da](0ae86da))
* OIDC authorization in Feast Operator ([#4801](#4801)) ([eb111d6](eb111d6))
* Operator will create k8s serviceaccount for each feast service ([#4767](#4767)) ([cde5760](cde5760))
* Printing more verbose logs when we start the offline server  ([#4660](#4660)) ([9d8d3d8](9d8d3d8))
* PVC configuration and impl ([#4750](#4750)) ([785a190](785a190))
* Qdrant vectorstore support ([#4689](#4689)) ([86573d2](86573d2))
* RBAC Authorization in Feast Operator ([#4786](#4786)) ([0ef5acc](0ef5acc))
* Support for nested timestamp fields in Spark Offline store ([#4740](#4740)) ([d4d94f8](d4d94f8))
* Update the go feature server from Expedia code repo. ([#4665](#4665)) ([6406625](6406625))
* Updated feast Go operator db stores ([#4809](#4809)) ([2c5a6b5](2c5a6b5))
* Updated sample secret following review ([#4811](#4811)) ([dc9f825](dc9f825))
dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request Jan 15, 2025
@tmihalac @dharmisha
feat: Added feast Go operator db stores support (feast-dev#4771)
37b5340
* Add support for db stores in feast go operator

Signed-off-by: Theodor Mihalache <[email protected]>

* Added CR example for store persistence

Signed-off-by: Theodor Mihalache <[email protected]>

* Fixed incorrect yaml tag in RegistryConfig struct

Signed-off-by: Theodor Mihalache <[email protected]>

* Removed leftovers comments from hasAttrib function

Signed-off-by: Theodor Mihalache <[email protected]>

* Added another check that object parameter type is the same as value type in hasAttrib

Signed-off-by: Theodor Mihalache <[email protected]>

* Reverted latest commit

Signed-off-by: Theodor Mihalache <[email protected]>

---------

Signed-off-by: Theodor Mihalache <[email protected]>
dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request Jan 15, 2025
@feast-ci-bot @dharmisha
chore(release): release 0.42.0
6c64b8f
* Add adapters for sqlite datetime conversion ([feast-dev#4797](feast-dev#4797)) ([e198b17](feast-dev@e198b17))
* Added grpcio extras to default feature-server image ([feast-dev#4737](feast-dev#4737)) ([e9cd373](feast-dev@e9cd373))
* Changing node version in release ([7089918](feast-dev@7089918))
* Feast create empty online table when FeatureView attribute online=False ([feast-dev#4666](feast-dev#4666)) ([237c453](feast-dev@237c453))
* Fix db store types in Operator CRD ([feast-dev#4798](feast-dev#4798)) ([f09339e](feast-dev@f09339e))
* Fix the config issue for postgres ([feast-dev#4776](feast-dev#4776)) ([a36f7e5](feast-dev@a36f7e5))
* Fixed example materialize-incremental and improved explanation ([feast-dev#4734](feast-dev#4734)) ([ca8a7ab](feast-dev@ca8a7ab))
* Fixed SparkSource docstrings so it wouldn't used inhereted class docstrings ([feast-dev#4722](feast-dev#4722)) ([32e6aa1](feast-dev@32e6aa1))
* Fixing PGVector integration tests ([feast-dev#4778](feast-dev#4778)) ([88a0320](feast-dev@88a0320))
* Incorrect type passed to assert_permissions in materialize endpoints ([feast-dev#4727](feast-dev#4727)) ([b72c2da](feast-dev@b72c2da))
* Issue of DataSource subclasses using parent abstract class docstrings ([feast-dev#4730](feast-dev#4730)) ([b24acd5](feast-dev@b24acd5))
* Operator envVar positioning & tls.SecretRef.Name ([feast-dev#4806](feast-dev#4806)) ([1115d96](feast-dev@1115d96))
* Populates project created_time correctly according to created ti… ([feast-dev#4686](feast-dev#4686)) ([a61b93c](feast-dev@a61b93c))
* Reduce feast-server container image size & fix dev image build ([feast-dev#4781](feast-dev#4781)) ([ccc9aea](feast-dev@ccc9aea))
* Removed version func from feature_store.py ([feast-dev#4748](feast-dev#4748)) ([f902bb9](feast-dev@f902bb9))
* Support registry instantiation for read-only users ([feast-dev#4719](feast-dev#4719)) ([ca3d3c8](feast-dev@ca3d3c8))
* Syntax Error in BigQuery While Retrieving Columns that Start wit… ([feast-dev#4713](feast-dev#4713)) ([60fbc62](feast-dev@60fbc62))
* Update release version in a pertinent Operator file ([feast-dev#4708](feast-dev#4708)) ([764a8a6](feast-dev@764a8a6))

* Add api contract to fastapi docs ([feast-dev#4721](feast-dev#4721)) ([1a165c7](feast-dev@1a165c7))
* Add Couchbase as an online store ([feast-dev#4637](feast-dev#4637)) ([824859b](feast-dev@824859b))
* Add Operator support for spec.feastProject & status.applied fields ([feast-dev#4656](feast-dev#4656)) ([430ac53](feast-dev@430ac53))
* Add services functionality to Operator ([feast-dev#4723](feast-dev#4723)) ([d1d80c0](feast-dev@d1d80c0))
* Add TLS support to the Operator ([feast-dev#4796](feast-dev#4796)) ([a617a6c](feast-dev@a617a6c))
* Added feast Go operator db stores support ([feast-dev#4771](feast-dev#4771)) ([3302363](feast-dev@3302363))
* Added support for setting env vars in feast services in feast controller  ([feast-dev#4739](feast-dev#4739)) ([84b24b5](feast-dev@84b24b5))
* Adding docs outlining native Python transformations on singletons ([feast-dev#4741](feast-dev#4741)) ([0150278](feast-dev@0150278))
* Adding first feast operator e2e test. ([feast-dev#4791](feast-dev#4791)) ([8339f8d](feast-dev@8339f8d))
* Adding github action to run the operator end-to-end tests. ([feast-dev#4762](feast-dev#4762)) ([d8ccb00](feast-dev@d8ccb00))
* Adding ssl support for registry server. ([feast-dev#4718](feast-dev#4718)) ([ccf7a55](feast-dev@ccf7a55))
* Adding SSL support for the React UI server and feast UI command. ([feast-dev#4736](feast-dev#4736)) ([4a89252](feast-dev@4a89252))
* Adding support for native Python transformations on a single dictionary  ([feast-dev#4724](feast-dev#4724)) ([9bbc1c6](feast-dev@9bbc1c6))
* Adding TLS support for offline server. ([feast-dev#4744](feast-dev#4744)) ([5d8d03f](feast-dev@5d8d03f))
* Building the feast image ([feast-dev#4775](feast-dev#4775)) ([6635dde](feast-dev@6635dde))
* File persistence definition and implementation ([feast-dev#4742](feast-dev#4742)) ([3bad4a1](feast-dev@3bad4a1))
* Object store persistence in operator ([feast-dev#4758](feast-dev#4758)) ([0ae86da](feast-dev@0ae86da))
* OIDC authorization in Feast Operator ([feast-dev#4801](feast-dev#4801)) ([eb111d6](feast-dev@eb111d6))
* Operator will create k8s serviceaccount for each feast service ([feast-dev#4767](feast-dev#4767)) ([cde5760](feast-dev@cde5760))
* Printing more verbose logs when we start the offline server  ([feast-dev#4660](feast-dev#4660)) ([9d8d3d8](feast-dev@9d8d3d8))
* PVC configuration and impl ([feast-dev#4750](feast-dev#4750)) ([785a190](feast-dev@785a190))
* Qdrant vectorstore support ([feast-dev#4689](feast-dev#4689)) ([86573d2](feast-dev@86573d2))
* RBAC Authorization in Feast Operator ([feast-dev#4786](feast-dev#4786)) ([0ef5acc](feast-dev@0ef5acc))
* Support for nested timestamp fields in Spark Offline store ([feast-dev#4740](feast-dev#4740)) ([d4d94f8](feast-dev@d4d94f8))
* Update the go feature server from Expedia code repo. ([feast-dev#4665](feast-dev#4665)) ([6406625](feast-dev@6406625))
* Updated feast Go operator db stores ([feast-dev#4809](feast-dev#4809)) ([2c5a6b5](feast-dev@2c5a6b5))
* Updated sample secret following review ([feast-dev#4811](feast-dev#4811)) ([dc9f825](feast-dev@dc9f825))
@coderabbitai coderabbitai Bot mentioned this pull request Apr 21, 2026
test: Update Feast tests to avoid feast apply error opendatahub-io/odh-dashboard#7324
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchughesiv tchughesiv tchughesiv requested changes
@dmartinol dmartinol dmartinol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tmihalac @dmartinol @tchughesiv @shuchu @lokeshrangineni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.