GeezerVison is showing github.com (truncated) — feat: Loading the CA trusted store certificate into Feast to verify the public certificate. by lokeshrangineni · Pull Request #4852 · feast-dev/feast
Conversation
What this PR does / why we need it:
This PR should be able to load the CA trust store to validate the TLS public certificates.
Which issue(s) this PR fixes:
4857
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lokeshrangineni
changed the title
Initial Draft version to load the CA trusted store code.
Feat: Initial Draft version to load the CA trusted store.
Dec 14, 2024
lokeshrangineni
changed the title
Feat: Initial Draft version to load the CA trusted store.
feat: Initial Draft version to load the CA trusted store.
Dec 14, 2024
…ide rather than on the server side. And also fixing the integration tests.
Signed-off-by: lrangine <[email protected]>
Changed the offline store TLS setting decision from cert to scheme.
Signed-off-by: lrangine <[email protected]>
lokeshrangineni
changed the title
feat: Initial Draft version to load the CA trusted store.
feat: Loading the CA trusted store certificate into Feast to verify the public certificate.
Dec 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor nits for future readers
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Dec 20, 2024
…he public certificate. (feast-dev#4852)
* Initial Draft version to load the CA trusted store code.
Signed-off-by: lrangine <[email protected]>
* Initial Draft version to load the CA trusted store code.
Signed-off-by: lrangine <[email protected]>
* Fixing the lint error.
Signed-off-by: lrangine <[email protected]>
* Trying to fix the online store test cases.
Signed-off-by: lrangine <[email protected]>
* Formatted the python to fix lint errors.
Signed-off-by: lrangine <[email protected]>
* Fixing the unit test cases.
Signed-off-by: lrangine <[email protected]>
* Fixing the unit test cases.
Signed-off-by: lrangine <[email protected]>
* removing unnecessary cli args.
Signed-off-by: lrangine <[email protected]>
* Now configuring the SSL ca store configurations on the feast client side rather than on the server side. And also fixing the integration tests.
Signed-off-by: lrangine <[email protected]>
* Renamed the remote registry is_tls_mode variable to is_tls.
Changed the offline store TLS setting decision from cert to scheme.
Signed-off-by: lrangine <[email protected]>
* Adding the existing trust store certificates to the newly created trust store.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* combining the default system ca store with the custom one to fix the integration tests.
Signed-off-by: lrangine <[email protected]>
* Final clean up and adding documentation.
Signed-off-by: lrangine <[email protected]>
* Incorporating the code review comments from Francisco.
Signed-off-by: lrangine <[email protected]>
---------
Signed-off-by: lrangine <[email protected]>
dharmisha
pushed a commit
to nishantgaurav-dev/feast
that referenced
this pull request
Jan 15, 2025
…he public certificate. (feast-dev#4852)
* Initial Draft version to load the CA trusted store code.
Signed-off-by: lrangine <[email protected]>
* Initial Draft version to load the CA trusted store code.
Signed-off-by: lrangine <[email protected]>
* Fixing the lint error.
Signed-off-by: lrangine <[email protected]>
* Trying to fix the online store test cases.
Signed-off-by: lrangine <[email protected]>
* Formatted the python to fix lint errors.
Signed-off-by: lrangine <[email protected]>
* Fixing the unit test cases.
Signed-off-by: lrangine <[email protected]>
* Fixing the unit test cases.
Signed-off-by: lrangine <[email protected]>
* removing unnecessary cli args.
Signed-off-by: lrangine <[email protected]>
* Now configuring the SSL ca store configurations on the feast client side rather than on the server side. And also fixing the integration tests.
Signed-off-by: lrangine <[email protected]>
* Renamed the remote registry is_tls_mode variable to is_tls.
Changed the offline store TLS setting decision from cert to scheme.
Signed-off-by: lrangine <[email protected]>
* Adding the existing trust store certificates to the newly created trust store.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* Clearing the existing trust store configuration to see if it fixes the PR integration failures.
Signed-off-by: lrangine <[email protected]>
* combining the default system ca store with the custom one to fix the integration tests.
Signed-off-by: lrangine <[email protected]>
* Final clean up and adding documentation.
Signed-off-by: lrangine <[email protected]>
* Incorporating the code review comments from Francisco.
Signed-off-by: lrangine <[email protected]>
---------
Signed-off-by: lrangine <[email protected]>
|