GeezerVison is showing github.com — fix: Improve status.applied updates & add offline pvc unit test by tchughesiv · Pull Request #4871 · feast-dev/feast
Conversation
tchughesiv
commented
Dec 21, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
- Change order of status.applied update to avoid conflicts & ensure all defaults are properly set
- Add offline PVC unit test to ensure ephemeral registry & online paths are updated accordingly
- Minor code improvements
Which issue(s) this PR fixes:
Relates to #4866
Misc
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tchughesiv
changed the title
fix: Improve status.applied update & add offline pvc unit test
fix: Improve status.applied updates & add offline pvc unit test
Dec 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.