GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Add project filter to apply_data_source and delete_data_source by mailtoboggavarapu-coder · Pull Request #6298 · feast-dev/feast

fix: Add project filter to apply_data_source and delete_data_source #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

mailtoboggavarapu-coder wants to merge 7 commits into feast-dev:master from mailtoboggavarapu-coder:fix/apply-data-source-project-filter

Uh oh!

There was an error while loading. Please reload this page.

Closed

fix: Add project filter to apply_data_source and delete_data_source #6298

Changes from 1 commit

Commits

Show all changes

7 commits

Select commit Hold shift + click to select a range

5b34cbb

fix: Add project filter to apply_data_source and delete_data_source

mailtoboggavarapu-coder Apr 22, 2026

43faac7

test: add cross-project isolation tests for apply/delete_data_source

mailtoboggavarapu-coder Apr 22, 2026

eb71758

style: apply ruff formatting fixes to registry.py

mailtoboggavarapu-coder Apr 22, 2026

58e4a38

style: fix ruff E302 missing blank line before test function

mailtoboggavarapu-coder Apr 22, 2026

c438089

DCO Remediation Commit for 58e4a3853ba93884b7ff1eecc782e7af3f477a74

mailtoboggavarapu-coder Apr 22, 2026

528aa8f

DCO Remediation Commit for eb7175877975bbd2bc32b804d2c0c3a08613d90e

mailtoboggavarapu-coder Apr 22, 2026

163625a

Merge branch 'master' into fix/apply-data-source-project-filter

mailtoboggavarapu-coder Apr 22, 2026

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

Next commit

fix: Add project filter to apply_data_source and delete_data_source

Fixes two methods in the shared registry that were matching data sources
by name only, without filtering by project. In multi-project registries
where different projects share the same data source name (e.g. the
default "vals_to_add"), this caused:

- apply_data_source: cross-project overwriting of data sources
- delete_data_source: deleting data sources from the wrong project

Changes:
- apply_data_source: adds and existing_data_source_proto.project == project
  check (mirrors the pattern used in apply_entity, apply_feature_service,
  apply_feature_view)
- delete_data_source: uses the same project-scoped filter for consistency
- Fix Unicode mojibake in registry.py comments (em dashes and right arrows
  were stored as double-encoded Latin-1 bytes)
- apply ruff format - collapse single-line timestamp assignment

Fixes #6206

Signed-off-by: Venkateswarlu Boggavarapu <[email protected]>

Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

mailtoboggavarapu-coder committed Apr 22, 2026

commit 5b34cbb133b72588c55dde55d4d46a022238d5ae

There are no files selected for viewing

20 changes: 12 additions & 8 deletions 20 sdk/python/feast/infra/registry/registry.py

Show comments

View file

Open in desktop

Comment thread

devin-ai-integration[bot] marked this conversation as resolved.

Resolved

Uh oh!

There was an error while loading. Please reload this page.

Original file line number	Diff line number	Diff line change
Expand Up		@@ -394,16 +394,17 @@ def apply_data_source(
		registry = self._prepare_registry_for_changes(project)

		for idx, existing_data_source_proto in enumerate(registry.data_sources):
		if existing_data_source_proto.name == data_source.name:
		if (
		existing_data_source_proto.name == data_source.name
		and existing_data_source_proto.project == project
		):
		existing_data_source = DataSource.from_proto(existing_data_source_proto)
		# Check if the data source has actually changed
		if existing_data_source == data_source:
		return
		else:
		# Preserve created_timestamp from existing data source
		data_source.created_timestamp = (
		existing_data_source.created_timestamp
		)
		data_source.created_timestamp = existing_data_source.created_timestamp
		del registry.data_sources[idx]
		break

Expand All		@@ -423,7 +424,10 @@ def delete_data_source(self, name: str, project: str, commit: bool = True):
		for idx, data_source_proto in enumerate(
		self.cached_registry_proto.data_sources
		):
		if data_source_proto.name == name:
		if (
		data_source_proto.name == name
		and data_source_proto.project == project
		):
		del self.cached_registry_proto.data_sources[idx]
		if commit:
		self.commit()
Expand Down Expand Up		@@ -688,13 +692,13 @@ def apply_feature_view(

		if not is_latest:
		# Explicit version: check if it exists (pin/revert) or not (forward declaration).
		# Note: The file registry is last-write-wins for true concurrent races —
		# Note: The file registry is last-write-wins for true concurrent races â
Comment thread devin-ai-integration[bot] marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		# this is a pre-existing limitation for all file registry operations.
		# For multi-client environments, use the SQL registry.
		record = self._get_version_record(feature_view.name, project, pin_version)

		if record is not None:
		# Version exists → pin/revert to that snapshot
		# Version exists â pin/revert to that snapshot
		# Check that the user hasn't also modified the definition.
		# Compare user's FV (with version="latest") against active FV.
		self._prepare_registry_for_changes(project)
Expand Down Expand Up		@@ -735,7 +739,7 @@ def apply_feature_view(
		# Apply the restored FV using the standard path below
		feature_view = restored_fv
		else:
		# Version doesn't exist → forward declaration: create it
		# Version doesn't exist â forward declaration: create it
		feature_view.current_version_number = pin_version
		feature_view_proto = feature_view.to_proto()
		feature_view_proto.spec.project = project
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.