GeezerVison is showing github.com — feat: Support token, uri and db_name in the Milvus online store by simonhearne · Pull Request #6895 · feast-dev/feast
Conversation
What this PR does / why we need it:
The Milvus client was always built as MilvusClient(uri=f"{host}:{port}", token=f"{username}:{password}").
API keys couldn't be used, and there was no way to choose a database.
This PR adds three new optional config parameters:
| Field |
Behaviour |
uri |
Full endpoint. Takes precedence over host/port, and over a Milvus Lite path. |
token |
API key or username:password. Takes precedence over username/password. |
db_name |
Database to use; must already exist. |
Existing configs build exactly the same client arguments (covered by a test). The docs add a Zilliz
Cloud example that reads the token from an environment variable.
Which issue(s) this PR fixes:
N/A
Checks
- I've made sure the tests are passing.
- My commits are signed off (
git commit -s)
- My PR title follows conventional commits format
Testing Strategy
-
Unit tests
-
Integration tests
-
Manual tests
-
Testing is not required for this change
-
Unit: parametrized client arguments for existing configs, token/uri precedence and db_name;
uri beats path; path still selects Milvus Lite.
-
Server: collections are created in db_name and not in default. Token authentication was
exercised against Zilliz Cloud with an API key.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.07%. Comparing base (b8989cb) to head (6478647).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@ Coverage Diff @@
## master #6895 +/- ##
==========================================
+ Coverage 48.06% 48.07% +0.01%
==========================================
Files 427 427
Lines 53591 53605 +14
Branches 7799 7802 +3
==========================================
+ Hits 25758 25772 +14
Misses 25980 25980
Partials 1853 1853
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8989cb...6478647. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The Milvus client was always built from host:port with a
username:password token, so Zilliz Cloud API keys could not be used
and every collection landed in the default database.
Adds three optional config fields:
- token: an API key or username:password; takes precedence over
username/password.
- uri: a full endpoint; takes precedence over host/port (and over a
Milvus Lite path).
- db_name: the Milvus database to use.
Existing configurations build exactly the same client arguments.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Simon Hearne <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 1, 2026
This was referenced Oct 28, 2026
This was referenced Nov 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.