GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Support token, uri and db_name in the Milvus online store by simonhearne · Pull Request #6895 · feast-dev/feast

Conversation

@simonhearne

@simonhearne simonhearne commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The Milvus client was always built as MilvusClient(uri=f"{host}:{port}", token=f"{username}:{password}").
API keys couldn't be used, and there was no way to choose a database.

This PR adds three new optional config parameters:

Field Behaviour
uri Full endpoint. Takes precedence over host/port, and over a Milvus Lite path.
token API key or username:password. Takes precedence over username/password.
db_name Database to use; must already exist.

Existing configs build exactly the same client arguments (covered by a test). The docs add a Zilliz
Cloud example that reads the token from an environment variable.

Which issue(s) this PR fixes:

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests

  • Integration tests

  • Manual tests

  • Testing is not required for this change

  • Unit: parametrized client arguments for existing configs, token/uri precedence and db_name;
    uri beats path; path still selects Milvus Lite.

  • Server: collections are created in db_name and not in default. Token authentication was
    exercised against Zilliz Cloud with an API key.

Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@simonhearne
simonhearne requested a review from a team as a code owner September 29, 2026 16:53
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.07%. Comparing base (b8989cb) to head (6478647).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6895      +/-   ##
==========================================
+ Coverage   48.06%   48.07%   +0.01%     
==========================================
  Files         427      427              
  Lines       53591    53605      +14     
  Branches     7799     7802       +3     
==========================================
+ Hits        25758    25772      +14     
  Misses      25980    25980              
  Partials     1853     1853              
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 49.41% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
.../infra/online_stores/milvus_online_store/milvus.py 71.24% <100.00%> (+0.90%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8989cb...6478647. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0 haoxu0 added the ok-to-test label Sep 29, 2026
ntkathole
ntkathole approved these changes Oct 1, 2026
View reviewed changes
@simonhearne @claude @ntkathole
feat: Support token, uri and db_name in the Milvus online store
6478647
The Milvus client was always built from host:port with a
username:password token, so Zilliz Cloud API keys could not be used
and every collection landed in the default database.

Adds three optional config fields:
- token: an API key or username:password; takes precedence over
  username/password.
- uri: a full endpoint; takes precedence over host/port (and over a
  Milvus Lite path).
- db_name: the Milvus database to use.

Existing configurations build exactly the same client arguments.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Simon Hearne <[email protected]>
@ntkathole
ntkathole force-pushed the feat/milvus-token-uri-db branch from 8c75f09 to 6478647 Compare October 1, 2026 04:12
@ntkathole
ntkathole merged commit c5efecd into feast-dev:master Oct 1, 2026
20 of 23 checks passed

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 1, 2026
feat: Make Milvus index and search params configurable #6917
Merged
feat: Add consistency_level to the Milvus online store config #6921
Merged
feat: Support Milvus partition keys in the Milvus online store #6940
Merged
@simonhearne simonhearne mentioned this pull request Oct 16, 2026
feat: Add native_numeric_types to the Milvus online store #7025
Closed
4 of 7 tasks
This was referenced Oct 28, 2026
feat: Add row deletion to the Milvus online store #7082
Merged
feat: Add num_partitions and partition_key_isolation to the Milvus online store #7083
Merged
fix: Break event timestamp ties by created timestamp in Milvus write batches #7084
Merged
This was referenced Nov 9, 2026
feat: Add a schema check and mutation timeout to the Milvus online store #7118
Merged
fix: Round-trip every Feast type and null in the Milvus online store #7119
Closed
feat: Add native complex types and scalar index tags to the Milvus online store #7120
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@simonhearne @codecov-commenter @ntkathole @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.