GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — feat: Make Milvus index and search params configurable by simonhearne · Pull Request #6917 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:Milvus search params were hard-coded to
online_store: type: milvus index_type: "AUTOINDEX" search_params: level: 2 Which issue(s) this PR fixes:N/A Checks
Testing Strategy
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in MiscPart of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882 and #6895.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #6917 +/- ## ========================================== + Coverage 48.50% 48.52% +0.01% ========================================== Files 427 427 Lines 53755 53774 +19 Branches 7827 7832 +5 ========================================== + Hits 26076 26092 +16 - Misses 25813 25816 +3 Partials 1866 1866
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
fe65208 to
37bbcb9
Compare
Search params were hard-coded to {"nprobe": 10} and index params to
{"nlist": nlist}. index_type: AUTOINDEX failed on Milvus servers and
Zilliz Cloud with "only metric type can be passed when use AutoIndex",
because nlist and the collection name were sent as index params.
Adds optional index_params and search_params config fields that are
passed through to Milvus. When unset, the previous defaults are kept,
except that AUTOINDEX gets no params. The collection name is no longer
passed as an index param. AUTOINDEX can now be tuned with the level
search param.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Simon Hearne <[email protected]>
37bbcb9 to
c48b65d
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.