GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add consistency_level to the Milvus online store config by simonhearne · Pull Request #6921 · feast-dev/feast

Conversation

@simonhearne

@simonhearne simonhearne commented Oct 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds two optional Milvus online store settings, each Strong, Bounded, Session or Eventually:

  • consistency_level is sent with every read and search (query, search, keyword query).
  • collection_consistency_level is set when Feast creates a collection. It becomes the collection's
    default for requests that don't specify a level, e.g. from other clients.

The two are independent. When they are unset nothing is sent, so Milvus keeps its default
(Bounded), which is the current behaviour.

With Bounded, a read issued straight after materialization may briefly miss the newest writes.
consistency_level: Strong makes Feast's reads always see the latest writes, at the cost of higher
read latency, and takes effect without recreating collections.

online_store:
  type: milvus
  consistency_level: "Strong"
  collection_consistency_level: "Bounded"

Which issue(s) this PR fixes:

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests

  • Integration tests

  • Manual tests

  • Testing is not required for this change

  • Unit (mocked client): neither level sent when unset; consistency_level sent only to query,
    search and keyword query; collection_consistency_level sent only to create_collection;
    different values for each are applied independently; invalid values rejected.

  • Server: collection level is Bounded by default and follows collection_consistency_level;
    with consistency_level: Strong on a Bounded collection, a write is visible to the next read.

Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0, a local Milvus 3.0.2 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.

Misc

Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895 and #6917.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@simonhearne
simonhearne requested a review from a team as a code owner October 1, 2026 14:01
@codecov-commenter

codecov-commenter commented Oct 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.71%. Comparing base (298c3f6) to head (ee7f255).
⚠️ Report is 3 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6921      +/-   ##
==========================================
+ Coverage   48.64%   48.71%   +0.06%     
==========================================
  Files         427      427              
  Lines       53864    53934      +70     
  Branches     7849     7865      +16     
==========================================
+ Hits        26203    26272      +69     
+ Misses      25792    25789       -3     
- Partials     1869     1873       +4     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 50.08% <100.00%> (+0.06%) ⬆️
Files with missing lines Coverage Δ
.../infra/online_stores/milvus_online_store/milvus.py 72.78% <100.00%> (+0.57%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0056565...ee7f255. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0 haoxu0 added the ok-to-test label Oct 2, 2026
ntkathole
ntkathole approved these changes Oct 4, 2026
View reviewed changes
@simonhearne @claude @ntkathole
feat: Add consistency_level to the Milvus online store config
ee7f255
Adds two optional settings, each Strong, Bounded, Session or Eventually:
consistency_level is sent with every read and search, and
collection_consistency_level is set when Feast creates a collection.
When unset nothing is sent, so Milvus keeps its default (Bounded)
exactly as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Simon Hearne <[email protected]>
@ntkathole
ntkathole force-pushed the feat/milvus-consistency-level branch from 706be05 to ee7f255 Compare October 4, 2026 13:08
@ntkathole
ntkathole merged commit 97296c1 into feast-dev:master Oct 4, 2026
18 of 25 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@simonhearne simonhearne mentioned this pull request Oct 5, 2026
feat: Support Milvus partition keys in the Milvus online store #6940
Merged
5 of 7 tasks
@simonhearne simonhearne mentioned this pull request Oct 16, 2026
feat: Add native_numeric_types to the Milvus online store #7025
Closed
4 of 7 tasks
This was referenced Oct 28, 2026
feat: Add row deletion to the Milvus online store #7082
Merged
feat: Add num_partitions and partition_key_isolation to the Milvus online store #7083
Merged
fix: Break event timestamp ties by created timestamp in Milvus write batches #7084
Merged
This was referenced Nov 9, 2026
feat: Add a schema check and mutation timeout to the Milvus online store #7118
Merged
fix: Round-trip every Feast type and null in the Milvus online store #7119
Closed
feat: Add native complex types and scalar index tags to the Milvus online store #7120
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@simonhearne @codecov-commenter @ntkathole @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.