GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Survival block breaking by koskja · Pull Request #510 · feather-rs/feather

Conversation

@koskja

@koskja koskja commented Jan 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Implementing breaking blocks in survival

Status

  • Ready
  • Development
  • Hold

Description

The goal of this PR is to implement the survival mining mechanic. This depends on potion effects (haste and mining fatigue) and physics (player in water/flying). The blocks currently do not drop items on the ground, nor does mining decrease durability.

I believe that the related issues can be resolved at a later time, simply because mining is an integral part of the game and works well enough without these features.

Related issues

Original issue #351
Potion effects #430
Physics #357

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
koskja added 13 commits December 30, 2021 22:50
@koskja
First commit
cb6c3f6 
Gamemode hardcoded to survival for testing
@koskja
Block breaking progress sent to client
3e5d7e8
@koskja
Block breaking speed calculation
316f490
@koskja
WIP
c36fe98 
Breaking blocks in survival works 90% of the time
Instamine and creative mostly untested
Time to mine blocks off by 20% for unknown reasons
 Netherite tools are not included in `BlockKind::harvest_tools`
 nor in `BlockKind::dig_multipliers`
@koskja
Please formatter and clippy
bc78067
@koskja
Merge branch 'feather-rs:main' into blockbreak
144f9f1
@koskja
Merge origin/main
43538c6
@koskja
Improve documentation
5305071
@koskja
Switch to float based break progress
d6dd708
@koskja
Merge branch 'main' of https://github.com/koskja/feather into blockbreak
4d2a296
@koskja
Fix block breaking progress
becec55
@koskja
Merge remote-tracking branch 'origin/main' into blockbreak
f9f5b6f
@koskja
Make clippy happy
bbfd69b
@koskja
koskja force-pushed the blockbreak branch from fc74ee0 to bbfd69b Compare August 28, 2022 20:05
koskja added 2 commits August 29, 2022 01:23
@koskja
Fix mining animation
42e78d0 
Greatly simplify code
Add an ad hoc gamemode changing system
@koskja
Fix CI
cbc4950
@Defman

Defman commented Aug 29, 2022

Copy link
Copy Markdown
Member

Is this something you want me to look at soon?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koskja
Add rudimentary documentation
d9914f1
@koskja
koskja force-pushed the blockbreak branch from 2fa337b to d9914f1 Compare August 29, 2022 14:08
@koskja

koskja commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

This PR actually feels mostly finished. I added a feature that allows the player to change their gamemode by writing 's' or 'c' in the chat, and I am not sure whether we want to keep push that to main. It does howerver seem like a good placeholder before we get actual commands. Other than that, I am happy with the rest and it is up for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Defman
Defman approved these changes Aug 29, 2022
View reviewed changes

@Defman Defman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, its a bit wide as its also implementing a simple effect api. Hopefully a future API could take this simple api and improve upon it.

The code is quite self explanatory, but could be nice with a few references to the constants and etc.

I noticed the CI is complaining about noun vs no_run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
koskja added 2 commits August 29, 2022 22:02
@koskja
Change norun to no_run
9ce3652 
Remove effects system
@koskja
Fix doctest attribute
accc62e
@koskja

koskja commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

Anything else?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defman Defman Defman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@koskja @Defman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.