GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move `withTmpFile` next to `withTmpDir` by mario-campos · Pull Request #4140 · github/codeql-action

Conversation

@mario-campos

@mario-campos mario-campos commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Now that changetool has been moved to pr-checks (see #4128), this PR moves withTmpFile to util.ts, alongside withTmpDir.

Additionally, it refactors withTmpFile to make use of withTmpDir internally, reducing a bit of the duplication of creating a temporary directory.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • N/A

Products:

  • N/A

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mario-campos added 2 commits September 10, 2026 15:36
@mario-campos
Move withTmpFile to util.ts and update tests to use it
4375107
@mario-campos
Reduce duplication by using withTmpDir in withTmpFile
f6491d6
@mario-campos
mario-campos requested review from mbg and a balanced review from Copilot September 10, 2026 20:41
@mario-campos
mario-campos requested a review from a team as a code owner September 10, 2026 20:41
@github-actions github-actions Bot added the size/S Should be easy to review label Sep 10, 2026
Copilot started reviewing on behalf of mario-campos September 10, 2026 20:42
View session
Copilot AI reviewed Sep 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Temporary files leak on callback failure, and the committed JavaScript output is not regenerated.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 High severity · 1 Medium severity

New issues introduced by this change (2)
Severity Finding
High severity src/​util.ts — Regenerate the committed JavaScript output
Medium severity src/​util.ts — Preserve cleanup when the callback fails
What changed in this PR

Moves withTmpFile into the shared utility module and reuses it in changelog validation tests.

Changes:

  • Adds withTmpFile using withTmpDir.
  • Removes the duplicated test-local implementation.
File Description
src/​util.ts Adds the shared temporary-file helper.
pr-checks/​changelog/​validate.test.mts Uses the shared helper.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/util.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/util.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos mario-campos changed the title Mario campos/move with tmp file Move withTmpFile next to withTmpDir Sep 10, 2026
@mario-campos
mario-campos marked this pull request as draft September 10, 2026 21:24
@mario-campos
Update npm commands in sync.sh to include workspace root dependencies
297617d
@mario-campos
mario-campos marked this pull request as ready for review September 10, 2026 22:37
@mario-campos mario-campos mentioned this pull request Sep 11, 2026
Validate change-notes as a PR check #4116
Merged
mbg
mbg reviewed Sep 11, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR! I am happy for us to add withTmpFile to util.ts, even though withTmpFile is not currently used by the main codebase. It won't affect the bundled JS (as you noted already in response to Copilot) since it's not reachable from the main codebase's entry points.

I added a few small suggestions, but nothing major.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread pr-checks/changelog/validate.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/sync.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/util.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/util.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos @mbg
Delete unnecessary .js file extension from import statement
15b91db
Co-authored-by: Michael B. Gale <[email protected]>
mbg
mbg previously approved these changes Sep 11, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere, we are happy to keep the changes to sync.sh as they are, since they should resolve the issue permanently and there's no immediately obvious drawback to that approach right now. Thanks for providing the context on that and addressing my other feedback!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/util.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
Add JSDoc to withTmpFile
faf4f3a
@mario-campos
mario-campos dismissed mbg’s stale review via faf4f3a September 11, 2026 16:12
@mario-campos
mario-campos force-pushed the mario-campos/move-withTmpFile branch from b5a741b to faf4f3a Compare September 11, 2026 16:12
mbg
mbg approved these changes Sep 11, 2026
View reviewed changes
@mario-campos
mario-campos added this pull request to the merge queue Sep 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 11, 2026

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 1cf8f51 Sep 11, 2026
222 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos deleted the mario-campos/move-withTmpFile branch September 11, 2026 19:06
This was referenced Sep 18, 2026
Merge main into releases/v4 #4152
Merged
Merge releases/v4 into releases/v3 #4154
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mario-campos @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.