GeezerVison is showing github.com — Run `gc.collect()` twice in `test_rename` on Python 3.12 by EliahKagan · Pull Request #2109 · gitpython-developers/GitPython
Conversation
EliahKagan
commented
Mar 9, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Recently, the conditional gc.collect() step for Python >= 3.12 in TestSubmodule.test_rename is often insufficient. This has mainly been seen in #2248. For example:
https://github.com/gitpython-developers/GitPython/actions/runs/22864869684/job/66331124651?pr=2106#step:12:620
In principle, there can be situations with finalizers where a cycle is only collectable due to finalization that happened due to a previous collection. Therefore, there is occasionally a benefit to collecting twice. This does that, in the hope that it will help.
As expanded on in my self-review comment below, I hope this is temporary, at least in this exact form.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Improves test stability on Python 3.12+ (especially Windows) by increasing the likelihood that cyclic garbage with finalizers is fully collected before proceeding with submodule rename assertions.
Changes:
- Call
gc.collect() twice on Windows + Python 3.12+ in TestSubmodule.test_rename.
- Add an inline note explaining why a second collection can help.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Mar 9, 2026
As discussed in gitpython-developers#2005 and gitpython-developers#2011, we had not been doing this before.
Conditions have changed in two relevant ways:
- The free-threaded interpreter has been around longer and it sees
more use.
- The macOS runners are very fast now.
The specific motivations for doing this now are:
- In view of the condition described in gitpython-developers#2109 and how the change
there seems to have helped with it, there's some reason to think
*patch* versions of Python sometimes affect GitPython in ways it
makes possibly unfounded assumptions about the effect of garbage
collection. This mainly affects Windows and it is not specific to
free-threaded builds. However, in principle we could also see
assumptions violated in tests we think always work on Unix-like
operating systems, due to differences in how garbage collection
works in free-threaded interpreters. Therefore, the assumption
that this only needs to be tested occasionally is not as well
founded I assumed when I suggested testing it only on GNU/Linux.
- We may add 3.14 jobs to CI soon, and it's useful to be able to
see how both free-threaded interpreters work on CI, as well as to
confirm for at least a short while that they are continuing to
work as expected.
This macOS free-threaded interpreter CI jobs could be disabled once
more if necessary, or if they're found to make CI complete slower
in PRs by even a small amount so long as they don't seem to be
surfacing anything.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Mar 9, 2026
As discussed in gitpython-developers#2005 and gitpython-developers#2011, we had not been doing this before.
Conditions have changed in two relevant ways:
- The free-threaded interpreter has been around longer and it sees
more use.
- The macOS runners are very fast now.
The specific motivations for doing this now are:
- In view of the condition described in gitpython-developers#2109 and how the change
there seems to have helped with it, there's some reason to think
*patch* versions of Python sometimes affect GitPython in ways it
makes possibly unfounded assumptions about the effect of garbage
collection. This mainly affects Windows and it is not specific to
free-threaded builds. However, in principle we could also see
assumptions violated in tests we think always work on Unix-like
operating systems, due to differences in how garbage collection
works in free-threaded interpreters. Therefore, the assumption
that this only needs to be tested occasionally is not as well
founded I assumed when I suggested testing it only on GNU/Linux.
- We may add 3.14 jobs to CI soon, and it's useful to be able to
see how both free-threaded interpreters work on CI, as well as to
confirm for at least a short while that they are continuing to
work as expected.
This macOS free-threaded interpreter CI jobs could be disabled once
more if necessary, or if they're found to make CI complete slower
in PRs by even a small amount so long as they don't seem to be
surfacing anything.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Mar 9, 2026
As discussed in gitpython-developers#2005 and gitpython-developers#2011, we had not been doing this before.
Conditions have changed in two relevant ways:
- The free-threaded interpreter has been around longer and it sees
more use.
- The macOS runners are very fast now.
The specific motivations for doing this now are:
- In view of the condition described in gitpython-developers#2109 and how the change
there seems to have helped with it, there's some reason to think
*patch* versions of Python sometimes affect GitPython in ways it
makes possibly unfounded assumptions about the effect of garbage
collection. This mainly affects Windows and it is not specific to
free-threaded builds. However, in principle we could also see
assumptions violated in tests we think always work on Unix-like
operating systems, due to differences in how garbage collection
works in free-threaded interpreters. Therefore, the assumption
that this only needs to be tested occasionally is not as well
founded I assumed when I suggested testing it only on GNU/Linux.
- We may add 3.14 jobs to CI soon, and it's useful to be able to
see how both free-threaded interpreters work on CI, as well as to
confirm for at least a short while that they are continuing to
work as expected.
This macOS free-threaded interpreter CI jobs could be disabled once
more if necessary, or if they're found to make CI complete slower
in PRs by even a small amount so long as they don't seem to be
surfacing anything.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|
