GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix GitError being raised in initial `import git` by terminalmage · Pull Request #658 · gitpython-developers/GitPython

Conversation

@terminalmage

@terminalmage terminalmage commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

This catches any raise of one of the custom exceptions defined in git.exc during the imports in the dunder init, and raises an ImportError in those cases.

This is my (perhaps naïve) attempt to fix #657.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@terminalmage
Fix GitError being raised in initial import git
0b6cde8
This catches any raise of one of the custom exceptions defined in
`git.exc` during the imports in the dunder init, and raises an
`ImportError` in those cases.
@Byron

Byron commented Sep 28, 2017

Copy link
Copy Markdown
Member

Thanks a ton for your contribution, and my apologies for getting to this PR that late!

This looks great!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron
Byron merged commit 8ef53c5 into gitpython-developers:master Sep 28, 2017
@terminalmage terminalmage mentioned this pull request Jun 1, 2018
Failed import raises non-ImportError exception on MacOS #762
Closed
terminalmage added a commit to terminalmage/GitPython that referenced this pull request Jun 1, 2018
@terminalmage
Fix exception on import in MacOS
e166218
This is related to my fix in gitpython-developers#658. Apparently, MacOS adds a git
executable that is just a stub which displays an error. This gets past
the try/except I added in gitpython-developers#658, and allows all of the GitPython
components to be imported, but since the executable is not *actually*
git, it results in an exception when ``refresh()`` attemepts to run a
``git version``.
This was referenced Jun 1, 2018
Fix exception on import in MacOS #763
Merged
Master cannot see minion after 2018.3.0 upgrade saltstack/salt#47905
Closed
Byron pushed a commit that referenced this pull request Jun 5, 2018
@terminalmage @Byron
Fix exception on import in MacOS
ce5dfe7
This is related to my fix in #658. Apparently, MacOS adds a git
executable that is just a stub which displays an error. This gets past
the try/except I added in #658, and allows all of the GitPython
components to be imported, but since the executable is not *actually*
git, it results in an exception when ``refresh()`` attemepts to run a
``git version``.
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull request Dec 7, 2023
@Byron
Merge pull request gitpython-developers#658 from terminalmage/issue657
e4760e3
Fix GitError being raised in initial `import git`
riley-martine pushed a commit to riley-martine/GitPython that referenced this pull request Dec 7, 2023
@terminalmage @Byron
Fix exception on import in MacOS
e22563a
This is related to my fix in gitpython-developers#658. Apparently, MacOS adds a git
executable that is just a stub which displays an error. This gets past
the try/except I added in gitpython-developers#658, and allows all of the GitPython
components to be imported, but since the executable is not *actually*
git, it results in an exception when ``refresh()`` attemepts to run a
``git version``.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GitPython >= 2.1.4] Can't import without git CLI

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@terminalmage @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.