GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use actions/checkout feature to fetch all commits by EliahKagan · Pull Request #92 · gitpython-developers/gitdb

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Sep 11, 2023

Copy link
Copy Markdown
Member

It appears the intent of specifying a fetch-depth of 1000 is that 1000 is greater enough than the current number of commits in the repository that it will fetch the whole branch history, now and for some time into the future.

Assuming that is the case, I recommend doing a full fetch instead, which this PR changes it to do. Setting the fetch-depth to a positive value fetches that many commits back (and the default value is 1), but setting it to 0 fetches all commits, as in a normal deep (full) fetch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EliahKagan
EliahKagan marked this pull request as ready for review September 11, 2023 08:25
@EliahKagan
Use actions/checkout feature to fetch all commits
919d3cc 
Setting the "fetch-depth" to a positive value fetches that many
commits back (and the default value is 1), but setting it to 0
fetches all commits, as in a (deep) normal fetch.
@EliahKagan
EliahKagan force-pushed the ci-checkout branch from dac7d29 to 919d3cc Compare September 11, 2023 09:05
@Byron

Byron commented Sep 11, 2023

Copy link
Copy Markdown
Member

Thank you! I agree that setting it to zero is an indication that we need a couple of commits for tests to work. This reminds me of another glaring issue of GitPython: tests are not isolated and require a certain initial state that affects ones own work-environment. In practice, that's not an issue most of the time, but it's an issue nonetheless. In gitoxide tests are fully isolated and it's as easy as writing a bash script with git commands to setup a new fixture. Maybe one day, GitPython will have isolated/sandboxed tests as well.
EliahKagan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit 07948eb into gitpython-developers:master Sep 11, 2023
@EliahKagan
EliahKagan deleted the ci-checkout branch September 11, 2023 09:21
EliahKagan added a commit to EliahKagan/smmap that referenced this pull request Sep 17, 2023
@EliahKagan
Update ci, in line with gitdb
f1ddf01 
This updates smmap's CI configuration in ways that are in line with
recent updates to gitdb's. In most cases there is no difference in
the changes, and the reason for the updates is more to avoid
confusing differences than from the value of the changes
themselves. In one case, there is a major difference (fetch-depth).

- gitpython-developers/gitdb#89 (same)

- gitpython-developers/gitdb#90 (same)
  It's just the project, not dependencies, but otherwise the same.

- gitpython-developers/gitdb#92 (opposite)
  This is the major difference. We don't need more than the tip of
  the branch in these tests. Keeping the default fetch-depth of 1
  by not setting it explicitly avoids giving the impression that
  the tests here are doing something they are not (and also serves
  as a speed optimization).

- gitpython-developers/gitdb#93 (same)
@EliahKagan EliahKagan mentioned this pull request Sep 17, 2023
Update CI, in line with gitdb gitpython-developers/smmap#53
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EliahKagan @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.