GeezerVison is showing github.com — Don't cancel other jobs from the 3.12 job failing by EliahKagan · Pull Request #93 · gitpython-developers/gitdb
This repository was archived by the owner on Jul 26, 2026. It is now read-only.
Conversation
EliahKagan
commented
Sep 11, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Because 3.12 is still a release candidate and if tests fail for it then one would always want to know if/how other versions also fail.
Note that a failure of the 3.12 job will still be treated as a failed check and will still cause the workflow to be considered to have failed, which we probably want. Setting continue-on-error for the job just overrides the default matrix fail-fast behavior, so the 3.12 job won't cause other jobs from the matrix to be cancelled if it fails. (Other jobs will still cause cancellation.)
I used a technique based on the one in the GitHub Actions documentation, but modified so all versions can be listed in one place and so the automatically generated job names remain short, as they were before.
This also allows actions/setup-python to install a prerelease for 3.12 only, and no longer for other releases. (This is less important, because only under very strange circumstances would only an old prerelease of a stable release be available to the CI runner. But treating 3.12 specially, as above, allows this to be done too, with no increase in complexity.)
This may or may not be considered worthwhile, given that it should be undone sometime not long after the stable 3.12.0 comes out. However, I think the allow-preleases override to true should be undone at that time, so it seems to me that the burden is much the same either way (and the stakes very low, either way, if it is left in place too long).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Because 3.12 is still a release candidate and if tests fail for it
then one would always want to know if/how other versions also fail.
This also allows actions/setup-python to install a prerelease for
3.12 only, not for other releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I think this is similarly implemented in GitPython (soon) and it's a neat way of achieving this.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
EliahKagan reacted with thumbs up emoji
EliahKagan
commented
Sep 11, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks! Yes, I used the same pattern in gitpython-developers/GitPython#1654, though (in my mind) not entirely for the same purpose.
Here in gitdb's workflow file, fail-fast is not explicitly set, so it has its default value of true, and the main purpose of experimental here is to weaken that appropriately for 3.12 because it is a prerelease, by setting continue-on-error to true for it. While I was at it, I also used it to only permit setup-python to install a prerelease for 3.12.
In contrast, GitPython's roughly corresponding workflow file explicitly sets fail-fast to false, so there is no need to set continue-on-error, which I didn't do. Instead, I introduced experimental there just for the purpose of limiting setup-python to installing a prerelease for 3.12.
|
Byron reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
Sep 17, 2023
This updates smmap's CI configuration in ways that are in line with
recent updates to gitdb's. In most cases there is no difference in
the changes, and the reason for the updates is more to avoid
confusing differences than from the value of the changes
themselves. In one case, there is a major difference (fetch-depth).
- gitpython-developers/gitdb#89 (same)
- gitpython-developers/gitdb#90 (same)
It's just the project, not dependencies, but otherwise the same.
- gitpython-developers/gitdb#92 (opposite)
This is the major difference. We don't need more than the tip of
the branch in these tests. Keeping the default fetch-depth of 1
by not setting it explicitly avoids giving the impression that
the tests here are doing something they are not (and also serves
as a speed optimization).
- gitpython-developers/gitdb#93 (same)
Reviewers
1 more reviewer
Byron
Byron approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|