GeezerVison is showing github.com — make dataloader work inside defer blocks by andimarek · Pull Request #3980 · graphql-java/graphql-java
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results
316 files ± 0 316 suites ±0 2m 26s ⏱️ ±0s
4 656 tests +1 002 4 647 ✅ +998 9 💤 +4 0 ❌ ±0
4 745 runs +1 002 4 736 ✅ +998 9 💤 +4 0 ❌ ±0
Results for commit a7cc794. ± Comparison against base commit 9ac3e63.
This pull request removes 192 and adds 1172 tests. Note that renamed tests count towards both.
?
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
a2 : __type(name : "t1") { name }
…
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@6f3f0fae delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@63fdffcd delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@7428de63 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@655523dd delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@6f7e336b delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@3a2b2322 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@60e21209 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@35835fa delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@4dafba3e delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@15bc339 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…
This pull request skips 4 tests.
graphql.GraphqlErrorHelperTest ‑ can handle custom extensions and custom error classification
graphql.GraphqlErrorHelperTest ‑ can handle custom extensions with classification
graphql.GraphqlErrorHelperTest ‑ can parse out a map and make an error
graphql.GraphqlErrorHelperTest ‑ can turn error classifications into extensions
♻️ This comment has been updated with latest results.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
|
* The expected field fetch count is accurate when all execute object calls happened
|
|
|
* The expected execute object count is accurate when all sub selections fetched
|
|
|
* are done in the previous level
|
|
|
* A general overview of teh tracked data:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
timward60
added a commit
to timward60/graphql-java
that referenced
this pull request
Feb 17, 2026
Use mergedFields.size() (per-fragment field count) instead of
deferredFields.size() (total across all fragments) when constructing
AlternativeCallContext. The inflated count prevented dispatch strategies
from ever triggering dispatch since each fragment only fetches its own
fields.
Fixes the bug introduced in graphql-java#3980.
Co-authored-by: Copilot <[email protected]>
This was referenced Feb 24, 2026
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|