GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Check each branch of a conditional expression under its condition by CatarinaGamboa · Pull Request #409 · liquid-java/liquidjava Conversation
Collaborator
ProblemThe branches of a conditional expression were checked without knowing which way its condition went: boolean canUndo = um.canUndo(); return canUndo ? um.getUndoPresentationName() : "Undo"; The same guard written as an Fix
Tests
Found on a real fixed bug (JabRef's 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe branches of `c ? a : b` were checked without knowing which way c went, so `canUndo ? um.getUndoPresentationName() : "Undo"` was rejected even though the call only runs when canUndo holds. Each branch now gets the condition (or its negation) as a path condition, encoded as for loops. Co-Authored-By: Claude Opus 5.5 <[email protected]>
rcosta358
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
1 task done
CatarinaGamboa
added a commit
that referenced
this pull request
## Description #412, #413 and #414 were merged into their stacked base branches instead of `main`: once #411 was merged, their bases were never retargeted. Their code is only on `feat/state-hints-unknown`. This PR applies the three reviewed commits on top of `main`, unchanged: - Explain dead ends in failing state transitions (#412) - List the calls that reach an allowed state when the state is unknown (#413) - Build each class's state machine once per checker (#414) The hint and state machine files are identical to `feat/state-hints-unknown`. Rebase-merging keeps the three commits separate. ## Checklist - [x] `mvn test` passes locally on top of the current `main` (#408, #409) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |