GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Explain dead ends in failing state transitions by CatarinaGamboa · Pull Request #412 · liquid-java/liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #411.

Description

When no call can fix a failing state transition, the error now says why:

  • Unreachable state: no sequence of calls reaches a state where the call is allowed. The hint suggests a constructor that creates the object in such a state, if one exists.
  • State depending on the path taken: the object can be in several states (e.g. after an if), and no single sequence of calls works for all of them.
  • Final state: no method with a state refinement can be called in any of the states the object can be in.

These hints claim that something is impossible, so they are only given when the machine is complete. That means every state-changing method of the class is modeled, and no superclass or subclass has state refinements of its own. When nothing is known about the state, these hints are not given; the next PR handles that case.

StateMachineBuilder now also records the states each constructor creates, when they only depend on the state of this.

Example

f.close();
f.read(); // read() needs open
 --> No sequence of calls moves f from closed to open. Create a new object instead with new File()
     f is in state closed, where none of its methods with state refinements can be called

Type of change

  • New feature

Checklist

  • Added tests:
    • ErrorStateHintFinalState and ErrorStateHintPathDependent.
    • ErrorStateHintIncomplete (a transition depends on an argument) and ErrorStateHintSubclass (a subclass adds a transition) get no dead-end claim.
    • ErrorStateHintSeveralRefinements now gets the path-dependent hint.
  • mvn test passes locally

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CatarinaGamboa CatarinaGamboa mentioned this pull request Oct 21, 2026
List the calls that reach an allowed state when the state is unknown #413
Merged
3 tasks done
@CatarinaGamboa
CatarinaGamboa added this pull request to stack #415 October 23, 2026 16:59
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/state-hints-calls branch from 3d2812b to 36a5562 Compare October 23, 2026 17:43
@CatarinaGamboa @claude
Explain dead ends in failing state transitions
f34e6f6
When no sequence of calls leads to a state that allows the failing
call, the error says so and suggests the constructors that create the
object in such a state, or, if the object can be in several states
depending on the path taken, asks for the same state on every path.
When no call is allowed in the object's state, the error says it is a
final state.

These claims are only made when the state machine models every
state-changing method of the class and of its super and subclasses.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/state-hints-calls branch from 36a5562 to fb438f1 Compare October 23, 2026 17:45
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/state-hints-dead-ends branch from 0cf5598 to f34e6f6 Compare October 23, 2026 17:45
@CatarinaGamboa
CatarinaGamboa removed this pull request from stack #415 October 23, 2026 18:02
@CatarinaGamboa
CatarinaGamboa merged commit f657056 into feat/state-hints-calls Oct 23, 2026
CatarinaGamboa added a commit that referenced this pull request Oct 23, 2026
@CatarinaGamboa @claude
List the calls that reach an allowed state when the state is unknown (#…
8972a0a
…413)

Stacked on #412.

## Description
When nothing is known about the receiver's state (e.g. a parameter with
no state refinement), the error used to say only that no state
information is known. For classes with a state machine, it now lists the
constructors and the calls that lead to a state allowing the failing
call, each with the states it is called from.

Classes without a state machine keep the previous general hint.

## Example
```java
static void use(File f) {
    f.read(); // read() needs open
}
```
```
 --> The state of f is unknown here. To get it to open, use: f.open() (from created)
```

## Type of change
- [x] New feature

## Checklist
- [x] Added tests: `ErrorStateHintUnknownState`. `TestStateHints` also
checks that a class without `@StateSet` keeps the general hint.
- [x] `mvn test` passes locally

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa CatarinaGamboa mentioned this pull request Oct 24, 2026
Land the rest of the state hints stack (#412, #413, #414) #417
Merged
1 task done
CatarinaGamboa added a commit that referenced this pull request Oct 24, 2026
@CatarinaGamboa @claude
Land the rest of the state hints stack (#412, #413, #414) (#417)
69895fa
## Description
#412, #413 and #414 were merged into their stacked base branches instead
of `main`: once #411 was merged, their bases were never retargeted.
Their code is only on `feat/state-hints-unknown`.

This PR applies the three reviewed commits on top of `main`, unchanged:
- Explain dead ends in failing state transitions (#412)
- List the calls that reach an allowed state when the state is unknown
(#413)
- Build each class's state machine once per checker (#414)

The hint and state machine files are identical to
`feat/state-hints-unknown`. Rebase-merging keeps the three commits
separate.

## Checklist
- [x] `mvn test` passes locally on top of the current `main` (#408,
#409)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.