GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pdf: Merge loops for single byte text chunk output by QuLogic · Pull Request #30567 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Sep 16, 2025

Copy link
Copy Markdown
Member

PR summary

Currently, we split text into single byte chunks and multi-byte glyphs, then iterate through single byte chunks for output and multi-byte glyphs for output.

Instead, output the single byte chunks as we finish them, then do the multi-byte glyphs at the end.

This was split out of #30512 and based on #30335.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added this to the v3.11.0 milestone Sep 16, 2025
@QuLogic QuLogic added this to Font and text overhaul Sep 16, 2025
@QuLogic QuLogic added the status: waiting for other PR label Sep 16, 2025
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Sep 16, 2025
@github-actions github-actions Bot added topic: text backend: ps backend: pdf backend: svg backend: cairo topic: text/mathtext labels Sep 16, 2025
@QuLogic
pdf: Merge loops for single byte text chunk output
3e97c0d 
Currently, we split text into single byte chunks and multi-byte glyphs,
then iterate through single byte chunks for output and multi-byte glyphs
for output.

Instead, output the single byte chunks as we finish them, then do the
multi-byte glyphs at the end.
@QuLogic QuLogic removed the status: waiting for other PR label Sep 17, 2025
@QuLogic
QuLogic force-pushed the pdf-loop-merge branch from 88dc315 to 3e97c0d Compare September 17, 2025 01:39
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Sep 17, 2025
@github-actions github-actions Bot removed topic: text backend: ps backend: svg backend: cairo topic: text/mathtext labels Sep 17, 2025
tacaswell
tacaswell approved these changes Sep 17, 2025
View reviewed changes
timhoffm
timhoffm approved these changes Sep 17, 2025
View reviewed changes
@QuLogic

QuLogic commented Sep 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

CI errors should be fixed by #30579 and are unrelated to this change, so I'll merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic merged commit 105f9eb into matplotlib:text-overhaul Sep 19, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Sep 19, 2025
@QuLogic
QuLogic deleted the pdf-loop-merge branch September 19, 2025 05:47
@QuLogic QuLogic mentioned this pull request Sep 22, 2025
pdf: Improve text with characters outside embedded font limits #30512
Merged
4 tasks done
wavebyrd pushed a commit to wavebyrd/matplotlib that referenced this pull request Mar 13, 2026
@QuLogic
Merge pull request matplotlib#30567 from QuLogic/pdf-loop-merge
3f143e5 
pdf: Merge loops for single byte text chunk output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: pdf

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @tacaswell @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.