GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge main back into text-overhaul branch to fix CI by QuLogic · Pull Request #30579 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Sep 18, 2025

Copy link
Copy Markdown
Member

PR summary

This should fix macOS CI and the disjoint bases issue.

Also, add an ignore for GlyphIndexType in stubtest, which may or may not be an upstream problem, but is the simplest fix for now.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ksunden and others added 30 commits May 9, 2025 12:23
@ksunden
Zenodo v3.10.3
3b85ba4
@timhoffm @meeseeksmachine
Backport PR matplotlib#30029: Update diagram in subplots_adjust docum…
d3c77af
…entation to clarify parameters
@timhoffm
Update doc/_embedded_plots/figure_subplots_adjust.py
b81427c
Fix flake8
@rcomer
Merge pull request matplotlib#30034 from meeseeksmachine/auto-backpor…
3d46cab
…t-of-pr-30029-on-v3.10.3-doc

Backport PR matplotlib#30029 on branch v3.10.3-doc (Update diagram in subplots_adjust documentation to clarify parameters)
@QuLogic @meeseeksmachine
Backport PR matplotlib#30118: CI: Skip jobs on forks
e188484
@QuLogic @meeseeksmachine
Backport PR matplotlib#30119: Add some types to _mathtext.py
5bdbb3a
@QuLogic
Merge pull request matplotlib#30142 from meeseeksmachine/auto-backpor…
5359e2f
…t-of-pr-30119-on-v3.10.3-doc

Backport PR matplotlib#30119 on branch v3.10.3-doc (Add some types to _mathtext.py)
@QuLogic
Merge pull request matplotlib#30141 from meeseeksmachine/auto-backpor…
34cca89
…t-of-pr-30118-on-v3.10.3-doc

Backport PR matplotlib#30118 on branch v3.10.3-doc (CI: Skip jobs on forks)
@jklymak @meeseeksmachine
Backport PR matplotlib#30180: DOC: expand polar example
3950d99
@rcomer @jklymak
Backport PR matplotlib#30180: DOC: expand polar example (matplotlib#3…
7f8a459
…0190)

Co-authored-by: Jody Klymak <[email protected]>
@timhoffm @meeseeksmachine
Backport PR matplotlib#30212: [Doc]: fix bug in release notes for mat…
96512fd
…plotlib v3.5.0 and v3.7.0
@timhoffm
Merge pull request matplotlib#30214 from meeseeksmachine/auto-backpor…
8b0808e
…t-of-pr-30212-on-v3.10.3-doc

Backport PR matplotlib#30212 on branch v3.10.3-doc ([Doc]: fix bug in release notes for matplotlib v3.5.0 and v3.7.0)
@jklymak @meeseeksmachine
Backport PR matplotlib#30244: DOC: Recommend to use bare Figure insta…
b122639
…nces for saving to file
@QuLogic
Merge pull request matplotlib#30251 from meeseeksmachine/auto-backpor…
cdb396d
…t-of-pr-30244-on-v3.10.3-doc

Backport PR matplotlib#30244 on branch v3.10.3-doc (DOC: Recommend to use bare Figure instances for saving to file)
@story645 @meeseeksmachine
Backport PR matplotlib#30289: DOC: Fix build with pybind11 3
74d8632
@rcomer
Merge pull request matplotlib#30294 from meeseeksmachine/auto-backpor…
a474f98
…t-of-pr-30289-on-v3.10.3-doc

Backport PR matplotlib#30289 on branch v3.10.3-doc (DOC: Fix build with pybind11 3)
@timhoffm
ENH: Allow to register standalone figures with pyplot
bc31177
It may be fundamentally nice not to have to create the figure
though pyplot to be able to use it in pyplot afterwards. You can now do

```
from matplotlib.figure import Figure
import matplotlib.pyplot as plt

fig = Figure()
fig.subplots().plot([1, 3, 2])

plt.figure(fig)  # fig is now tracked in pyplot
plt.show()
```

This also opens up the possibility to more dynamically track
and untrack figures in pyplot, which opens up the road to
optimized figure tracking in pyplot (matplotlib#29849)
@timhoffm
Clarifying comment
c718eae
@timhoffm
Fix: properly decouple from pyplot and specific backends when destroying
a38f9bb
When destroying a manager, replace the figure's canvas by a
figure canvas base.
@tacaswell
TST: do not use non-baseclass methods to get renderer in tests
eab4a89
There in now machinery for all of the public API that takes a
renderer is input to get it from the current canvas on the root
figure.  Use that machinery instead.
@tacaswell
TST: fix wx window closing test
2396e90
Flush the wx canvas, not the base canvas that is installed on close.
@tacaswell
TST: try forcing the dpi when testing saving after closing window
b7a5cfd
@tacaswell
FIX: do not add super().destroy to Canvas destroy method
c578ec6
This goes up the chain to the GUI classes that do not have this method.
@timhoffm
Add what's new note
06b97a8
@ksunden
Merge branch 'v3.10.3-doc' into v3.10.x
1316b33
@ksunden
Zenodo v3.10.5
b17b062
@tacaswell
MNT: restore the old DPI when resetting the canvas
db30cbe
This prevent the figures from growing on hi-dpi screens.
@tacaswell
TST: verify that dpi is restored on close
1ea856d
@timhoffm @rcomer
Update lib/matplotlib/figure.py
0e078a7
Co-authored-by: Ruth Comer <[email protected]>
@timhoffm
Add docs to state that you should not keep a reference to the canvas
1784c73
@github-actions github-actions Bot added Documentation: examples files in galleries/examples Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users labels Sep 18, 2025
timhoffm and others added 2 commits September 18, 2025 07:20
@timhoffm
MNT: Move all Colormap extremes setter logic into a single _set_extre…
554b9c5
…mes() (matplotlib#30577)
@QuLogic
TST: Force Agg backend in test_openin_any_paranoid
4a20d0f
On some CI, the Qt backend seems to be picked, but something is confused
and it fails due to an invalid `DISPLAY` variable. But this test doesn't
need an interactive backend, so don't use one.
@QuLogic

QuLogic commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

May want to wait to also add in #30581 here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anntzer and others added 3 commits September 18, 2025 09:10
@anntzer
Merge pull request matplotlib#30208 from QuLogic/more-cpp17
74beb8d
Make path extension a bit safer
@timhoffm
Merge pull request matplotlib#30569 from anntzer/fd
1377f24
Copy-edit the "fonts in pdf and postscript" table.
@tacaswell
Merge pull request matplotlib#30581 from QuLogic/make-test-safer
5cdd827
TST: Force Agg backend in test_openin_any_paranoid
@QuLogic
QuLogic force-pushed the fix-text-overhaul-ci branch from 73a9fc0 to e4078a2 Compare September 18, 2025 19:21
@github-actions github-actions Bot added the topic: path handling label Sep 18, 2025
@QuLogic

QuLogic commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

I redid the merge now that #30581 is in, and now somehow GitHub has decided to show all the commits from main...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@QuLogic

QuLogic commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

The last merge into the text-overhaul branch was 9766cbd, which came from 2eccf17, so this PR should be equal to 2eccf17...5cdd827 + the last commit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tacaswell

tacaswell commented Sep 18, 2025

Copy link
Copy Markdown
Member

Some of the failures look real but one of them is the c-coverage filter issue that we have fixed at least twice...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tacaswell
tacaswell approved these changes Sep 18, 2025
View reviewed changes

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave to @QuLogic discretion to fix the failing tests in this PR or to do it in a follow on.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@QuLogic

QuLogic commented Sep 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Some of the failures look real but one of them is the c-coverage filter issue that we have fixed at least twice...

Ah, I think we have a specific cutout for ubuntu-24.04, but it should also catch ubuntu-22.04-arm as well. It has lcov 2:
https://github.com/matplotlib/matplotlib/actions/runs/17839138498/job/50723813450?pr=30579#step:5:876
(not sure why non-arm is still 1.15 though).

Let me push that and see if it works.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@QuLogic

QuLogic commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

This is actually affecting the main branch as well; I've opened #30586 to fix it there.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

QuLogic and others added 4 commits September 18, 2025 17:58
@QuLogic
ci: Bump Ubuntu ARM builder to 24.04
4576add
Since earlier today, the `ubuntu-22.04-arm` image has actually been
Ubuntu 24.04. Instead of working out how to fix that, switch to the
newer image explicitly.
@tacaswell
Merge pull request matplotlib#30586 from QuLogic/bump-ubuntu-arm
9da2022
ci: Bump Ubuntu ARM builder to 24.04
@QuLogic
Merge branch 'main' into text-overhaul
c8369ff
@QuLogic
MNT: Ignore differing stub for GlyphIndexType
b236488
This may be an upstream bug [1], but until that is determined, ignore
the error to get CI working.

[1] python/mypy#19877
@QuLogic
QuLogic force-pushed the fix-text-overhaul-ci branch from e4078a2 to b236488 Compare September 19, 2025 03:38
@QuLogic

QuLogic commented Sep 19, 2025

Copy link
Copy Markdown
Member Author

Since everything is passing now, I'll merge, as normally I've been doing main-to-text-overhaul merges without PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@QuLogic
QuLogic merged commit 0da372b into matplotlib:text-overhaul Sep 19, 2025
@QuLogic
QuLogic deleted the fix-text-overhaul-ci branch September 19, 2025 05:18
@QuLogic QuLogic added this to Font and text overhaul Sep 19, 2025
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Sep 19, 2025
@QuLogic QuLogic moved this from Waiting for other PR to Done in Font and text overhaul Sep 19, 2025
@QuLogic QuLogic mentioned this pull request Sep 19, 2025
pdf: Merge loops for single byte text chunk output #30567
Merged
1 task done
wavebyrd pushed a commit to wavebyrd/matplotlib that referenced this pull request Mar 13, 2026
@QuLogic
Merge pull request matplotlib#30579 from QuLogic/fix-text-overhaul-ci
d92e286
Merge main back into text-overhaul branch to fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: pdf CI: Run cibuildwheel Run wheel building tests on a PR Documentation: devdocs files in doc/devel Documentation: examples files in galleries/examples Documentation: user guide files in galleries/users_explain or doc/users GUI: gtk GUI: MacOSX GUI: nbagg GUI: Qt GUI: tk GUI: wx Maintenance topic: axes topic: canvas and figure manager topic: collections and mappables topic: color/color & colormaps topic: contour topic: figures and subfigures topic: mplot3d topic: path handling topic: polar topic: pyplot API topic: text topic: ticks axis labels topic: transforms and scales topic: widgets/UI

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@QuLogic @tacaswell @ksunden @timhoffm @rcomer @jklymak @story645 @itsmeamitesh01 @Logan-Pageler @star1327p @dstansby @anntzer @trygvrad @ianthomas23 @brchristian @geofft @MengAiDev @jonathimer @AasmaGupta @Aaratrika-Shelly
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.