GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TST: Reset tolerances on tests changed by text overhaul by QuLogic · Pull Request #31303 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Mar 14, 2026

Copy link
Copy Markdown
Member

PR summary

Now that these have been regenerated, we can reset the tolerances. It is possible that we may still need some architecture-specific tolerances; I will restore them if we find that to be the case in CI here.

Only the last commit is relevant here.

AI Disclosure

None

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added the Maintenance label Mar 14, 2026
@QuLogic QuLogic added this to the v3.11.0 milestone Mar 14, 2026
@QuLogic QuLogic added this to Font and text overhaul Mar 14, 2026
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Mar 14, 2026
@QuLogic QuLogic added the status: waiting for other PR label Mar 14, 2026
@github-actions github-actions Bot added topic: mplot3d and removed status: waiting for other PR labels Mar 14, 2026
@github-actions github-actions Bot added the status: needs rebase label Mar 27, 2026
@QuLogic
QuLogic force-pushed the reset-tolerance branch from 226fed2 to 03e208f Compare April 3, 2026 06:44
@github-actions github-actions Bot removed the status: needs rebase label Apr 3, 2026
@QuLogic
QuLogic force-pushed the reset-tolerance branch from 03e208f to 62e806d Compare April 6, 2026 20:35
@github-actions github-actions Bot added the status: needs rebase label Apr 7, 2026
@QuLogic

QuLogic commented Apr 7, 2026

Copy link
Copy Markdown
Member Author

I've gone through the results.

All tests pass on x86_64 Ubuntu, except for the following, which fail everywhere and probably just weren't updated recently due to the existing tolerance:

Ubuntu (x86_64) Ubuntu 3.12 ARM macOS (all) Windows (all)
test_figure.py::test_align_titles[png] 0.008 0.002 0.013 0.008
test_axes3d.py::test_scale3d_artists_log[png] 0.028 0.028 0.031 0.028

All others pass on Windows as well, except for 1 test everywhere and 3 tests on AppVeyor only:

Windows (all Azure) Windows AppVeyor
test_patheffects.py::test_collection[png] 0.006 0.006
test_axes3d.py::TestVoxels.test_xyz[png] 0.001
test_axes_grid1.py::test_anchored_direction_arrows[png] 0.001
test_axes_grid1.py::test_anchored_direction_arrows_many_args[png] 0.001

On Ubuntu ARM and macOS (all ARM/M1 now, I believe), the following also fail:

Ubuntu 3.12 ARM macOS (all)
test_axes.py::test_canonical[png] 0.028
test_axes.py::test_contour_colorbar[pdf] 0.532 0.532
test_axes.py::test_contour_colorbar[png] 0.012 0.012
test_axes.py::test_contour_colorbar[svg] 0.130 0.130
test_axes.py::test_eb_line_zorder[png] 0.018
test_axes.py::test_formatter_ticker[png] 0.022
test_axes.py::test_imshow_clip[pdf] 1.238 1.238
test_axes.py::test_imshow_clip[png] 0.009 0.009
test_axes.py::test_imshow_clip[svg] 0.275 0.275
test_axes.py::test_markers_fillstyle_rcparams[png] 0.032
test_axes.py::test_pie_center_radius[png] 0.007
test_axes.py::test_preset_clip_paths[png] 0.007
test_axes.py::test_secondary_xy[png] 0.009 0.023
test_axes.py::test_set_get_ticklabels[png] 0.029
test_bbox_tight.py::test_bbox_inches_tight_suptile_legend[png] 0.021
test_contour.py::test_labels[png] 0.004 0.004
test_figure.py::test_align_labels[png] 0.001 0.008
test_figure.py::test_figure[png] 0.021
test_figure.py::test_subfigure_ss[png] 0.021
test_image.py::test_downsampling[png] 0.068 0.068
test_legend.py::test_alpha_rcparam[png] 0.012 0.025
test_legend.py::test_alpha_rgba[png] 0.012 0.025
test_legend.py::test_fancy[png] 0.007
test_legend.py::test_framealpha[png] 0.018 0.020
test_legend.py::test_labels_first[png] 0.014
test_legend.py::test_multiple_keys[png] 0.032
test_legend.py::test_shadow_argument_types[png] 0.027
test_patheffects.py::test_collection[png] 0.020 0.031
test_patheffects.py::test_patheffect2[png] 0.050
test_patheffects.py::test_patheffect3[png] 0.019
test_polar.py::test_polar_annotations[png] 0.008
test_polar.py::test_polar_coord_annotations[png] 0.012
test_subplots.py::test_subplots_offsettext[png] 0.013 0.027
test_units.py::test_numpy_facade[png] 0.002 0.022
mplot3d
test_axes3d.py::test_axes3d_primary_views[png] 0.044
test_axes3d.py::test_errorbar3d[png] 0.014
test_axes3d.py::test_stem3d[png] 0.001 0.007
test_legend3d.py::test_fancy[png] 0.009
axes_grid1
test_axes_grid1.py::test_anchored_direction_arrows[png] 0.003 0.005
test_axes_grid1.py::test_zooming_with_inverted_axes[png] 0.022
axisartist
test_grid_helper_curvelinear.py::test_custom_transform[png] 0.037 0.039

We knew from #31343 and #31300 (comment) that we needed to keep a few tolerances (6 and 3 from each, respectively) already. I will restore the tolerances on the remaining ones shortly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic force-pushed the reset-tolerance branch from 62e806d to f6d4e87 Compare April 7, 2026 02:41
@github-actions github-actions Bot removed the status: needs rebase label Apr 7, 2026
@QuLogic

QuLogic commented Apr 7, 2026

Copy link
Copy Markdown
Member Author

All tests pass on x86_64 Ubuntu, except for the following, which fail everywhere and probably just weren't updated recently due to the existing tolerance:

After updating these to pass with zero tolerance on x86_64, they now fail on other platforms as the following:

Ubuntu (x86_64) Ubuntu 3.12 ARM macOS (all) Windows (all)
test_figure.py::test_align_titles[png] 0 0.002 0.013 0
test_axes3d.py::test_scale3d_artists_log[png] 0 0.005 0.015 0.003

I will modify the tolerances for these two accordingly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic force-pushed the reset-tolerance branch 2 times, most recently from e5aad70 to de6b5b3 Compare April 7, 2026 04:51
@QuLogic

QuLogic commented Apr 7, 2026

Copy link
Copy Markdown
Member Author

Also noticed a few new tests in lib/mpl_toolkits/axisartist/tests/test_axis_artist.py that could have their tolerance reset.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic force-pushed the reset-tolerance branch from de6b5b3 to c566f42 Compare April 7, 2026 07:12
@QuLogic
QuLogic marked this pull request as ready for review April 7, 2026 18:36
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Apr 7, 2026
@QuLogic
TST: Reset tolerances on tests changed by text overhaul
bca638d
@QuLogic
QuLogic force-pushed the reset-tolerance branch from c566f42 to bca638d Compare April 7, 2026 18:44
timhoffm
timhoffm approved these changes Apr 8, 2026
View reviewed changes
tacaswell
tacaswell approved these changes Apr 8, 2026
View reviewed changes
@tacaswell
tacaswell merged commit ba56e3d into matplotlib:text-overhaul Apr 8, 2026
37 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Apr 8, 2026
@QuLogic
QuLogic deleted the reset-tolerance branch April 8, 2026 21:05
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jun 25, 2026
@QuLogic
TST: Increase some tolerances for non-x86_64 architectures
4970882 
All of these were tightened in matplotlib#31303, but it appears necessary to
increase these ones for at least aarch64, ppc64le, and s390x, so switch
the condition to the architecture. Note that our CI runs macOS on ARM,
so the conditions for those should be fine to switch to architectures,
since they aren't x86_64.
@QuLogic QuLogic mentioned this pull request Jun 25, 2026
TST: Increase some tolerances for non-x86_64 architectures #31946
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Maintenance topic: mplot3d

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @tacaswell @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.