GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TST: Increase some tolerances for non-x86_64 architectures by QuLogic · Pull Request #31946 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Jun 25, 2026

Copy link
Copy Markdown
Member

PR summary

All of these were tightened in #31303, but it appears necessary to increase these ones for at least aarch64, ppc64le, and s390x, so switch the condition to the architecture. Note that our CI runs macOS on ARM, so the conditions for those should be fine to switch to architectures, since they aren't x86_64.

AI Disclosure

None

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic
TST: Increase some tolerances for non-x86_64 architectures
4970882 
All of these were tightened in matplotlib#31303, but it appears necessary to
increase these ones for at least aarch64, ppc64le, and s390x, so switch
the condition to the architecture. Note that our CI runs macOS on ARM,
so the conditions for those should be fine to switch to architectures,
since they aren't x86_64.
@QuLogic QuLogic added this to the v3.11.1 milestone Jun 25, 2026
@QuLogic QuLogic added the topic: testing label Jun 25, 2026
@github-actions github-actions Bot added the topic: mplot3d label Jun 25, 2026
@QuLogic QuLogic mentioned this pull request Jun 25, 2026
Add loongarch64 image comparison tolerances #31940
Merged
1 of 5 tasks
@QuLogic

QuLogic commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I've confirmed that this fixes the build on the other architectures with a scratch build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell
tacaswell approved these changes Jun 26, 2026
View reviewed changes
timhoffm
timhoffm approved these changes Jun 26, 2026
View reviewed changes
@timhoffm
timhoffm merged commit 06ff6e0 into matplotlib:main Jun 26, 2026
44 of 46 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 26, 2026
Backport PR #31946 on branch v3.11.x (TST: Increase some tolerances for non-x86_64 architectures) #31948
Merged
@QuLogic
QuLogic deleted the arch-tolerances branch June 26, 2026 16:52
QuLogic pushed a commit that referenced this pull request Jun 27, 2026
@timhoffm @meeseeksmachine
Backport PR #31946: TST: Increase some tolerances for non-x86_64 arch…
d1902a5 
…itectures
QuLogic added a commit that referenced this pull request Jun 27, 2026
@QuLogic
Merge pull request #31948 from meeseeksmachine/auto-backport-of-pr-31…
517a456 
…946-on-v3.11.x

Backport PR #31946 on branch v3.11.x (TST: Increase some tolerances for non-x86_64 architectures)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: mplot3d topic: testing

Projects

None yet

Milestone

v3.11.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@QuLogic @tacaswell @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.