GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add loongarch64 image comparison tolerances by wszqkzqk · Pull Request #31940 · matplotlib/matplotlib

Conversation

@wszqkzqk

@wszqkzqk wszqkzqk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR summary

LoongArch64 Linux produces small rasterization differences compared to the x86_64 baselines, similar to the existing tolerances for macOS and ARM64.

This adds loongarch64 to the platform checks in the 15 image comparison tests that currently fail on LoongArch64.

Each value is reused from the one already used for darwin or aarch64 in the same test.

Verified by running the full matplotlib test suite on real LoongArch64 hardware on Arch Linux for Loong64. (Python 3.14, FreeType 2.13.1)

AI Disclosure

AI was used to help identify the failing tests, analyze the correlation with existing macOS/ARM64 tolerances to reuse the exsting code correctly.

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added first-contribution topic: mplot3d and removed first-contribution labels Jun 23, 2026
wszqkzqk added a commit to wszqkzqk/loongarch-packages that referenced this pull request Jun 23, 2026
@wszqkzqk
updpatch: python-matplotlib, ver=3.11.0-1
25fbb9f 
* Add loongarch64 image comparison tolerances
* See also: matplotlib/matplotlib#31940

Signed-off-by: Zhou Qiankang <[email protected]>
@wszqkzqk wszqkzqk mentioned this pull request Jun 23, 2026
updpatch: python-matplotlib, ver=3.11.0-1 lcpu-club/loongarch-packages#940
Merged
@oscargus

oscargus commented Jun 23, 2026

Copy link
Copy Markdown
Member

Thanks! There are some linting errors. Please run ruff format.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wszqkzqk

wszqkzqk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! There are some linting errors. Please run ruff format.

ruff format will cause huge diff.

According to doc/devel/coding_guide.rst:34-36, I manually fixed it.
oscargus reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oscargus

oscargus commented Jun 23, 2026

Copy link
Copy Markdown
Member

Ahh, right. I usually rely on pre-commit and had forgotten the details... :-)

Looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
oscargus
oscargus approved these changes Jun 23, 2026
View reviewed changes
@wszqkzqk
wszqkzqk marked this pull request as draft June 23, 2026 12:05
@wszqkzqk

wszqkzqk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I found something missing. I'll add it and resubmit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
wszqkzqk added a commit to wszqkzqk/loongarch-packages that referenced this pull request Jun 23, 2026
@wszqkzqk
xupdpatch: python-matplotlib, ver=3.11.0-1
9fe838e 
* Add loongarch64 image comparison tolerances
* See also: matplotlib/matplotlib#31940

Signed-off-by: Zhou Qiankang <[email protected]>
@wszqkzqk
wszqkzqk marked this pull request as ready for review June 23, 2026 12:40
@wszqkzqk

wszqkzqk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I found something missing. I'll add it and resubmit.

Previously, only 14 out of 15 repairs were covered.

Now the last one has also been included.

All done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
wszqkzqk added a commit to lcpu-club/loongarch-packages that referenced this pull request Jun 23, 2026
@wszqkzqk
updpatch: python-matplotlib, ver=3.11.0-1 (#940)
713ac69 
* Add loongarch64 image comparison tolerances
* See also: matplotlib/matplotlib#31940

Signed-off-by: Zhou Qiankang <[email protected]>
@oscargus oscargus added the topic: testing label Jun 24, 2026
@QuLogic

QuLogic commented Jun 25, 2026

Copy link
Copy Markdown
Member

Some of these should be a bit more generic, because they hit multiple architectures, see #31946
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the status: needs rebase label Jun 26, 2026
@wszqkzqk @tacaswell
Add loongarch64 image comparison tolerances
597c8e1 
Signed-off-by: Zhou Qiankang <[email protected]>
@github-actions github-actions Bot removed topic: mplot3d status: needs rebase labels Jun 26, 2026
@tacaswell

tacaswell commented Jun 26, 2026

Copy link
Copy Markdown
Member

I took the liberty of rebasing onto current main which made all but the one change redundant. @wszqkzqk Could you please verify that this still works for you?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell added this to the v3.11.1 milestone Jun 26, 2026
@wszqkzqk

wszqkzqk commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

I took the liberty of rebasing onto current main which made all but the one change redundant. @wszqkzqk Could you please verify that this still works for you?

Yes, it works well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
QuLogic
QuLogic approved these changes Jun 27, 2026
View reviewed changes
@QuLogic
QuLogic merged commit 86b939b into matplotlib:main Jun 27, 2026
39 of 41 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 27, 2026
Backport PR #31940 on branch v3.11.x (Add loongarch64 image comparison tolerances) #31958
Merged
@wszqkzqk
wszqkzqk deleted the loong64 branch June 27, 2026 03:28
rcomer pushed a commit that referenced this pull request Jun 27, 2026
@QuLogic @meeseeksmachine
Backport PR #31940: Add loongarch64 image comparison tolerances
95f0ddd
rcomer added a commit that referenced this pull request Jun 27, 2026
@rcomer
Merge pull request #31958 from meeseeksmachine/auto-backport-of-pr-31…
0798a1b 
…940-on-v3.11.x

Backport PR #31940 on branch v3.11.x (Add loongarch64 image comparison tolerances)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@oscargus oscargus oscargus approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.11.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@wszqkzqk @oscargus @QuLogic @tacaswell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.