GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reduce intersections by discriminants by ahejlsberg · Pull Request #36696 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We have long speculated that intersections of object types with discriminant properties of disjoint types should be eqivalent to never (the empty type), since objects of such types are not possible to construct. This PR finally implements that feature.

In addition to the intersection reduction implemented in #31838, an intersection T1 & T2 & ... & Tn is equivalent to never when

  • two or more of the Tx types have properties with the same name, and
  • in at least one group of properties with the same name, some property has a literal type and no property has type never, and
  • the intersection of the types of the properties in such a group is never.

An example:

type A = { kind: 'a', foo: string };
type B = { kind: 'b', foo: number };
type C = { kind: 'c', foo: number };

type AB = A & B;  // never
type BC = B & C;  // never

Previously, AB and BC appeared to be object-like types with kind properties of type never. Now, the types themselves are never because of the disjoint discriminant properties. This means that accessing properties on an empty intersection now produces errors, similarly to accessing properties on a never value:

declare let bc: B & C;
let foo = bc.foo;  // Error, but previously was ok

Because empty intersection types are equivalent to never, they disappear from union types:

declare let x: A | (B & C);
let a: A = x;  // Ok, but previousy was error

Previously, an error was reported in the example because x was considered to have a foo property of type string | number. With this PR there is no error because we treat B & C as never, and therefore A | (B & C) is equivalent to A.

It is obviously uncommon to have type annotations that explicitly intersect disjoint types, as in the examples above. The root cause of empty intersections is typically instantiations of generic types that intersect type parameters.

Note that elimination of empty intersections causes an observable difference between keyof (A & B) and keyof A | keyof B, where previously the two were always equivalent. The former now produces string | number | symbol (equivalent to keyof never), whereas the latter produces 'kind' | 'foo'.

This PR is technically a breaking change because code may exist that depends on empty intersections not being reduced away, even though this is incorrect from a typing perspective.

A note on the implementation of the feature:

In #31838 we reduce empty intersections to never immediately upon construction. However, in this PR we have to defer the determination because it requires us to resolve the types of properties in the constituent object types. Specifically, when two or more constituent object types have properties with the same name, we need to resolve the types of those properties in order to determine if they're disjoint discriminants, but doing so during intersection construction can easily cause circularities. So, instead of reducing intersections upon construction, we reduce them immediately before accessing members, relating them to other types, or converting them to their string representations in diagnostics and quick info. This is the purpose of the getReducedType function introduced by this PR.

Fixes #36736.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Igorbek, millsp, alitaheri, steida, SlurpTheo, mickdekkers, BridgeAR, and JasonMgz0411 reacted with thumbs up emoji
All reactions
  • 👍 8 reactions
Anders Hejlsberg (ahejlsberg) added 3 commits February 8, 2020 12:20
@ahejlsberg
Treat never-like intersections as never
ace0904
@ahejlsberg
Accept new baselines
eaf872c
@ahejlsberg
Fix compiler issues revealed by increased intersection correctness
94353d2
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 8, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at 94353d2. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 94353d2. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 94353d2. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 94353d2. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Feb 8, 2020
🤖 User test baselines have changed for neverLikeIntersections #36698
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg
Delete fourslash tests that are no longer applicable
346ec30
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 8, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at 346ec30. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 346ec30. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 346ec30. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 346ec30. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg
Include isNeverLikeIntersection check in getNormalizedType
acd3fec
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 9, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run dt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at acd3fec. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Anders Hejlsberg (ahejlsberg) added 2 commits February 9, 2020 17:40
@ahejlsberg
Erase never-like types in several more places
7ae4a21
@ahejlsberg
Check that base types are not never-like
3a1ba48
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run dt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 3a1ba48. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Anders Hejlsberg (ahejlsberg) added 2 commits February 10, 2020 09:15
@ahejlsberg
Add comments
e1434a5
@ahejlsberg
Revert isNeverLikeType check in getIndexType (keyof shouldn't resolve…
37c6280 
… member types)
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run dt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 37c6280. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Feb 10, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the perf test suite on this PR at 37c6280. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36696

Metric master 36696 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 356,865k (± 0.03%) 358,875k (± 0.03%) +2,010k (+ 0.56%) 358,634k 359,086k
Parse Time 1.61s (± 0.64%) 1.61s (± 0.43%) -0.00s (- 0.06%) 1.60s 1.63s
Bind Time 0.89s (± 0.50%) 0.88s (± 1.00%) -0.01s (- 0.90%) 0.86s 0.90s
Check Time 4.69s (± 0.53%) 4.69s (± 0.43%) -0.00s (- 0.09%) 4.66s 4.75s
Emit Time 5.23s (± 0.80%) 5.22s (± 0.51%) -0.01s (- 0.17%) 5.18s 5.29s
Total Time 12.42s (± 0.47%) 12.39s (± 0.36%) -0.03s (- 0.20%) 12.34s 12.54s
Monaco - node (v10.16.3, x64)
Memory used 364,650k (± 0.02%) 364,687k (± 0.01%) +37k (+ 0.01%) 364,615k 364,759k
Parse Time 1.25s (± 0.58%) 1.25s (± 0.80%) -0.00s (- 0.16%) 1.23s 1.27s
Bind Time 0.78s (± 0.75%) 0.77s (± 0.47%) -0.00s (- 0.39%) 0.77s 0.78s
Check Time 4.69s (± 0.42%) 4.68s (± 0.43%) -0.01s (- 0.21%) 4.64s 4.72s
Emit Time 2.90s (± 0.81%) 2.89s (± 0.89%) -0.01s (- 0.28%) 2.82s 2.93s
Total Time 9.62s (± 0.36%) 9.60s (± 0.46%) -0.02s (- 0.24%) 9.51s 9.67s
TFS - node (v10.16.3, x64)
Memory used 324,088k (± 0.01%) 324,207k (± 0.03%) +119k (+ 0.04%) 324,061k 324,410k
Parse Time 0.95s (± 0.52%) 0.95s (± 0.55%) -0.00s (- 0.31%) 0.94s 0.96s
Bind Time 0.75s (± 1.26%) 0.76s (± 1.88%) +0.01s (+ 1.07%) 0.71s 0.78s
Check Time 4.25s (± 0.58%) 4.28s (± 0.58%) +0.03s (+ 0.68%) 4.22s 4.35s
Emit Time 3.03s (± 0.86%) 3.01s (± 1.03%) -0.02s (- 0.59%) 2.93s 3.07s
Total Time 8.98s (± 0.60%) 8.99s (± 0.54%) +0.01s (+ 0.14%) 8.90s 9.14s
Angular - node (v12.1.0, x64)
Memory used 332,704k (± 0.03%) 334,652k (± 0.03%) +1,948k (+ 0.59%) 334,483k 334,823k
Parse Time 1.57s (± 0.60%) 1.57s (± 0.57%) -0.00s (- 0.06%) 1.55s 1.59s
Bind Time 0.87s (± 0.75%) 0.87s (± 0.56%) +0.01s (+ 0.69%) 0.86s 0.88s
Check Time 4.58s (± 0.61%) 4.60s (± 0.40%) +0.02s (+ 0.48%) 4.56s 4.64s
Emit Time 5.41s (± 0.59%) 5.41s (± 0.69%) -0.01s (- 0.11%) 5.29s 5.47s
Total Time 12.43s (± 0.43%) 12.45s (± 0.36%) +0.02s (+ 0.18%) 12.36s 12.55s
Monaco - node (v12.1.0, x64)
Memory used 344,537k (± 0.02%) 344,588k (± 0.01%) +51k (+ 0.01%) 344,479k 344,716k
Parse Time 1.21s (± 0.87%) 1.22s (± 0.74%) +0.00s (+ 0.08%) 1.20s 1.23s
Bind Time 0.75s (± 0.78%) 0.75s (± 0.99%) +0.01s (+ 0.80%) 0.74s 0.77s
Check Time 4.54s (± 0.44%) 4.55s (± 0.52%) +0.01s (+ 0.26%) 4.50s 4.60s
Emit Time 2.96s (± 0.61%) 2.95s (± 0.89%) -0.00s (- 0.14%) 2.90s 3.01s
Total Time 9.45s (± 0.40%) 9.47s (± 0.44%) +0.02s (+ 0.21%) 9.39s 9.56s
TFS - node (v12.1.0, x64)
Memory used 306,435k (± 0.02%) 306,452k (± 0.01%) +16k (+ 0.01%) 306,372k 306,571k
Parse Time 0.94s (± 0.80%) 0.94s (± 0.85%) -0.00s (- 0.21%) 0.93s 0.97s
Bind Time 0.71s (± 0.94%) 0.71s (± 1.07%) -0.00s (- 0.56%) 0.69s 0.73s
Check Time 4.17s (± 0.46%) 4.17s (± 0.49%) +0.00s (+ 0.05%) 4.13s 4.21s
Emit Time 3.08s (± 0.48%) 3.09s (± 0.88%) +0.01s (+ 0.29%) 3.03s 3.16s
Total Time 8.91s (± 0.21%) 8.91s (± 0.46%) +0.00s (+ 0.03%) 8.83s 9.02s
Angular - node (v8.9.0, x64)
Memory used 351,858k (± 0.01%) 353,918k (± 0.02%) +2,060k (+ 0.59%) 353,821k 354,052k
Parse Time 2.09s (± 0.42%) 2.12s (± 0.45%) +0.02s (+ 1.10%) 2.10s 2.15s
Bind Time 0.93s (± 1.09%) 0.94s (± 0.73%) +0.01s (+ 1.08%) 0.92s 0.95s
Check Time 5.45s (± 0.42%) 5.49s (± 0.66%) +0.03s (+ 0.61%) 5.39s 5.55s
Emit Time 6.20s (± 0.45%) 6.29s (± 1.09%) +0.09s (+ 1.52%) 6.16s 6.46s
Total Time 14.67s (± 0.33%) 14.83s (± 0.67%) +0.16s (+ 1.08%) 14.61s 15.00s
Monaco - node (v8.9.0, x64)
Memory used 362,969k (± 0.01%) 362,972k (± 0.01%) +4k (+ 0.00%) 362,859k 363,064k
Parse Time 1.56s (± 0.43%) 1.56s (± 0.37%) +0.00s (+ 0.19%) 1.55s 1.58s
Bind Time 0.95s (± 0.61%) 0.95s (± 0.68%) +0.00s (+ 0.11%) 0.94s 0.96s
Check Time 5.43s (± 1.60%) 5.44s (± 1.49%) +0.01s (+ 0.15%) 5.29s 5.56s
Emit Time 3.26s (± 4.78%) 3.17s (± 3.29%) -0.09s (- 2.79%) 2.98s 3.34s
Total Time 11.19s (± 0.69%) 11.12s (± 0.23%) -0.07s (- 0.67%) 11.07s 11.18s
TFS - node (v8.9.0, x64)
Memory used 323,469k (± 0.01%) 323,494k (± 0.01%) +26k (+ 0.01%) 323,387k 323,625k
Parse Time 1.26s (± 0.24%) 1.26s (± 0.44%) 0.00s ( 0.00%) 1.25s 1.27s
Bind Time 0.76s (± 0.63%) 0.76s (± 0.48%) -0.00s (- 0.13%) 0.75s 0.76s
Check Time 4.84s (± 0.51%) 4.83s (± 0.26%) -0.01s (- 0.27%) 4.79s 4.85s
Emit Time 3.20s (± 0.77%) 3.19s (± 0.77%) -0.01s (- 0.22%) 3.14s 3.27s
Total Time 10.06s (± 0.38%) 10.04s (± 0.35%) -0.02s (- 0.21%) 9.95s 10.12s
Angular - node (v8.9.0, x86)
Memory used 200,066k (± 0.04%) 201,176k (± 0.03%) +1,110k (+ 0.55%) 201,031k 201,317k
Parse Time 2.04s (± 0.98%) 2.06s (± 0.79%) +0.02s (+ 1.18%) 2.03s 2.11s
Bind Time 1.05s (± 0.90%) 1.05s (± 0.55%) +0.00s (+ 0.29%) 1.04s 1.06s
Check Time 4.97s (± 0.59%) 4.99s (± 0.47%) +0.02s (+ 0.38%) 4.95s 5.04s
Emit Time 6.13s (± 2.06%) 6.17s (± 1.74%) +0.04s (+ 0.67%) 6.00s 6.49s
Total Time 14.18s (± 1.01%) 14.27s (± 0.86%) +0.09s (+ 0.61%) 14.06s 14.63s
Monaco - node (v8.9.0, x86)
Memory used 203,771k (± 0.02%) 203,815k (± 0.02%) +45k (+ 0.02%) 203,688k 203,855k
Parse Time 1.60s (± 0.67%) 1.60s (± 0.30%) -0.00s (- 0.25%) 1.59s 1.61s
Bind Time 0.77s (± 1.09%) 0.77s (± 1.12%) +0.00s (+ 0.13%) 0.76s 0.80s
Check Time 5.17s (± 1.67%) 5.15s (± 1.00%) -0.02s (- 0.39%) 5.07s 5.26s
Emit Time 3.12s (± 2.63%) 3.16s (± 1.67%) +0.04s (+ 1.28%) 3.01s 3.23s
Total Time 10.67s (± 0.36%) 10.68s (± 0.34%) +0.02s (+ 0.15%) 10.61s 10.73s
TFS - node (v8.9.0, x86)
Memory used 182,630k (± 0.02%) 182,679k (± 0.02%) +49k (+ 0.03%) 182,613k 182,804k
Parse Time 1.30s (± 0.98%) 1.30s (± 0.68%) +0.00s (+ 0.08%) 1.28s 1.32s
Bind Time 0.71s (± 1.51%) 0.71s (± 0.81%) -0.00s (- 0.14%) 0.70s 0.73s
Check Time 4.60s (± 0.56%) 4.59s (± 0.55%) -0.01s (- 0.24%) 4.55s 4.68s
Emit Time 2.95s (± 1.07%) 2.96s (± 1.00%) +0.01s (+ 0.37%) 2.91s 3.05s
Total Time 9.57s (± 0.53%) 9.57s (± 0.32%) -0.00s (- 0.02%) 9.50s 9.65s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory2 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
Benchmark Name Iterations
Current 36696 10
Baseline master 10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lukaskl Lukas Klusis (lukaskl) mentioned this pull request May 13, 2020
New error: Type of property 'defaultProps' circularly references itself in mapped type #37597
Open
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request May 14, 2020
3.9 regression: TS2322 error around assignment of an inferred intersection to a union #38542
Closed
@andrewvarga

Andrew Varga (andrewvarga) commented May 18, 2020

Copy link
Copy Markdown

Since updating to 3.9 I have a compile error which I suspect is caused by this PR. The error might be valid, but could someone explain to me why?
Here is a sample code:

class A {
    private _name = "A";
    public y: number = 1;
}

class B {
    private _name = "B"
    public y: number = 2;
}

class C {
    public y: number = 3;
}

let c: A & B = new C();
// Error: Type 'C' is not assignable to type 'never'.
// The intersection 'A & B' was reduced to 'never' because property '_name' 
// exists in multiple constituents and is private in some.(2322)

What I'm not getting is why the private variable would have any say in this? I thought doing something like A & B should only look at the public interfaces of these objects, anything private wouldn't have any effect on the resulting type.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Gordon Smith (GordonSmith) added a commit to GordonSmith/lumino that referenced this pull request May 21, 2020
@GordonSmith
chore(build): Bump Typescript to 3.9.2
0961949 
Generate type files for older typescript compilers

Fixed issues relating to:  microsoft/TypeScript#36696

Signed-off-by: Gordon Smith <[email protected]>
Gordon Smith (GordonSmith) added a commit to GordonSmith/lumino that referenced this pull request May 21, 2020
@GordonSmith
chore(build): Bump Typescript to 3.9.2
ad4ebb7 
Generate type files for older typescript compilers

Fixed issues relating to:  microsoft/TypeScript#36696

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith Gordon Smith (GordonSmith) mentioned this pull request May 21, 2020
chore(build): Bump Typescript to 3.9.2 jupyterlab/lumino#75
Merged
Gordon Smith (GordonSmith) added a commit to GordonSmith/lumino that referenced this pull request May 22, 2020
@GordonSmith
chore(build): Bump Typescript to 3.9.2
35d0ee6 
Generate type files for older typescript compilers

Fixed issues relating to:  microsoft/TypeScript#36696

Signed-off-by: Gordon Smith <[email protected]>
Gordon Smith (GordonSmith) added a commit to GordonSmith/lumino that referenced this pull request May 22, 2020
@GordonSmith
chore(build): Bump Typescript to 3.9.2
c91fe96 
Generate type files for older typescript compilers

Fixed issues relating to:  microsoft/TypeScript#36696

Signed-off-by: Gordon Smith <[email protected]>
@yeliex yeliex (yeliex) mentioned this pull request May 23, 2020
[email protected] incompatible preonJs/preon#3
Closed
Gordon Smith (GordonSmith) added a commit to GordonSmith/lumino that referenced this pull request May 25, 2020
@GordonSmith
chore(build): Bump Typescript to 3.9.2
36debf6 
Generate type files for older typescript compilers

Fixed issues relating to:  microsoft/TypeScript#36696

Signed-off-by: Gordon Smith <[email protected]>
@telamonian Max Klein (telamonian) mentioned this pull request Jun 25, 2020
[Critical Bug] Changes to JSONObject in [email protected] are breaking jupyterlab extension builds jupyterlab/lumino#83
Closed
@dragomirtitian Titian Cernicova-Dragomir (dragomirtitian) mentioned this pull request Jul 1, 2020
unexpected behaviour when use Omit with Insection Types #39359
Closed
@weswigham

Wesley Wigham (weswigham) commented Oct 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Andrew Varga (@andrewvarga) This is a bit of a late comment, but it's because private class members, while their types aren't externally visible, nominally tag the containing class. These nominal tags are mutually exclusive, and are what result in the reduction (the field cannot possibly be satisfied by anything other than that class itself). Hence the error: The intersection 'A & B' was reduced to 'never' because property '_name' exists in multiple constituents and is private in some.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mkantor Matt Kantor (mkantor) mentioned this pull request Feb 18, 2021
It's possible to create a callable never #42859
Closed
@jcalz Joe Calzaretta (jcalz) mentioned this pull request Mar 6, 2021
StrictNullChck with Object.assign anomaly (Object is possibly 'undefined') #43110
Closed
LowR (lowr) added a commit to lowr/TypeScript that referenced this pull request Feb 6, 2022
@lowr
Reduce types before checking if they are never
3bf5323 
When types are checked if they are `never` by their `TypeFlags`, they
must first be reduced, because intersection types of object-like types
which reduce to `never` don't have `TypeFlags.Never`. See microsoft#36696 for
details.

When a function is declared to return such type and it doesn't contain
any return statement or it only contains return statements without
expression, the error messages are incorrect as the checker sees its
return type as non-`never`.

This commit takes into account that intersection types potentially
reduces to `never` and improves error messages.
LowR (lowr) added a commit to lowr/TypeScript that referenced this pull request Feb 6, 2022
@lowr
Reduce types before checking if they are never
0ffde2d 
When types are checked if they are `never` by their `TypeFlags`, they
must first be reduced, because intersection types of object-like types
which reduce to `never` don't have `TypeFlags.Never`. See microsoft#36696 for
details.

When a function is declared to return such type and it doesn't contain
any return statement or it only contains return statements without
expression, the error messages are incorrect as the checker sees its
return type as non-`never`.

This commit takes into account that intersection types potentially
reduces to `never` and improves error messages.
@lowr LowR (lowr) mentioned this pull request Feb 10, 2022
Empty intersections as function return types are not treated as never #47833
Open
This was referenced Mar 26, 2022
A complete guide to TypeScripts never type - zhenghao guevara/read-it-later#8383
Open
The type hierarchy tree - zhenghao guevara/read-it-later#8387
Open
@jcalz Joe Calzaretta (jcalz) mentioned this pull request May 26, 2022
Intersection Types that have overlapping properties can fail #49264
Closed
@github-actions github-actions Bot mentioned this pull request Aug 14, 2022
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164
Merged
@sbyeol3 SaetByeol Ahn (sbyeol3) mentioned this pull request Aug 24, 2022
[번역] 타입스크립트 Never 완벽 가이드 sbyeol3/articles#50
Open
@benjaminjkraft Ben Kraft (benjaminjkraft) mentioned this pull request Feb 28, 2023
Impossible intersection is supposedly never but any can still be assigned to it #53027
Open
@jcalz Joe Calzaretta (jcalz) mentioned this pull request Jul 7, 2023
Computation of intersection of multiple objects #54903
Closed
@rotu Dan Rose (rotu) mentioned this pull request Jan 29, 2024
Structural never type breaks conditional types #57210
Closed
@rotu Dan Rose (rotu) mentioned this pull request Feb 8, 2024
Conditional type unexpectedly non-distributive with never #57343
Closed
@jcalz Joe Calzaretta (jcalz) mentioned this pull request Sep 18, 2025
T[] | { t: 'a' } & { t: 'b' } is not iterable (TS2488) #62462
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh
+1 more reviewer
@alfaproject João Dias (alfaproject) alfaproject left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

Breaking Change Would introduce errors in existing code

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type intersection is not detected as empty through generics

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ahejlsberg @typescript-bot @weswigham @andrewvarga @alfaproject
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.