GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 🤖 User test baselines have changed for neverLikeIntersections by typescript-bot · Pull Request #36698 · microsoft/TypeScript

Conversation

@typescript-bot

@typescript-bot TypeScript Bot (typescript-bot) commented Feb 8, 2020

Copy link
Copy Markdown
Contributor

This test run was triggerd by a request on #36696
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc Anders Hejlsberg (@ahejlsberg)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Nathan Shively-Sanders (sandersn) and others added 5 commits February 6, 2020 14:38
@sandersn
Support property declarations in jsdoc template generation (microsoft…
2cc5856
…#36658)

* Support property declarations in jsdoc template generation

* fix lint and add test
@sandersn
Fix jsdoc comment parsing initial state (microsoft#36661)
1e48cbe
* Fix jsdoc comment parsing initial state

Jsdoc comment parsing can be invoked in two modes:

1. top-level parsing, for comments not inside a tag.
2. tag parsing, for comment that occur after the semantic parts of a
tag.

Top-level parsing skips an initial * because it assumes that it is starting
at the very beginning of a JSDoc comment. Tag parsing does not.

The two modes are distinguished by an optional second parameter named
`margin`. When `margin` is provided, it provides an initial indent used
for comment alignment.

Previously, the check for `margin` was a truthy check `if (margin)`.
This check incorrectly treats `margin=""` the same as
`margin=undefined`.

This PR changes the check to `if (margin !== undefined)`, which
correctly treats `margin=""` the same as `margin="    "`.

* Fixes for broken tests

1. Use SawAsterisk start state.
2. @template needs to skip asterisk in addition to whitespace while
parsing type parameter names.

* undo code move
@sandersn
redo microsoft#28564 (microsoft#36665)
71c1da0
TypeScript Bot
Update user baselines (microsoft#36669)
9096724
@jablko @sandersn
Either clone or pull, don't do both (microsoft#35230)
fa3173f
Co-authored-by: Nathan Shively-Sanders <[email protected]>
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Feb 8, 2020
Reduce intersections by discriminants #36696
Merged
Anders Hejlsberg (ahejlsberg) and others added 2 commits February 8, 2020 13:35
@ahejlsberg
Merge 346ec30 into fa3173f
ad3c933
@typescript-bot
Update user baselines
54db5d2
@typescript-bot
TypeScript Bot (typescript-bot) force-pushed the user-update-microsoft-20200106-neverLikeIntersections branch from 2bdbfdf to 54db5d2 Compare February 8, 2020 22:06
@weswigham Wesley Wigham (weswigham) closed this Mar 11, 2020
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@typescript-bot @weswigham @sandersn @jablko @ahejlsberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.