GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support full path for -project/-p paramater by saschanaz · Pull Request #4883 · microsoft/TypeScript

Conversation

@saschanaz

@saschanaz Kagami Sascha Rosylight (saschanaz) commented Sep 20, 2015

Copy link
Copy Markdown
Contributor

Fixes #2869.

  • Supports full path for -project
  • Requires tsconfig(-*).json file name for potential future tsconfig format change
  • Shows proper diagnostic message when tsconfig file cannot be found.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@saschanaz
support tsconfig full path
62df49f
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 20, 2015
@saschanaz Kagami Sascha Rosylight (saschanaz) closed this Sep 20, 2015
Kagami Sascha Rosylight (saschanaz) added 3 commits September 22, 2015 17:53
@saschanaz
format/existence check
2710030
@saschanaz
Merge remote-tracking branch 'Microsoft/master' into tsconfigpath
04d73ba
@saschanaz
update regex for filename
00a373a
@saschanaz Kagami Sascha Rosylight (saschanaz) reopened this Sep 22, 2015
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 22, 2015
@saschanaz
\. instead of .
c850919
@jbrantly James Brantly (jbrantly) mentioned this pull request Sep 25, 2015
TypeScript "non-standard" compiler options TypeStrong/discussions#1
Open
@saschanaz
Merge remote-tracking branch 'Microsoft/master' into tsconfigpath
d0a20c7
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Nov 18, 2015
consider allowing to specify the exact file instead of a folder that has a tsconfig.json #5705
Closed
DanielRosenwasser
DanielRosenwasser reviewed Nov 18, 2015
View reviewed changes
Comment thread src/compiler/tsc.ts Outdated

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Nov 18, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this const

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 18, 2015

Copy link
Copy Markdown
Member

I'm not sure we need the tsconfig- base, but I'm not against it. I think if you pull changes in and make sure lint rules are passing etc, this should be good.

Mohamed Hegazy (@mhegazy) Ryan Cavanaugh (@RyanCavanaugh) Vladimir Matveev (@vladima) opinions? Can you take a quick look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Kagami Sascha Rosylight (saschanaz) added 2 commits November 18, 2015 17:37
@saschanaz
Merge remote-tracking branch 'refs/remotes/Microsoft/master' into tsc…
c29501f 
…onfigpath
@saschanaz
const
8ca6b31
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 18, 2015

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) any idea why the lint rule is freaking out?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 18, 2015

Copy link
Copy Markdown
Member

I've got a fix ready in #5709.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saschanaz
Merge remote-tracking branch 'refs/remotes/Microsoft/master' into tsc…
0448eeb 
…onfigpath
paulvanbrenk
paulvanbrenk reviewed Nov 19, 2015
View reviewed changes
Comment thread src/compiler/tsc.ts Outdated

@paulvanbrenk Paul van Brenk (paulvanbrenk) Nov 19, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we should limit this to tsconfig.*.json, if you want to use blah I think we should simply allow that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 20, 2015

Copy link
Copy Markdown
Member

Kagami Sascha Rosylight (@saschanaz) can you resolve the merge conflicts?

I'm inclined to agree with Paul van Brenk (@paulvanbrenk) but I'd like to hear others' opinions on the matter.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Kagami Sascha Rosylight (saschanaz) added 2 commits November 20, 2015 11:23
@saschanaz
Merge remote-tracking branch 'refs/remotes/Microsoft/master' into tsc…
d87fc8b 
…onfigpath
@saschanaz
Merge remote-tracking branch 'refs/remotes/Microsoft/master' into tsc…
e5587fb 
…onfigpath

Conflicts:
	src/compiler/diagnosticMessages.json
@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Nov 20, 2015

Copy link
Copy Markdown
Contributor Author

Daniel Rosenwasser (@DanielRosenwasser) Paul van Brenk (@paulvanbrenk) I'm also not completely sure we should force the name format, I can remove it if there is no good reason. Maybe there will be other options when we once make some breaking changes on the tsconfig file format.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

I agree with Paul van Brenk (@paulvanbrenk) we do not really need this restriction. the tooling (VS, Sublime, VSCode, atom, etc..) will still look for your root/tsconfig.json just because having multiple of these does not tell you which one to use. but you can have tsconfig.dev.json or just es6.json and pass that to the --p option on the command line, and it should just work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saschanaz
removing filename requirement
880db38
@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Nov 24, 2015

Copy link
Copy Markdown
Contributor Author

The restriction is now removed as everyone thinks it is not needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@paulvanbrenk

Paul van Brenk (paulvanbrenk) commented Nov 24, 2015

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ryan Cavanaugh (RyanCavanaugh) added a commit that referenced this pull request Nov 24, 2015
@RyanCavanaugh
Merge pull request #4883 from SaschaNaz/tsconfigpath
2a21558 
Support full path for -project/-p paramater
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit 2a21558 into microsoft:master Nov 24, 2015
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Nov 24, 2015

Copy link
Copy Markdown
Member

Looks great. I'm very excited to use this myself!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blakeembrey Blake Embrey (blakeembrey) mentioned this pull request Nov 24, 2015
Resolve full path TypeStrong/tsconfig#17
Closed
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 25, 2015

Copy link
Copy Markdown
Member

Documented for 1.8 at microsoft/TypeScript-wiki@e529568

Thanks Kagami Sascha Rosylight (@saschanaz)!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saschanaz
Kagami Sascha Rosylight (saschanaz) deleted the tsconfigpath branch December 9, 2015 14:15
@blakeembrey Blake Embrey (blakeembrey) mentioned this pull request Mar 5, 2016
Improve development support: tsconfig files/exclude #7400
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@saschanaz @DanielRosenwasser @mhegazy @paulvanbrenk @RyanCavanaugh @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.