GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix prefer const rule by DanielRosenwasser · Pull Request #5709 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Nov 18, 2015

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) asap as possible

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Daniel Rosenwasser (DanielRosenwasser) added 2 commits November 18, 2015 01:41
@DanielRosenwasser
Fixed invalid code for binding expressions.
cf00746
@DanielRosenwasser
Simplify simplify simplify.
15d689c
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 18, 2015
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Nov 18, 2015
Support full path for -project/-p paramater #4883
Merged
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) force-pushed the fixPreferConstRule branch from 6dc5251 to c48b3cd Compare November 18, 2015 09:52
@DanielRosenwasser
Small refactorings.
cbb6165
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) force-pushed the fixPreferConstRule branch from c48b3cd to cbb6165 Compare November 18, 2015 09:53
Mohamed Hegazy (mhegazy) added a commit that referenced this pull request Nov 18, 2015
@mhegazy
Merge pull request #5709 from Microsoft/fixPreferConstRule
7389922 
Fix prefer const rule
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 7389922 into master Nov 18, 2015
@mhegazy
Mohamed Hegazy (mhegazy) deleted the fixPreferConstRule branch November 18, 2015 16:56
vladima
vladima reviewed Nov 18, 2015
View reviewed changes
Comment thread scripts/tslint/preferConstRule.ts

@vladima Vladimir Matveev (vladima) Nov 18, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that we can parse as property of ObjectLiteralExpression except PropertyAssignment and ShorthandPropertyAssignment is MethodDeclaration and it is already a grammar error to have it in destructuring assignment. So I think it is safe to ignore other syntax kinds

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@DanielRosenwasser @vladima @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.