GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in streams.md by jpbamberg1993 · Pull Request #12428 · nodejs/node

Conversation

@jpbamberg1993

@jpbamberg1993 jpbamberg1993 commented Apr 15, 2017

Copy link
Copy Markdown
Contributor
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels Apr 15, 2017
addaleax
addaleax approved these changes Apr 15, 2017
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good, but can you update the commit message to something like doc: fix typo in streams.md? If not, that can also be done when merging the PR.

(Also, this doesn’t need to wait 72 hours.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Apr 15, 2017
View reviewed changes
@jpbamberg1993
doc: fix typo in streams.md
b439860
@jpbamberg1993
jpbamberg1993 force-pushed the master branch from 2a9bef7 to b439860 Compare April 15, 2017 18:26
@jpbamberg1993 jpbamberg1993 changed the title api-docs streams: fix typo doc: fix typo in streams.md Apr 15, 2017
@jpbamberg1993

jpbamberg1993 commented Apr 15, 2017 via email

Copy link
Copy Markdown
Contributor Author
I believe I just updated it correctly
…
On Sat, Apr 15, 2017 at 1:03 PM Luigi Pinca ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12428 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALZAjtU7mOSi4qy2_ha7oZgWvvoIyj_Lks5rwPhwgaJpZM4M-ZdM> .
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 15, 2017

Copy link
Copy Markdown
Member

Landed in a6e4162, thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 15, 2017
addaleax pushed a commit that referenced this pull request Apr 15, 2017
@jpbamberg1993 @addaleax
doc: fix typo in streams.md
a6e4162 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@jpbamberg1993 @evanlucas
doc: fix typo in streams.md
43e9125 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
v7.10.0 proposal #12775
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@jpbamberg1993 @evanlucas
doc: fix typo in streams.md
2098867 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@jpbamberg1993 @evanlucas
doc: fix typo in streams.md
984232c 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
gibfahn pushed a commit that referenced this pull request May 15, 2017
@jpbamberg1993 @gibfahn
doc: fix typo in streams.md
af00d76 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@gibfahn gibfahn added the land-on-v6.x label May 15, 2017
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@jpbamberg1993 @MylesBorins
doc: fix typo in streams.md
c6f3ebd 
PR-URL: #12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@jpbamberg1993 @andrew749
doc: fix typo in streams.md
0f9b8f9 
PR-URL: nodejs/node#12428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jpbamberg1993 @addaleax @lpinca @gibfahn @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.