GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v6.11.0 proposal by MylesBorins · Pull Request #13059 · nodejs/node

Conversation

MylesBorins commented May 16, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

2017-06-06, Version 6.11.0 'Boron' (LTS), @MylesBorins

This LTS release comes with 126 commits. This includes 40 which are test related,
32 which are doc related, 12 which are build / tool related and 4 commits which are updates to dependencies.

Notable Changes

build:
- support for building mips64el (nanxiongchao) #10991
cluster:
- disconnect() now returns a reference to the disconnected worker. (Sean Villars) #10019
crypto:
- ability to select cert store at runtime (Adam Majer) #8334
- Use system CAs instead of using bundled ones (Adam Majer) #8334
- The Decipher methods setAuthTag() and setAAD now return this. (Kirill Fomichev) #9398
- adding support for OPENSSL_CONF again (Sam Roberts) #11006
- make LazyTransform compabile with Streams1 (Matteo Collina) #12380
deps:
- upgrade libuv to 1.11.0 (cjihrig) #11094
- upgrade libuv to 1.10.2 (cjihrig) #10717
- upgrade libuv to 1.10.1 (cjihrig) #9647
- upgrade libuv to 1.10.0 (cjihrig) #9267
dns:
- Implemented {ttl: true} for resolve4() and resolve6(). (Ben Noordhuis) #9296
process:
- add NODE_NO_WARNINGS environment variable (cjihrig) #10842
readline:
- add option to stop duplicates in history (Danny Nemer) #2982
src:
- support "--" after "-e" as end-of-options (John Barboza) #10651
tls:
- new tls.TLSSocket() supports sec ctx options (Sam Roberts) #11005
- Allow obvious key/passphrase combinations. (Sam Roberts) #10294

Commits

[d38364b062] - deps/v8: add missing #include "unicode/normlzr.h" (Bruno Pagani) #13040
[62a8f4774e] - async_wrap: close the destroy_ids_idle_handle_ (René Schünemann) #10385
[995423e790] - benchmark: terminate child process on Windows (Rich Trott) #12658
[32fa37f3d6] - benchmark: cleanup child_process IPC benchmark (Yuya Tanaka) #10557
[dd0b170b58] - build: fix case in lib names (Refael Ackermann) #12522
[bc64cf2b5e] - build: make linter targets silent (Sakthipriyan Vairamani (thefourtheye)) #12423
[a0973c3c1c] - build: don't create directory for NDK toolchain (TheBeastOfCaerbannog) #11916
[0c318a6157] - (SEMVER-MINOR) build: support for mips64el (nanxiongchao) #10991
[7c335f6b7c] - build: run cpplint even if jslint failed (Ruslan Bekenev) #12276
[32d7981741] - build: use do_not_edit variable where possible (Ruslan Bekenev) #12610
[c13429ad8f] - child_process: optimize IPC for large data (Yuya Tanaka) #10557
[ae587f3578] - (SEMVER-MINOR) cluster: return worker reference from disconnect() (Sean Villars) #10019
[e72749b319] - (SEMVER-MINOR) crypto: ability to select cert store at runtime (Adam Majer) #8334
[fd9bb56f9a] - (SEMVER-MINOR) crypto: Use system CAs instead of using bundled ones (Adam Majer) #8334
[bbfd2e309b] - (SEMVER-MINOR) crypto: do not use pointers to std::vector (Adam Majer) #8334
[875674bb1c] - (SEMVER-MINOR) crypto: return this in setAuthTag/setAAD (Kirill Fomichev) #9398
[f8da60fb21] - (SEMVER-MINOR) crypto: support OPENSSL_CONF again (Sam Roberts) #11006
[0a79b2da1b] - crypto: make LazyTransform compabile with Streams1 (Matteo Collina) #12380
[7678da4c65] - crypto: handle exceptions in hmac/hash.digest (Tobias Nießen) #12164
[e714243408] - deps: upgrade libuv to 1.11.0 (cjihrig) #11094
[738d830f09] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.2 (cjihrig) #10717
[c59370a8fd] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.1 (cjihrig) #9647
[3585ffa247] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.0 (cjihrig) #9267
[da70161308] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve6() (Ben Noordhuis) #9296
[0bc14b6d33] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve4() (Ben Noordhuis) #9296
[699e274693] - doc: add link on logo to README (Roman Reiss) #12307
[5ce108955d] - doc: fix an unclear wording in readline.md (Vse Mozhet Byt) #12605
[18c56df81e] - doc: fix typo in doc/api/process.md (morrme) #12612
[2b6e58852f] - doc: make commit guidelines easier to reference (Benjamin Fleischer) #11732
[928382d957] - doc: add suggestion to use --3way (Michael Dawson) #12510
[278e8cc65f] - doc: update link to Code of Conduct (Alex Autem) #12552
[3d526727f9] - doc: add lucamaraschi to collaborators (Luca Maraschi) #12538
[e1098a4e9f] - doc: unify spaces in a querystring.md code example (Vse Mozhet Byt) #12465
[9881da1585] - doc: run tests before landing changes (Rich Trott) #12416
[3556c177a3] - doc: avoid colloquialism (Rich Trott) #12417
[5fa417086a] - doc: fix encoding string in buffer example (MapleUncle) #12482
[bc401697f0] - doc: correct git fix whitespace command (Mateusz Konieczny) #12445
[26fcc7a4df] - doc: s/origin/upstream/ collaborator guide (Anna Henningsen) #12436
[e3352bbceb] - doc: update Mac OS X references in releases.md (JR McEntee) #12106
[32a6d87a21] - doc: correct markdown file line lengths (JR McEntee) #12106
[db4aef4ac6] - doc: change Mac OS X to macOS (JR McEntee) #12106
[40f292cacd] - doc: add missing ) in CONTRIBUTING.md (Mateusz Konieczny) #12444
[656c30e11d] - doc: add guide for backporting prs (Evan Lucas) #11099
[1c1269dfc3] - doc: update link for landing PRs (Rich Trott) #12415
[81b53503a7] - doc: add DavidCai1993 to collaborators (David Cai) #12435
[c6f3ebd774] - doc: fix typo in streams.md (John Paul Bamberg) #12428
[4a18e51c6a] - doc: add jkrems to collaborators (Jan Krems) #12427
[a6e06738ef] - doc: path functions ignore trailing slashes (Tobias Nießen) #12181
[929ca307d2] - doc: add info about serializable types (Shubheksha Jalan) #12313
[945dcde45b] - doc: fix formatting in onboarding-extras (Rich Trott) #12350
[3c1bd05a24] - doc: response.write ignores body in some cases (Ruslan Bekenev) #12314
[d2afd7c5f7] - doc: add AnnaMag to collaborators (AnnaMag) #12414
[dac66d5645] - doc: limit lines to 80 cols in internal README (Evan Lucas) #12358
[3ae8d00dd1] - doc: add single arg scenario for util.format (Tarun Batra) #12374
[43d3c009a5] - doc: fix formatting of TOC (Refael Ackermann) #12731
[9fc695c574] - doc: fixup the collaborators list (Alexey Orlenko) #12750
[ad29e295b7] - doc: gcc version is at least 4.8.5 in BUILDING.md (detailyang) #11840
[f2230cc0b5] - eslint: remove dead and unused symlink (Sam Roberts)
[ae1f6fd03a] - fs: re-enable watch facility in AIX (Gireesh Punathil) #10085
[6e6e63a341] - lib: fix typo in comments in module.js (WORMSS) #12528
[f20ebf29f6] - meta: update authors list (Aashil Patel) #11533
[b7ca74866b] - meta: move the Code of Conduct to TSC repository (James M Snell) #12147
[1bd07acbd1] - net: refactor onSlaveClose in Server.close (Claudio Rodriguez) #12334
[637d9e3544] - (SEMVER-MINOR) process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842
[202f00717b] - process: maintain constructor descriptor (Bryan English) #9306
[e9f33e392d] - readline: rename deDupeHistory option (Danny Nemer) #11950
[8bd6ab7870] - (SEMVER-MINOR) readline: add option to stop duplicates in history (Danny Nemer) #2982
[827411c1c0] - Revert "repl: disable Ctrl+C support on win32 for now" (Anna Henningsen) #8645
[ce795ecf2b] - src: remove invalid comment (cjihrig) #12645
[b296bd5ccc] - src: remove TODO about uv errno removal (Daniel Bevenius) #12536
[aec7ae2e67] - (SEMVER-MINOR) src: add SafeGetenv() to internal API (Sam Roberts) #11006
[f2e97f89f0] - src: make copies of startup environment variables (Ben Noordhuis) #11051
[c408a3bd63] - (SEMVER-MINOR) src: support "--" after "-e" as end-of-options (John Barboza) #10651
[f1ea36733d] - src: use std::list for at_exit_functions (Daniel Bevenius) #12255
[331681a3f5] - src: return early if nextTickQueue is empty (Trevor Norris) #10274
[b09f73813e] - test: cleanup test-fs-watch.js (RobotMermaid) #12595
[a1de1abcdd] - test: remove flaky designation for test on AIX (Rich Trott) #12564
[3cce18104d] - test: add mustCall in test-timers-clearImmediate (Zahidul Islam) #12598
[33821e42b5] - test: use block scoped variable names (Neehar Venugopal) #12544
[12287f1299] - test: dynamic port in cluster eaddrinuse (Sebastian Plesciuc) #12547
[53d5aacfe4] - test: dynamic port in cluster ipc throw (Sebastian Plesciuc) #12571
[0bd0d52af6] - test: replace assertion error check with regex (thelady) #12603
[8044b8307c] - test: refactored context type err message to regex (Muhsin Abdul-Musawwir) #12596
[32f905a85d] - test: improve test-process-chdir (vperezma) #12589
[51794dd7b0] - test: dynamic port in parallel cluster tests (Sebastian Plesciuc) #12584
[daf6535475] - test: dynamic port in cluster worker dgram (Sebastian Plesciuc) #12487
[b53d172576] - test: move test-debugger-repeat-last to sequential (kumarrishav) #12470
[32425be109] - test: use duplex streams in duplex stream test (cjihrig) #12514
[830949c8b0] - test: use JSON.stringify to trigger stack overflow (Yang Guo) #12481
[50bfb28960] - test: console.log removed from test-net-localport (Faiz Halde) #12483
[768431cac8] - test: dynamic port in cluster worker disconnect (Sebastian Plesciuc) #12457
[b1d26d8b55] - test: remove uses of common.PORT in test-tls-client tests (Ahmed Taj elsir) #12461
[ce3b544360] - test: dynamic port in cluster worker send (Sebastian Plesciuc) #12472
[a755ef0634] - test: increase coverage for buffer.js (Rich Trott) #12476
[a4b092c8f3] - test: complete coverage of lib/child_process.js (cjihrig) #12367
[4786ad7024] - test: buffer should always be stringified (Luca Maraschi) #12355
[04ec97e39a] - test: use dynamic port in test-cluster-bind-twice (Rich Trott) #12418
[3244ae36da] - test: remove common.PORT from test-cluster*.js (Tarun Batra) #12441
[384fa17ffa] - test: use dynamic port in 3 test-cluster-worker tests (Sebastian Plesciuc) #12443
[d54d0c4cdc] - test: add --use-bundled-ca to tls-cnnic-whitelist (Daniel Bevenius) #12394
[0caca45434] - test: add crypto check to crypto-lazy-transform (Daniel Bevenius) #12424
[861fa65bdf] - (SEMVER-MINOR) test: make tls-socket-default-options tests run (Sam Roberts) #11005
[7d47b02794] - test: remove common.PORT from test-cluster-basic (Rich Trott) #12377
[9e89edff87] - test: add hasCrypto check to test-debug-usage (Daniel Bevenius) #12357
[afac3161a8] - test: improve punycode coverage to check surrogate pair (Nao YONASHIRO) #12354
[a714449db3] - test: cleanup test-fs-watch.js (RobotMermaid) #12595
[89e76e8e4d] - test: improved type checking with regex (coreybeaumont) #12591
[c304414007] - test: improve test-tcp-wrap-listen (alohaglenn) #12599
[bea0a6e557] - test: add common.mustNotCall() (cjihrig) #11152
[cb63808832] - test: improve test-process-kill-pid (alohaglenn) #12588
[ac825fc8bc] - test: use common.js to check platform (Ruslan Bekenev) #12629
[64f9adc787] - test: cleanup test-util-inherits.js (RobotMermaid) #12602
[c1e4b2f043] - test: move test to sequential for reliability (Rich Trott) #12704
[cd1a7ea5e5] - test: add regex to text-crypto-random (Nate) #10020
[15226f597a] - test: add hasCrypto check to tls-socket-close (Daniel Bevenius) #11911
[7cad5613c7] - (SEMVER-MINOR) tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts) #11005
[df9d8ee6cb] - (SEMVER-MINOR) tls: allow obvious key/passphrase combinations (Sam Roberts) #10294
[a679e06c29] - tools: use no-useless-concat ESLint rule (Vse Mozhet Byt) #12613
[b920c5d44b] - tools: enable no-useless-return eslint rule (cjihrig) #12577
[fd126b5866] - tools: add root: true in main .eslintrc.yaml (Vse Mozhet Byt) #12570
[d63befac2a] - tools: Add no useless regex char class rule (Prince J Wesley) #9591
[87534d6c25] - tools: replace custom ESLint timers rule (Rich Trott) #12504
[736a736ed5] - tools: update ESLint to 3.19.0 (Rich Trott) #12162
[00b6646f93] - url: improve descriptiveness of identifier (Rich Trott) #12579
[a0f9d5964e] - v8: fix stack overflow in recursive method (Ben Noordhuis) #12460
[2b3381aec6] - Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" (Ben Noordhuis)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Trott and others added 23 commits

May 2, 2017 20:01


          tools: update ESLint to 3.19.0

736a736

Backport-PR-URL: #12504
PR-URL: #12162
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          tools: replace custom ESLint timers rule

87534d6

ESLint 3.19.0 allows the specification of selectors that represent
disallowed syntax. Replace our custom rule for timer arguments with a
pair of `no-restricted-syntax` option objects.

PR-URL: #12504
Reviewed-By: Myles Borins <[email protected]>


          tools: Add no useless regex char class rule

d63befa

Eslint Rule:
Disallow useless escape in regex character class
with optional override characters option and auto
fixable with eslint --fix option.

Usage:
no-useless-regex-char-class-escape: [2, { override: ['[', ']'] }]

PR-URL: #9591
Reviewed-By: Teddy Katz <[email protected]>


          doc: gcc version is at least 4.8.5 in BUILDING.md

ad29e29

>= 4.8.5 is required because of compiler bugs in earlier versions

PR-URL: #11840
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: add hasCrypto check to tls-socket-close

15226f5

Currently test-tls-socket-close will fail if node
was built using --without-ssl. This commit adds a check to
verify is crypto support exists and if not skip this test.

PR-URL: #11911
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: add regex to text-crypto-random

cd1a7ea

PR-URL: #10020
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          benchmark: cleanup child_process IPC benchmark

32fa37f

Squashed from:
- child_process: fix IPC bench to obey send() ret val
- child_process: fix IPC benchmark message has two more bytes
- child_process: use setImmediate for IPC bench

PR-URL: #10557
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          child_process: optimize IPC for large data

c13429a

Squashed from:
- child_process: stop indexOf() on whole IPC buffer
- child_process: get rid of forEach() and slice() in IPC
- child_process: get rid of another forEach() in IPC

Fixes: #3145
PR-URL: #10557
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          src: return early if nextTickQueue is empty

331681a

This brings the node::MakeCallback and node::AsyncWrap::MakeCallback
implementations into alignment in that they return early if the
nextTickQueue is empty after processing the MicrotaskQueue.

Include test to make sure early return happens. Test has text explaining
the conditions for the test to pass, since it relies on internal
mechanisms that aren't guaranteed in the future.

PR-URL: #10274
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          process: maintain constructor descriptor

202f007

Use the original property descriptor instead of just taking the value,
which would, by default, be non-writable and non-configurable.

PR-URL: #9306
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          src: use std::list for at_exit_functions

f1ea367

This change was suggested by bnoordhuis in the following comment:
#9163 (comment)

Not including any tests as this is covered by test/addons/at-exit.

PR-URL: #12255
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          crypto: handle exceptions in hmac/hash.digest

7678da4

Forced conversion of the encoding parameter to a string within
crypto.js, fixing segmentation faults in node_crypto.cc.

Fixes: #9819
PR-URL: #12164
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          doc: fixup the collaborators list

9fc695c

* Add the personal pronoun for @aqrln.
* Fix incorrectly ordered @lucamaraschi entry.

PR-URL: #12750
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>


          test: move test to sequential for reliability

c1e4b2f

test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          doc: fix formatting of TOC

43d3c00

PR-URL: #12731
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>


          test: cleanup test-util-inherits.js

64f9adc

Replaced constructor with regular expression for assert.throw().

PR-URL: #12602
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          build: use do_not_edit variable where possible

32d7981

We should not use hardcoded string to warn users about
file was generated by configure script. Since we already
have do_not_edit variable we can use it

PR-URL: #12610
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>


          test: use common.js to check platform

ac825fc

PR-URL: #12629
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>


          test: improve test-process-kill-pid

cb63808

PR-URL: #12588
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>


          eslint: remove dead and unused symlink

f2230cc

Symlink added in f44969a, but it doesn't point to a file, causing
problems for tooling.


          test: add common.mustNotCall()

bea0a6e

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: #11152
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>


          test: improve test-tcp-wrap-listen

c304414

PR-URL: #12599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>


          test: improved type checking with regex

89e76e8

Replaced TypeError with a regular expression of the actual error.

PR-URL: #12591
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

libuv

Issues and PRs related to the libuv dependency or the uv binding.

MylesBorins commented May 18, 2017

Copy link

Copy Markdown

Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8138/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/794/
rc.1: https://nodejs.org/download/rc/v6.11.0-rc.1/

Pulled in libuv 1.11.0 to fix the aix problems.

@nodejs/lts or any libuv folks LMK if there is a reason to roll this back

gibfahn and lots0logs reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silverwind and others added 4 commits

May 18, 2017 01:53


          doc: add link on logo to README

699e274

This is to override GitHub's default behaviour that links to the
image's source file, which isn't very helpful in our case.

PR-URL: #12307
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          deps: upgrade libuv to 1.11.0

e714243

Fixes: #10165
Fixes: #9856
Fixes: #10607
Fixes: #11104
PR-URL: #11094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          fs: re-enable watch facility in AIX

ae1f6fd

On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>


          test: remove flaky designation for test on AIX

a1de1ab

#5085 has been completed so
presumably test-fs-watch is not flaky on AIX anymore. Remove flaky
designation from sequential.status.

PR-URL: #12564
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

MylesBorins force-pushed the v6.11.0-proposal branch from e6a9ac0 to 8a15e69 Compare

May 18, 2017 05:54


          test: cleanup test-fs-watch.js

b09f738

Reversed "actual" and "expected" arguments for assert.strictEqual().

Replaced constructor with regular expression for assert.throws().

PR-URL: #12595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

MylesBorins force-pushed the v6.11.0-proposal branch from 8a15e69 to 1892149 Compare

May 18, 2017 06:01

MylesBorins added a commit that referenced this pull request

May 18, 2017


          2017-06-06, Version 6.11.0 'Boron' (LTS)

Notable Changes:

Coming Soon

PR-URL: #13059

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label

May 19, 2017

MylesBorins commented May 23, 2017

Copy link

Copy Markdown

Contributor Author

Auditing the citgm results per platform

OSX

node-sass
- timeout, passes locally

aix

/cc @nodejs/platform-aix

rimraf
- bluebird missing from tree (is this an NPM failure?)
sax
- bluebird missing from tree (is this an NPM failure?)
vinyl-fs
- install timeout
ws
- install timeout

TO BE CONTINUED

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

grahamaj mentioned this pull request

May 25, 2017

Configure the nodejs build to use os CA store smanders/externpro#140

Closed

MylesBorins commented Jun 5, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

One more citgm

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/852/

v6.10.3 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/856/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell commented Jun 5, 2017

Copy link

Copy Markdown

Member

List of commits LGTM. Nothing stands out as being a concern.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ArchangeGabriel and others added 2 commits

June 6, 2017 13:48


          deps/v8: add missing #include "unicode/normlzr.h"

d38364b

* The following function from <unicode/normlzr.h> is used:
     normalize()

* Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU.

Refs: #13022
PR-URL: #13040
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>


          2017-06-06, Version 6.11.0 'Boron' (LTS)

40859e2

This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    #10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    #10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    #8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    #8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    #9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    #11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    #12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    #11094
  - upgrade libuv to 1.10.2 (cjihrig)
    #10717
  - upgrade libuv to 1.10.1 (cjihrig)
    #9647
  - upgrade libuv to 1.10.0 (cjihrig)
    #9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    #9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    #10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    #10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    #11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    #10294

PR-URL: #13059

MylesBorins force-pushed the v6.11.0-proposal branch from 1892149 to 40859e2 Compare

June 6, 2017 18:17

MylesBorins merged commit 40859e2 into v6.x

Jun 6, 2017

MylesBorins added a commit that referenced this pull request

Jun 6, 2017


          Working on v6.11.1

f7ca483

PR-URL: #13059

MylesBorins added a commit that referenced this pull request

Jun 6, 2017


          2017-06-06, Version 6.11.0 'Boron' (LTS)

4c5cbb7

This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    #10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    #10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    #8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    #8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    #9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    #11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    #12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    #11094
  - upgrade libuv to 1.10.2 (cjihrig)
    #10717
  - upgrade libuv to 1.10.1 (cjihrig)
    #9647
  - upgrade libuv to 1.10.0 (cjihrig)
    #9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    #9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    #10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    #10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    #11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    #10294

PR-URL: #13059

gibfahn deleted the v6.11.0-proposal branch

June 6, 2017 22:34

pesho mentioned this pull request

Jun 7, 2017

Update for Node v6.11.0 LTS nodejs/docker-node#427

Merged

timbru31 mentioned this pull request

Jun 29, 2017

main/nodejs: upgrade to 6.11.0 alpinelinux/aports#1789

Closed

andrew749 pushed a commit to michielbaird/node that referenced this pull request

Jul 19, 2017


          2017-06-06, Version 6.11.0 'Boron' (LTS)

e5cdc26

This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    nodejs/node#10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    nodejs/node#10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    nodejs/node#8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    nodejs/node#8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    nodejs/node#9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    nodejs/node#11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    nodejs/node#12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    nodejs/node#11094
  - upgrade libuv to 1.10.2 (cjihrig)
    nodejs/node#10717
  - upgrade libuv to 1.10.1 (cjihrig)
    nodejs/node#9647
  - upgrade libuv to 1.10.0 (cjihrig)
    nodejs/node#9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    nodejs/node#9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    nodejs/node#10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    nodejs/node#2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    nodejs/node#10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    nodejs/node#11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    nodejs/node#10294

PR-URL: nodejs/node#13059

andrew749 pushed a commit to michielbaird/node that referenced this pull request

Jul 19, 2017


          Working on v6.11.1

40c6337

PR-URL: nodejs/node#13059

jBarz pushed a commit to ibmruntimes/node that referenced this pull request

Jul 27, 2017


          Working on v6.11.1

7c0e58e

PR-URL: nodejs/node#13059

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

libuv

Issues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MylesBorins commented May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2017-06-06, Version 6.11.0 'Boron' (LTS), @MylesBorins

Notable Changes

Commits

Uh oh!

MylesBorins commented May 18, 2017

Uh oh!

MylesBorins commented May 23, 2017

OSX

aix

Uh oh!

MylesBorins commented Jun 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jun 5, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

MylesBorins commented May 16, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins commented Jun 5, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.