GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate cluster tests from common.PORT by tarunbatra · Pull Request #12441 · nodejs/node

Conversation

@tarunbatra

@tarunbatra tarunbatra commented Apr 16, 2017

Copy link
Copy Markdown
Contributor

Migrate the following test files away from common.PORT:

  • test-cluster-disconnect-leak.js
  • test-cluster-disconnect-race.js
  • test-cluster-process-disconnect.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 16, 2017
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 16, 2017
Trott
Trott approved these changes Apr 16, 2017
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Apr 16, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7426/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request Apr 16, 2017
Remove common.PORT usage from parallel tests #12376
Closed
55 of 64 tasks
@tarunbatra

tarunbatra commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

@Trott It's green! 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Apr 16, 2017
View reviewed changes
lpinca
lpinca approved these changes Apr 16, 2017
View reviewed changes
santigimeno
santigimeno approved these changes Apr 16, 2017
View reviewed changes
@gibfahn

gibfahn commented Apr 16, 2017

Copy link
Copy Markdown
Member

Could you trim your commit message subjects to <50 chars as per the Contributing Guidelines?

You could also probably just make this one commit, as it's one change made to three files.

Maybe something like this?

test: remove common.PORT from cluster tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gibfahn
gibfahn approved these changes Apr 16, 2017
View reviewed changes
@tarunbatra
test: remove common.PORT from test-cluster*.js
8cf8208 
Refs: #12376
PR_URL: #12441
@tarunbatra

tarunbatra commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

@gibfahn Done!
gibfahn reacted with thumbs up emoji gibfahn reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 17, 2017
View reviewed changes
jasnell
jasnell approved these changes Apr 17, 2017
View reviewed changes
@jasnell

jasnell commented Apr 18, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7483/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Apr 18, 2017
@tarunbatra @jasnell
test: remove common.PORT from test-cluster*.js
415098f 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Apr 18, 2017

Copy link
Copy Markdown
Member

Landed in 415098f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 18, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
c75dd8b 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
v7.10.0 proposal #12775
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
ad7c1c6 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@tarunbatra @evanlucas
test: remove common.PORT from test-cluster*.js
a7e13e0 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn added the land-on-v6.x label May 16, 2017
gibfahn pushed a commit that referenced this pull request May 16, 2017
@tarunbatra @gibfahn
test: remove common.PORT from test-cluster*.js
08833f3 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@tarunbatra @MylesBorins
test: remove common.PORT from test-cluster*.js
3244ae3 
PR-URL: #12441
Ref: #12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@tarunbatra @andrew749
test: remove common.PORT from test-cluster*.js
eedba1c 
PR-URL: nodejs/node#12441
Ref: nodejs/node#12376
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@santigimeno santigimeno santigimeno approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@tarunbatra @Trott @gibfahn @jasnell @santigimeno @benjamingr @lpinca @cjihrig @mscdex @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.