GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tests: remove common.PORT from client abort by z0al · Pull Request #12461 · nodejs/node

Conversation

@z0al

@z0al z0al commented Apr 17, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs: #12376

Tests updated:

  • test/parallel/test-tls-client-abort.js
  • test/parallel/test-tls-client-abort2.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
z0al added 2 commits April 17, 2017 14:23
@z0al
test: change common.PORT to '0' in test/parallel/test-tls-client-abort
60e396c 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.
@z0al
test: use '0' as port in test-tls-client-abort2
e6a9f58 
Remove common.PORT in test-tls-client-abort2 and replace it with '0' to
eliminate EADDRINUSE errors.

Refs: #12376
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 17, 2017
cjihrig
cjihrig approved these changes Apr 17, 2017
View reviewed changes
jasnell
jasnell approved these changes Apr 17, 2017
View reviewed changes
Trott
Trott approved these changes Apr 17, 2017
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Apr 17, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7454/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
santigimeno
santigimeno approved these changes Apr 17, 2017
View reviewed changes
@Trott Trott mentioned this pull request Apr 18, 2017
Remove common.PORT usage from parallel tests #12376
Closed
55 of 64 tasks
jasnell pushed a commit that referenced this pull request Apr 19, 2017
@z0al @jasnell
test: remove uses of common.PORT in test-tls-client tests
825d390 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@jasnell

jasnell commented Apr 19, 2017

Copy link
Copy Markdown
Member

Landed in 825d390
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 19, 2017
@z0al
z0al deleted the change-port-in-tls-tests branch April 19, 2017 18:04
@z0al

z0al commented Apr 19, 2017

Copy link
Copy Markdown
Contributor Author

@jasnell thank you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
6bca9b5 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
v7.10.0 proposal #12775
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
6dd6e2d 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
ddc3528 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@gibfahn gibfahn added the land-on-v6.x label May 16, 2017
gibfahn pushed a commit that referenced this pull request May 16, 2017
@z0al @gibfahn
test: remove uses of common.PORT in test-tls-client tests
9ea65bf 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@z0al @MylesBorins
test: remove uses of common.PORT in test-tls-client tests
b1d26d8 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@z0al @andrew749
test: remove uses of common.PORT in test-tls-client tests
ad702a8 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: nodejs/node#12461
Ref: nodejs/node#12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@santigimeno santigimeno santigimeno approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@z0al @Trott @jasnell @santigimeno @cjihrig @gibfahn @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.