GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use JSON.stringify to trigger stack overflow by hashseed · Pull Request #12481 · nodejs/node

Conversation

@hashseed

@hashseed hashseed commented Apr 18, 2017

Copy link
Copy Markdown
Member

V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 18, 2017
ghost
ghost approved these changes Apr 18, 2017
View reviewed changes
addaleax
addaleax approved these changes Apr 18, 2017
View reviewed changes
thefourtheye
thefourtheye approved these changes Apr 18, 2017
View reviewed changes
@vsemozhetbyt

vsemozhetbyt commented Apr 18, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7471/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fhinkel
fhinkel approved these changes Apr 18, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Apr 18, 2017
View reviewed changes
benjamingr
benjamingr approved these changes Apr 18, 2017
View reviewed changes
jasnell
jasnell approved these changes Apr 18, 2017
View reviewed changes
@hashseed
test: use JSON.stringify to trigger stack overflow
2a3e8a3 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.
@hashseed
hashseed force-pushed the stackoverflow-test branch from e4e0808 to 2a3e8a3 Compare April 19, 2017 13:27
@hashseed hashseed changed the title test: use JSON.stringify trigger stack overflow test: use JSON.stringify to trigger stack overflow Apr 19, 2017
@hashseed

hashseed commented Apr 19, 2017

Copy link
Copy Markdown
Member Author

Fixed the commit title to add "to".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fhinkel

fhinkel commented Apr 21, 2017

Copy link
Copy Markdown
Contributor

Thanks. Landed in b73b903
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fhinkel fhinkel closed this Apr 21, 2017
fhinkel pushed a commit that referenced this pull request Apr 21, 2017
@hashseed @fhinkel
test: use JSON.stringify to trigger stack overflow
b73b903 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hashseed
hashseed deleted the stackoverflow-test branch April 25, 2017 05:08
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@hashseed @evanlucas
test: use JSON.stringify to trigger stack overflow
c748a72 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request May 1, 2017
v7.10.0 proposal #12775
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@hashseed @evanlucas
test: use JSON.stringify to trigger stack overflow
e14ab99 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@hashseed @evanlucas
test: use JSON.stringify to trigger stack overflow
f84a5e1 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn added the land-on-v6.x label May 16, 2017
@gibfahn

gibfahn commented May 16, 2017

Copy link
Copy Markdown
Member

Backported to v6.x, LMK if that was a mistake.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gibfahn pushed a commit that referenced this pull request May 16, 2017
@hashseed @gibfahn
test: use JSON.stringify to trigger stack overflow
c9c7911 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hashseed

hashseed commented May 16, 2017

Copy link
Copy Markdown
Member Author

Not wrong, but not necessary either. This is to prepare for V8's new compiler pipeline, which doesn't land until Node 8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@hashseed @MylesBorins
test: use JSON.stringify to trigger stack overflow
830949c 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@hashseed @andrew749
test: use JSON.stringify to trigger stack overflow
10026e6 
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: nodejs/node#12481
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
+3 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@hashseed @vsemozhetbyt @fhinkel @gibfahn @jasnell @thefourtheye @addaleax @benjamingr @cjihrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.