GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: move test to sequential for reliability by Trott · Pull Request #12704 · nodejs/node

Conversation

@Trott

@Trott Trott commented Apr 27, 2017

Copy link
Copy Markdown
Member

test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

Fixes: #10130

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test https freebsd

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: move test to sequential for reliability
75e284d 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

Fixes: nodejs#10130
@Trott Trott added freebsd Issues and PRs related to the FreeBSD platform. https Issues and PRs related to the https subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 27, 2017
@Trott

Trott commented Apr 27, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7719/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 27, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Stress test on this PR: https://ci.nodejs.org/job/node-stress-single-test/nodes=freebsd10-64/1179/console

Stress test on master showing failures: https://ci.nodejs.org/job/node-stress-single-test/1177/nodes=freebsd10-64/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 27, 2017
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes the stress test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gibfahn
gibfahn approved these changes Apr 27, 2017
View reviewed changes
hiroppy
hiroppy approved these changes Apr 28, 2017
View reviewed changes
jasnell
jasnell approved these changes Apr 28, 2017
View reviewed changes
santigimeno
santigimeno approved these changes Apr 28, 2017
View reviewed changes
mhdawson
mhdawson approved these changes Apr 28, 2017
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott added a commit to Trott/io.js that referenced this pull request Apr 30, 2017
@Trott
test: move test to sequential for reliability
0833d31 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: nodejs#12704
Fixes: nodejs#10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott

Trott commented Apr 30, 2017

Copy link
Copy Markdown
Member Author

Landed in 0833d31
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Apr 30, 2017
@evanlucas evanlucas mentioned this pull request May 1, 2017
v7.10.0 proposal #12775
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@Trott @evanlucas
test: move test to sequential for reliability
864cec7 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@Trott @evanlucas
test: move test to sequential for reliability
c75d723 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@Trott @evanlucas
test: move test to sequential for reliability
141c347 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 3, 2017
@Trott @evanlucas
test: move test to sequential for reliability
592db37 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gibfahn gibfahn added the land-on-v6.x label May 15, 2017
gibfahn pushed a commit that referenced this pull request May 15, 2017
@Trott @gibfahn
test: move test to sequential for reliability
c1e4b2f 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Trott @andrew749
test: move test to sequential for reliability
873451b 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: nodejs/node#12704
Fixes: nodejs/node#10130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott
Trott deleted the concurrency branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@santigimeno santigimeno santigimeno approved these changes
@cjihrig cjihrig cjihrig approved these changes
+3 more reviewers
@hiroppy hiroppy hiroppy approved these changes
@mhdawson mhdawson mhdawson approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

freebsd Issues and PRs related to the FreeBSD platform. https Issues and PRs related to the https subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-https-set-timeout-server on freebsd

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @jasnell @santigimeno @cjihrig @hiroppy @mhdawson @gibfahn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.