GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http2: improve http2 coverage by jasnell · Pull Request #15210 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Sep 5, 2017

Copy link
Copy Markdown
Member

Improve http2 coverage through refactoring and tests

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and apapirovski reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@jasnell
http2: improve http2 coverage
7acf26b 
Improve http2 coverage through refactoring and tests
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues and PRs related to the http2 subsystem. labels Sep 5, 2017
@jasnell
jasnell requested a review from mcollina September 5, 2017 22:04
@jasnell
[Squash] More coverage
fc66be7
@BridgeAR

BridgeAR commented Sep 9, 2017

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/10015/

[I posted the wrong one first]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@apapirovski

apapirovski commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Would be nice to see this get reviewed & merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 13, 2017
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcollina

mcollina commented Sep 13, 2017

Copy link
Copy Markdown
Member

This does not land cleanly, it needs a rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Sep 13, 2017
@jasnell
http2: improve http2 coverage
ad3d899 
Improve http2 coverage through refactoring and tests

PR-URL: #15210
Reviewed-By: Matteo Collina <[email protected]>
@jasnell

jasnell commented Sep 13, 2017

Copy link
Copy Markdown
Member Author

It just needed a -3 to land. Landed in ad3d899
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Sep 13, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@jasnell @addaleax
http2: improve http2 coverage
a07a910 
Improve http2 coverage through refactoring and tests

PR-URL: nodejs/node#15210
Reviewed-By: Matteo Collina <[email protected]>
jasnell added a commit that referenced this pull request Sep 20, 2017
@jasnell
http2: improve http2 coverage
aa0917c 
Improve http2 coverage through refactoring and tests

PR-URL: #15210
Reviewed-By: Matteo Collina <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Node.js 8.6.0 Release Proposal #15509
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@jasnell Stephen Belanger
http2: improve http2 coverage
9df7993 
Improve http2 coverage through refactoring and tests

PR-URL: nodejs/node#15210
Reviewed-By: Matteo Collina <[email protected]>
@MylesBorins MylesBorins added the dont-land-on-v6.x label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jasnell @BridgeAR @apapirovski @mcollina @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.