GeezerVison is showing github.com — Node.js 8.6.0 Release Proposal by jasnell · Pull Request #15509 · nodejs/node
Conversation
jasnell
commented
Sep 20, 2017
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Target Release Date: 2017-09-26
Notable Changes
- crypto
- Support for multiple ECDH curves. #15206
- dgram
- Added
setMulticastInterface() API. #7855
- n-api
- The command-line flag is no longer required to use N-API. #14902
- tls
- Docs-only deprecation of
parseCertString(). #14245
- New Contributors
Commits
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss, apapirovski, and wayofthefuture reacted with thumbs up emoji
bricss, digitalinfinity, and tniessen reacted with heart emoji
All reactions
-
👍
3 reactions
-
❤️
3 reactions
This error code originally landed in a semver-major commit and is used
by the ESM implementation. This backport includes the error message
and the documentation for the error.
I did attempt to write a test for this, but it did not seem possible
to catch an exception during import, I was also unable to execute
`node --experimental-modules` properly inside of a child_process.
I'll dig more into getting a test together, but we should backport
this fix in the mean time.
Refs: #14423
Fixes: #15374
PR-URL: #15388
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Setting writable = false in IncomingMessage.end made some errors
being swallowed in some very popular OSS libraries that we must
support. This commit add some of those use cases to the tests,
so we avoid further regressions.
We should reevaluate how to set writable = false in IncomingMessage
in a way that does not break the ecosystem.
See: #14024
Fixes: #15029
PR-URL: #15404
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Using SSL_CTX_set1_curves_list() (OpenSSL 1.0.2+), this allows to set
colon separated ECDH curve names in SecureContext's ecdhCurve option.
The option can also be set to "auto" to select the curve automatically
from list built in OpenSSL by enabling SSL_CTX_set_ecdh_auto()
(OpenSSL 1.0.2+).
PR-URL: #15206
Ref: #15054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
test-require-symlink modifies the fixture directory by adding a symlink.
Copy the fixture to the test tmpdir instead of modifying the fixture
directory.
This also uses a more empirical test for checking for the ability to
make symlinks on Windows.
PR-URL: #15067
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.
PR-URL: #15104
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.
Fixes: #15385
PR-URL: #15415
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
fix documentation for methods getHeader, setHeader and removeHeader
for http.ClientRequest class. The documentation said these functions
can be called but they're wasn't describe into the API description yet.
add parameters and general description for each methods.
PR-URL: #15163
Fixes: #15048
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
The benchmarks for `assert` all take a `method` configuration option,
but the allowable values are different across the files. For each
benchmark, provide an arbitrary default if `method` is set to an empty
string. This allows all the `assert` benchmarks to be run with a single
command but only on a single method. This is primarily useful for
testing that the assert benchmark files don't contain egregious errors.
(In other words, it's useful for testing.)
PR-URL: #15174
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to
a hardcoded index. Calculate the index based on `len` so benchmark can
be run with small `len` values if desired.
PR-URL: #15174
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
As per discussion in abi-stable-node:
nodejs/abi-stable-node#256,
take a refactor to napi_addon_register_func such that
the result from the register function is assigned to
the module exports property. By making this change,
native module can be agnostic about which type of
module the environment supports.
PR-URL: #15088
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@nodejs/collaborators @nodejs/tsc ... please take a final look. This will be going out today.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fishrock123
commented
Sep 26, 2017
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Were the N-API changes that were wanted to be made before it was unflagged ever done?
Certainly seems fine otherwise.
There isn't any mention of it, is this supposed to be LTS: Carbon?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There isn't any mention of it, is this supposed to be LTS: Carbon?
No. The LTS release will come later.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Were the N-API changes that were wanted to be made before it was unflagged ever done?
As far as I understand.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@jasnell it would be nice to land #15581 on master and add it to this release if it's not to late, otherwise no problem.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.
PR-URL: #15581
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lpinca reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
apapirovski reacted with hooray emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Unable to proceed with the build due to an issue with the ci-release infrastructure. No response yet from @nodejs/build team members .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
* **crypto**
* Support for multiple ECDH curves. [#15206](#15206)
* **dgram**
* Added `setMulticastInterface()` API. [#7855](#7855)
* Custom lookup functions are now supported. [#14560](#14560)
* **n-api**
* The command-line flag is no longer required to use N-API. [#14902](#14902)
* **tls**
* Docs-only deprecation of `parseCertString()`. [#14245](#14245)
* **New Contributors**
* Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
No response yet from @nodejs/build team members .
Did you just ping on IRC? Didn't see anything in nodejs/build or nodejs/node.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It's up and going now. I pinged in the node-dev channel, pinged several individually via irc, pinged michael via hangouts and twitter dm... didn't want to spam the entire team tho :-)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
mcollina
mcollina approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
meta
Issues and PRs related to the general management of the project.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|