GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix emitKeypressEvents stream type by Oblosys · Pull Request #15399 · nodejs/node

Conversation

@Oblosys

@Oblosys Oblosys commented Sep 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes the type of the stream argument in the description of readline.emitKeyPressEvents, from Writable to Readable.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Oblosys
doc: fix emitKeypressEvents stream type
9474739
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. readline Issues and PRs related to the built-in readline module. labels Sep 13, 2017
cjihrig
cjihrig approved these changes Sep 14, 2017
View reviewed changes
lpinca
lpinca approved these changes Sep 14, 2017
View reviewed changes
jasnell
jasnell approved these changes Sep 14, 2017
View reviewed changes
jasnell pushed a commit that referenced this pull request Sep 15, 2017
@Oblosys @jasnell
doc: fix emitKeypressEvents stream type
8bd1668 
PR-URL: #15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Sep 15, 2017

Copy link
Copy Markdown
Member

Landed in 8bd1668
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Sep 15, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@Oblosys @addaleax
doc: fix emitKeypressEvents stream type
acb32fc 
PR-URL: nodejs/node#15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@Oblosys @jasnell
doc: fix emitKeypressEvents stream type
a53a0d8 
PR-URL: #15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Node.js 8.6.0 Release Proposal #15509
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@Oblosys Stephen Belanger
doc: fix emitKeypressEvents stream type
0d39435 
PR-URL: nodejs/node#15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added the lts-watch-v6.x label Oct 17, 2017
@MylesBorins

MylesBorins commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

is this applicable to v6.x?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Oblosys

Oblosys commented Oct 17, 2017

Copy link
Copy Markdown
Contributor Author

Yes, it is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Oblosys
Oblosys deleted the readline-doc-fix branch October 17, 2017 15:09
@MylesBorins MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Nov 14, 2017
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@Oblosys @MylesBorins
doc: fix emitKeypressEvents stream type
b76d9d4 
PR-URL: #15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
v6.12.1 proposal #17180
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Oblosys @MylesBorins
doc: fix emitKeypressEvents stream type
5339983 
PR-URL: #15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Oblosys @MylesBorins
doc: fix emitKeypressEvents stream type
ff66d63 
PR-URL: #15399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Oblosys @jasnell @MylesBorins @lpinca @cjihrig @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.