GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert: repl: support top-level await by cjihrig · Pull Request #17807 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

This reverts #15566

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps, test, repl

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vdeturckheim and AlicanC reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
cjihrig added 5 commits December 21, 2017 12:15
@cjihrig
Revert "deps: import [email protected]"
22ff8a6 
This reverts commit e38570f.
@cjihrig
Revert "test: add test for importing acorn"
5594550 
This reverts commit 7ce6d23.
@cjihrig
Revert "repl: add an internal "paused" mode"
471bb99 
This reverts commit cff6e69.
@cjihrig
Revert "repl: add async and await as keywords"
8103640 
This reverts commit ab64b6d.
@cjihrig
Revert "repl: support top-level await"
e1838b4 
This reverts commit eeab7bc.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs involving general changes in the lib/ or src/ directories. label Dec 21, 2017
@cjihrig cjihrig mentioned this pull request Dec 21, 2017
repl: support top-level await #15566
Closed
3 of 4 tasks
mcollina
mcollina approved these changes Dec 21, 2017
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell

jasnell commented Dec 21, 2017

Copy link
Copy Markdown
Member

I'm +1 on this but I would also be plus one on keeping the new functionality as experimental and keeping it behind a flag while the issues are worked through. Top level await is quite popular and users want it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

Yes, I'm definitely in favor of having top level await. I put this together to give us one option.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Dec 21, 2017

Copy link
Copy Markdown
Member

Commit logs need more context. I, for one, have no idea why it's being reverted.
ChALkeR and raxod502 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu
TimothyGu suggested changes Dec 21, 2017
View reviewed changes

@TimothyGu TimothyGu left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 from me because of #15566 (comment). I’d rather see it being hidden behind a flag, an approach okay with @bmeck in #15566 (comment).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcollina

mcollina commented Dec 21, 2017

Copy link
Copy Markdown
Member

I’m ok for a flag too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

A flag it is then!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig closed this Dec 21, 2017
@cjihrig
cjihrig deleted the revert branch December 21, 2017 21:47
@TimothyGu TimothyGu mentioned this pull request Mar 26, 2018
repl: hide top-level await feature behind a flag #19604
Closed
3 tasks done
TimothyGu added a commit to TimothyGu/node that referenced this pull request Apr 14, 2018
@TimothyGu
repl: hide top-level await feature behind a flag
d8d5c2a 
Refs: nodejs#17807
Refs: nodejs#15566 (comment)
TimothyGu added a commit that referenced this pull request Apr 18, 2018
@TimothyGu
repl: hide top-level await feature behind a flag
be92eab 
PR-URL: #19604
Refs: #17807
Refs: #15566 (comment)
Reviewed-By: Gus Caplan <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@TimothyGu @jasnell
repl: hide top-level await feature behind a flag
f2396ee 
PR-URL: #19604
Refs: #17807
Refs: #15566 (comment)
Reviewed-By: Gus Caplan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
+1 more reviewer
@TimothyGu TimothyGu TimothyGu requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @jasnell @bnoordhuis @mcollina @TimothyGu @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.