GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: hide top-level await feature behind a flag by TimothyGu · Pull Request #19604 · nodejs/node

Conversation

@TimothyGu

@TimothyGu TimothyGu commented Mar 26, 2018

Copy link
Copy Markdown
Member

Refs: #17807
Refs: #15566 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TimothyGu
TimothyGu requested a review from bmeck March 26, 2018 03:23
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. repl Issues and PRs related to the REPL subsystem. labels Mar 26, 2018
@vsemozhetbyt

vsemozhetbyt commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

Should this be documented?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt added the promises Issues and PRs related to ECMAScript promises. label Mar 26, 2018
@TimothyGu

TimothyGu commented Mar 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@vsemozhetbyt Done.

CI: https://ci.nodejs.org/job/node-test-commit/17264/
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devsnek
devsnek approved these changes Mar 29, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt reviewed Mar 29, 2018
View reviewed changes
Comment thread doc/api/repl.md Outdated

@vsemozhetbyt vsemozhetbyt Mar 29, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe const timeout = and const old = to not emphasize sloppy mode?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
TimothyGu added 2 commits April 14, 2018 16:21
@TimothyGu
repl: hide top-level await feature behind a flag
d8d5c2a 
Refs: nodejs#17807
Refs: nodejs#15566 (comment)
@TimothyGu
fixup! repl: hide top-level await feature behind a flag
ce1f2d5
@TimothyGu
TimothyGu force-pushed the repl-await-flag branch from e4a8224 to ce1f2d5 Compare April 14, 2018 23:22
@TimothyGu

TimothyGu commented Apr 14, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Rebased. @bmeck, @vsemozhetbyt PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/14296/

CI: https://ci.nodejs.org/job/node-test-pull-request/14297/

CI: https://ci.nodejs.org/job/node-test-pull-request/14298/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu added 3 commits April 14, 2018 16:23
@TimothyGu
fixup! repl: hide top-level await feature behind a flag
7dfd660
@TimothyGu
fixup! fixup! repl: hide top-level await feature behind a flag
96206f9
@TimothyGu
fixup! fixup! repl: hide top-level await feature behind a flag
45d2205
@TimothyGu

TimothyGu commented Apr 15, 2018

Copy link
Copy Markdown
Member Author

I'll be landing this in a few days.
devsnek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu added a commit that referenced this pull request Apr 18, 2018
@TimothyGu
repl: hide top-level await feature behind a flag
be92eab 
PR-URL: #19604
Refs: #17807
Refs: #15566 (comment)
Reviewed-By: Gus Caplan <[email protected]>
@TimothyGu

TimothyGu commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

Landed in be92eab.

@jasnell, this needs to go into 10.0.0 to alleviate @bmeck's concern.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimothyGu TimothyGu closed this Apr 18, 2018
@TimothyGu
TimothyGu deleted the repl-await-flag branch April 18, 2018 15:18
@vsemozhetbyt

vsemozhetbyt commented Apr 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@TimothyGu It seems the flag also should be mentioned in doc/api/cli.md and doc/node.1.
I am sorry I missed this( Excuse me for being too late.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added this to the 10.0.0 milestone Apr 18, 2018
@jasnell

jasnell commented Apr 18, 2018

Copy link
Copy Markdown
Member

Since this is semver-patch it will definitely make it in to 10.0.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimothyGu

TimothyGu commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

@vsemozhetbyt See #20133.
vsemozhetbyt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TimothyGu TimothyGu mentioned this pull request Apr 18, 2018
doc: fully document --experimental-repl-await #20133
Closed
3 tasks done
@vsemozhetbyt

vsemozhetbyt commented Apr 18, 2018

Copy link
Copy Markdown
Contributor

This should be backported with #20133
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu added a commit that referenced this pull request Apr 18, 2018
@TimothyGu
doc: fully document --experimental-repl-await
ceab78f 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@TimothyGu @jasnell
repl: hide top-level await feature behind a flag
f2396ee 
PR-URL: #19604
Refs: #17807
Refs: #15566 (comment)
Reviewed-By: Gus Caplan <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@TimothyGu @jasnell
doc: fully document --experimental-repl-await
56d6e82 
PR-URL: #20133
Fixes: #19604 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Krinkle Krinkle mentioned this pull request May 2, 2018
repl: allow await in REPL #13209
Closed
@webmaster128 webmaster128 mentioned this pull request Jul 21, 2018
Top-level await support in REPL TypeStrong/ts-node#245
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmeck bmeck Awaiting requested review from bmeck
2 more reviewers
@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. promises Issues and PRs related to ECMAScript promises. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TimothyGu @vsemozhetbyt @jasnell @devsnek @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.